The mdns_cpp from gocarlos

mdns_cpp's People

Stargazers

Watchers

mdns_cpp's Issues

no timeout for select() in MainLoop thread

I guess it make sense: there is no timeout for select specified. So program will never shutdown or shutdown if there will be no activity on the network.

mdns_cpp/src/mdns.cpp

Line 440 in 05b181c

if (select(nfds, &readfs, 0, 0, 0) >= 0) {

Not provide any other feature than the author?

Really just a C++ wrapper?
If I want to register many services at the same time, what should i do to use your code?

feature: add option to pass users logger

mdns_cpp: Compile error when building with MSYS2/MINGW.

When I try to build mdns_cpp on Windows with MSYS2/MINGW it fails with the following output:

$ cmake --build .
[ 10%] Building CXX object CMakeFiles/mdns_cpp.dir/src/logger.cpp.obj
[ 20%] Building CXX object CMakeFiles/mdns_cpp.dir/src/mdns.cpp.obj
C:\msys64\home\david\projects\mdns_cpp-master\src\mdns.cpp: In member function 'int mdns_cpp::mDNS::openServiceSockets(int*, int)':
C:\msys64\home\david\projects\mdns_cpp-master\src\mdns.cpp:38:26: error: 'in4addr_any' was not declared in this scope; did you mean 'in6addr_any'?
   38 |     sock_addr.sin_addr = in4addr_any;
      |                          ^~~~~~~~~~~
      |                          in6addr_any
mingw32-make[2]: *** [CMakeFiles\mdns_cpp.dir\build.make:91: CMakeFiles/mdns_cpp.dir/src/mdns.cpp.obj] Error 1
mingw32-make[1]: *** [CMakeFiles\Makefile2:88: CMakeFiles/mdns_cpp.dir/all] Error 2
mingw32-make: *** [Makefile:135: all] Error 2

The following patch removed the error and the mdns_cpp build succeeded. And the example programs seem to work as expected.

--- mdns.cpp.original 2022-09-07 14:22:48.000000000 +0800
+++ mdns.cpp  2023-08-10 21:23:03.502663800 +0800
@@ -35,7 +35,7 @@
     sockaddr_in sock_addr{};
     sock_addr.sin_family = AF_INET;
 #ifdef _WIN32
-    sock_addr.sin_addr = in4addr_any;
+    sock_addr.sin_addr.s_addr = INADDR_ANY;
 #else
     sock_addr.sin_addr.s_addr = INADDR_ANY;
 #endif