The repeater from go-pkgz

repeater's People

Contributors

Stargazers

Watchers

repeater's Issues

memory leak

I seems to find memory leak in Fixed Delay strategy but it may be in others.

if use shorted delay that repeats fun execution time then publisher routine will have locked on sending to signals channel.

maybe should use select for send.

select {
case <-ctx.Done():
	return
case ch <- struct{}{}:
	sleep(ctx, s.Delay)
}

instead

repeater/strategy/fixed.go

Lines 25 to 31 in 3d06550

    
           select { 
        
           case <-ctx.Done(): 
        
           	return 
        
           default: 
        
           	ch <- struct{}{} 
        
           	sleep(ctx, s.Delay) 
        
           }

func TestRepeaterMemoryLeak(t *testing.T) {
	unit := func(amout int) time.Duration {
		return time.Duration(amout) * 10 * time.Millisecond
	}

	leak := func() error {
		ctx, cancel := context.WithTimeout(context.Background(), unit(3))
		defer cancel()
		err := NewDefault(3, unit(1)).Do(ctx, func() error {
			time.Sleep(unit(2))

			select {
			case <-ctx.Done():
				return nil
			default:
				return fmt.Errorf("some err")
			}
		})
		return err
	}

	before := runtime.NumGoroutine()
	num := []int{}
	for i := 0; i <= 25; i++ {
		leak()
		num = append(num, runtime.NumGoroutine())
	}
	after := runtime.NumGoroutine()
	require.False(t, after > before, "looks like you have goroutines leak: %+v", num)
}

Recommend Projects