gmaiolo / remove-w3schools Goto Github PK

All the margins from the elements that are removed remain, probably because their containers are still on the page.

Spacing when not removed:

Spacing when removed:

W3 Schools showing up in google search results for me again.

Noticed on searches for some CSS things such as "css multi-column".

Extension is up to date, and I've double checked that it is enabled.

I'm getting w3schools links in my google search results again

The extension does not work for me anymore, there might have been an update on Google.

You made the best extension EVER!

I checked the console and this is what's spitting out. It's a different error message from #8.

Error handling response: TypeError: Cannot read property 'tId' of undefined
    at Object.<anonymous> (chrome-extension://gohnadkcefpdhblajddfnhapimpdjkje/scripts/remover.js:28:32)

w3schools results are showing up in my search results. A quick check doesn't see any problems:

• No messages in the console.
• document.querySelectorAll('div.g:not([style*="display:none"]):not([style*="display: none"]) .r > a[href*="www.w3schools.com"]') correctly returns: NodeList(3) [a, a, a]
• document.getElementById('main') correctly returns: <div id=​"main">​…​​

Not debugging further until there's confirmation that it's not just me.
Chrome Version 64.0.3282.167 (Official Build) (64-bit) OS X.

Error condition is chrome.browserAction.setIcon in bg.js. Chrome doesn't like it when the event is get_tId_and_wId, which doesn't have an icon set. Fixed it by duplicating one of the icon sets and keying it with get_tId_and_wId.

you probably need a dev account for that right? I might have it-would it be okay for me to publish this from my account?

Why limit to W3Schools.. user should be able to add other domains.. (experts-exchange.com comes to mind)

Migrate to ES6, to improve code readability, semantics and cleanness.

The extension currently has access to all subdomains of all Google Domains (*://*.google.com/* and so on in manifest.json). This includes rather sensitive stuff such as drive.google.com, pay.google.com and myaccount.google.com.

It would be more trustworthy if it only requests access to *://www.google.com/* (and so on). This would more or less restrict it to the search itself, I think.