globocom / share-bar Goto Github PK

Given the recent popular trends in adopting node and NPM in frontend build tooling, it would be nice to have this lib on NPM Plugin Registry, I couldn't find it there even though the lib is manage as npm package.

Nice reference: http://t.co/AaMpzXSUWm

Hello guys.

I'm using the latest version of share-bar. Anyway, is working as well. But every page appears that error at console:

Error: <path> attribute d: Expected number, "…0-23 5-31 12l209z". createSVG @ vendor.min.js:40 init @ vendor.min.js:40 ShareBar @ vendor.min.js:40 (anonymous function) @ app.min.js:2

Where:
vendor.min.js = jQuery + Foundation + Share-bar
app.min.js = App init, like this:

try {new ShareBar({'facebookAppId': 'x', 'networks': ['facebook', 'twitter', 'whatsapp', 'google', 'email']});} catch (e) {console.error(e);}

Anyone knows this problem?

Hi, thank you for this great plugin!

What do you think about adding Linkedin among the possible networks? The "content side" of LinkedIn has been growing a lot and I think it would be a great addition.

a comma is missing after 'linkedin' in the docs. Also, the console prints 'linkedin' is not a valid option

[
  'facebook',
  'twitter',
  'whatsapp',
  'google',
  'linkedin'
  'pinterest',
  'email'
]

Providing a data-short-url could enhance twitter sharing with big urls, so you could fill both data-url and data-short-url and depending on the service, it would pick the latter.

I'm missing a method to destroy the bar entirely. Obviously, if I delete the dom node of the bar, the plugin will not work as expected. However, this practice may cause memory leaks from event bindings and etc.
Am I being to perfectionist or it make sense?

Blocking javascript includes are bad for the web. See https://developers.google.com/analytics/devguides/collection/gajs/asyncTracking for an example on how to asynchronously include a javascript file.

There are some grammatical issues in Readme file.
I want to correct them and work on this issue as of Hackoberfest.

Publish share-bar in the bower.io as package could be a nice idea. 👍 for it.
What you think about it?

We're using this share-bar.
All buttons works, except Whatsapp. When touch, in mobile device, anything happens.
Anyone see this problem too?

PS.: tested in Android 4.4.4, with Whatsapp installed as well.