glitchii / embedbuilder Goto Github PK

Getting TypeError: currentURL is not a function when Auto-update URL options (if this is checked will get the error on window load) and Auto-update data link URL are checked.

The footer icon is not getting updated when an image is successfully uploaded from the device.
Steps to reproduce:

• Visit https://glitchii.github.io/embedbuilder/
• Upload footer icon from device
• Footer icon does not update on its own, neither I can see its URL in JSON tab.

After choose photo from button Browse
Show me error : Request Failed (Check Dev-Tool)
What That?

Error: ReferenceError: hljs is not defined
Found at: Bottom of the page. Fired by:

error = (msg, time) => {
            notif.innerHTML = msg, notif.style.display = 'block';
            time && setTimeout(() => notif.animate({ opacity: '0', bottom: '-50px', offset: 1 }, { easing: 'ease', duration: 500 })
                .onfinish = () => notif.style.removeProperty('display'), time);
            return false;
        }

At lines 96 - 101

Reproduction Steps:

• Clone repo
• Run index.js

But it seems to be working perfectly on chrome

idk wtf is wrong with the code so that it wont show correctly on my bot dashboard?
it works fine when i open it with live server

When editing the Title field, then collapsing or expanding another field and going back to the Title field, it collapses. so you have to expand it again to edit it. I guess this is because the Title field can't really expand and therefore the editing field and the expanding/collapsing hitbox overlap, leading to this behaviour.

Would appreciate a fix, really like the builder!

When editing an existing field, a new value object is created. A simple fix to this is to make minor changes to the index.js file. At line 454, replace

let jsonField = json.embed.fields[Array.from(fields.children).indexOf(field)];

with

let jsonField = json.embed.fields[Array.from(fields.children).indexOf(field)-2];

Source: Invalid array index

Edit:
-2 isn't a permanent / efficient fix, the extension was messing up with the textarea

Since discord now supports h1, h2, and h3 headings It would be lovely for the website to properly show them as well

Could you please add support for buttons?

The problem is that if I try to implement the code as a iframe to my website, I get this error below.

I tried to encode base64 url with java and thir website
https://www.base64decode.org/
Problem somtimes your datalinks starts ending with %3D unless i remove the %3D the base64 data is malformed
https://glitchii.github.io/embedbuilder/?data=JTdCJTIyZW1iZWQlMjIlM0ElN0IlN0QlMkMlMjJjb250ZW50JTIyJTNBJTIyVGhpcyUyMGlzJTIwYSUyMHByb2JsZSUyMiU3RA%3D%3D

This is my data parameter:
JTdCJTIyY29udGVudCUyMjolMjIlMjIsJTIyZW1iZWRzJTIyOiU1QiU3QiUyMnRpdGxlJTIyOiUyMioqU3RyZWFrJTIwemVyc3QlQzMlQjZydCEqKiUyMiwlMjJ0eXBlJTIyOiUyMnJpY2glMjIsJTIyZGVzY3JpcHRpb24lMjI6JTIyRGllJTIwJTNDIzg2MDg5MzM4NzY0NTY0ODkwNiUzRSUyMFN0cmVhayUyMHd1cmRlJTIwZ2Vicm9jaGVuOiU1Q25FcndhcnRldGUlMjBaYWhsOiUyMDE0JTVDbklucHV0JTIwdm9uJTIwJTNDQDk4MDQzNzQyOTI1NTMwNzMxNCUzRTolMjAxJTIyLCUyMmNvbG9yJTIyOjE2NzExNjgwLCUyMmZvb3RlciUyMjolN0IlMjJ0ZXh0JTIyOiUyMlNvbGx0ZSUyMGRlciUyMEVpbmRydWNrJTIwZW50c3RlaGVuLCUyMGRhcyUyMGRpZSUyMFN0cmVhayUyMGFic2ljaHRsaWNoJTIwemVyc3QlQzMlQjZydCUyMHd1cmRlJTIwdW5kJTIwZXMlMjBuaWNodCUyMGRhcyUyMGVyc3RlJTIwbWFsJTIwaXN0LCUyMGJpdHRlJTIwZW50c3ByZWNoZW5kZSUyME1hJUMzJTlGbmFobWVuJTIwZXJncmVpZmVuKHouQiUyMEF1c3NjaGx1c3MlMjB2b20lMjBDaGFubmVsKSElMjIlN0QlN0QlNUQlN0Q=

It was first URLEncoded and then hashed with base64.
When I manually reverse the process, everything works as it should. But when I open the url with the data parameter some characters break(Ü, Ö, ß etc., see below)

This is a nice integration, but can you make it that you can press a button and paste a webhook url in and send it to a channel instand?

As discord.js has released v13, we need to send array of embed (ex. .send({embeds: [embed]}) - old version .send(embed)), which current version of embed builder doesnt support it.

• Visit https://glitchii.github.io/embedbuilder/
• Fill out the embed with messages, copy the JSON.
• Send messages with the JSON you have pasted, it would only send contents.

Like the title says. I would love to replace CarlBot as all I use it for is embeds. CarlBot has commands to edit embeds it has posted such as.
embedsource <msg_ID> [channel]
then running ecembed <msg_ID> <JSON/Pastebin_Link/Starb.in_Link>
to edit the updated embed if this could be done in the editor even better but I would settle for commands :D

If you use the '>' indentation on your embed builder with more than one line it disposes of all but the first line.

Example to reproduce:
In a single embed field on your builder type the following.

test 1
test 2

Only test 1 will show in the preview.

Tested on Chromium based browser.

Embeds have some limits:

• Title is limited to 256 characters
• Description is limited to 4096 characters
• An embed can contain a maximum of 25 fields
• A field name/title is limited to 256 character and the value of the field is limited to 1024 characters
• Footer is limited to 2048 characters
• Author name is limited to 256 characters
• The total of characters allowed in an embed is 6000

It would be helpful to add some (maybe toggle show/hide) character counters and field counters. While text already stops when you hit the character count limit, and you already get an error message when trying to add a 26th field, etc. knowing how close you are to hitting the cap can be helpful. The overall 6000 character limit is especially tough to add up as you're developing an embed.

If you don't provide any guiTabs in the builder.config.js, the preview of the embed is broken. If you add in the assets/js/script.js on line 962 a if statement if there are any values inside the tabs array, you can prevent this.

E.g:

if (tabs.length) {
    for (const e of document.querySelectorAll(\`.${tabs.join(', .')}\`))  e.classList.add('active');
}

Discord's api now doesn't support parsing of json embeds with empty properties like this:
{"embed":{"title":"","description":"Hello! This won't work because title is empty and thumbnail url too!","color":4321431,"thumbnail":{"url":""}}}

So, I suggest to delete the property instead of letting it be "" (or empty array in case of fields), because discord doesn't support this now and this only causes problems.
It will look like this: {"embed":{"description":"Yay! No empty properties, now it works!","color":4321431}}

Same thing for content