giveth / common-contract-deps Goto Github PK

View Code? Open in Web Editor NEW

18.0 18.0 5.0 1.33 MB

Base layer smart contracts that Giveth likes to use :-D

License: GNU General Public License v3.0

JavaScript 41.73% Solidity 58.27%

common-contract-deps's People

Contributors

Stargazers

Watchers

Forkers

adria0 alonski sameer2800 frederikbolding dorucioclea

common-contract-deps's Issues

Owned removeOwnership won't work with web3 1.0

0xdac is not a valid address, so web3 1.0 will throw an error.

Change _dece to _dac and 0xdece to 0xdac

I wish i could type in decentralize and then have the contract be decentralized... but hex is soooooo limiting so lets move to just typing in dac and then it is decentralized :-D

Consistent behaviour in escapeHatch

If scape ethers fails => throws
If scape tokens fails => does nothing

In both cases should have the same behaviour.

We need to add a lot of comments

I made a lot of comments in the dev branch... this is me merging them... we will see how it goes (fingers crossed)

Upgrading NPM package

Current package version is 0.7.0, but npm package is 0.6.0
Also, it is important to note that there is problem in installing dependencies of version 0.6.0. Therefore every other projects depending on this projects will have problem too.

changeEscapeCaller() needs to be changeHatchEscapeCaller()

:-D

NPM Package needs to be updated

Expected Behavior:

NPM Package for this repository is updated with the most recent changes.

Current Behavior:

Currently the NPM Package is on an older version and thus has old contracts.
For example using SafeMath has Solidity warnings for not using pure functions even though this has already been fixed.

What needs to be done:

Deploy NPM Package to latest version of this repository

Prepare for solidity github syntax highlighting

Ref github-linguist/linguist#3973

Blacklisted tokens cannot be added to this contract

There is no place in this contract where the blacklistEscapeToken() function is called, but it is an internal function...

I imagine you want to add it into the constructor and have a loop... this might need some solid tests written for it as well.

I LOVE this feature by the way, I might suggest that it be an onlyEscapeHatchCallerOrOwner()function so that it can allow selective decentralization, and that way it can avoid the loop that might need to be in the constructor.

Thoughts?