Update the use of metadata.annotations.addons_repo_basepath to assume it ends with /
This allows the metadata value to be use for apps of application set bootstrap for example when used in argocd/ directory instead of the root
Change from:

$values{{metadata.annotations.addons_repo_basepath}}

to

$values/{{metadata.annotations.addons_repo_basepath}}

In bootstrap/control-plane/addons/aws/addons-aws-csi-fsx-driver-appset.yaml there is a line of code eks.amazonaws.com/role-arn: {{metadata.annotations.aws_fsx_csi_driver_iam_role_arn}}. I know the metadata comes from the secret created by the gitops-bridge-bootstrap module, but I'm unclear on how argocd knows to use that secret when templating out metadata.annotations.aws_fsx_csi_driver_iam_role_arn.

Add KEDA addon

Some charts have too many resources and is better to do selective sync

spec:
  syncPolicy:
    syncOptions:
    - ApplyOutOfSyncOnly=true

Remove the workaround for quotes for helm values

api gateway controller addon doesn't work

The account id, is doubled quoted is broken with latest version of the helm chart

Need to update helm chart

argocd events appset using wrong label enable_argo_workflows

make aws addons only install if aws region is present this allows to have open source addons install on none aws clusters

In all addons argocd app follow the pattern to specify the name using cluster name, but the cluster name can have upper case letters like using EKS cluster name "Carlos Cluster" we need to lower case and replace space with dash -

For example in https://github.com/gitops-bridge-dev/gitops-bridge-argocd-control-plane-template/blob/main/bootstrap/control-plane/addons/aws/addons-aws-load-balancer-controller-appset.yaml#L41

  template:
    metadata:
      name: addon-{{name}}-{{values.addonChart}}

We need to convert appset to goTemplate issue #46
Then use sprig function lower for example

  template:
    metadata:
      name: addon-{{.name | lower}}-{{.values.addonChart}}

Currently the application sets are deployed using an apps of appset argo application looking at the addons directory recursive.

In the Argo UI and listing application set gets clobber with empty application sets.

The end user will need to move the files of the application sets not wanted to the exclude/ directory.

Feedback from some users said it would be nice to have a helm charts that generates the application sets, and controlled which ones get installed with booleans in values.yaml

I think @morey-tech had a version of this in of the demos using gitops-bridge

remove external secret cluster directory since now we are doing resources from workload bootstrap appset https://github.com/gitops-bridge-dev/gitops-bridge/tree/main/argocd/iac/terraform/examples/eks/external-secrets

Some are but not all, we just need to make sure all of them are using goTemplate

ArgoCD goTemplate: https://argo-cd.readthedocs.io/en/stable/operator-manual/applicationset/GoTemplate/

Migration https://argo-cd.readthedocs.io/en/stable/operator-manual/applicationset/GoTemplate/#migration-guide

There are braking changes in argocd helm chart from 5.x to 6.x most around new ingress
https://github.com/argoproj/argo-helm/blob/main/charts/argo-cd/README.md#aws-application-load-balancer

gitpos bridge pattern is impressive,
but what's the difference with app of apps?

Should this be gitops-bridge instead of brige ?

Need to test and upgrade karpenter