The go-opstocat from github

go-opstocat's People

Contributors

Stargazers

Watchers

go-opstocat's Issues

opstocat crashes when using non-string configuration values

I think string only is probably wise, since you could conceivably stick anything in there. Perhaps we can validate the type or catch the panic and show a useful error message.

Example code:

package main

import (
  "github.com/github/go-opstocat"
  "os"
)

type Configuration struct {
  TestVal int `json:"TEST_VAL"`
  *opstocat.Configuration
}

func (c *Configuration) OpstocatConfiguration() *opstocat.Configuration {
  return c.Configuration
}

func (c *Configuration) SetupLogger() {}

func main() {
  wd, err := os.Getwd()
  if err != nil {
    panic(err)
  }

  inner := opstocat.NewConfiguration(wd)
  inner.App = "test"
  c := &Configuration{
    Configuration: inner,
  }

  opstocat.ReadEnv(c)
  opstocat.SetupLogger(c)
}

Result:

rubyist:octotest scott$ TEST_VAL=100 ./octotest
panic: reflect: call of reflect.Value.SetString on int Value

goroutine 16 [running]:
runtime.panic(0x278ae0, 0xc208043880)
    /usr/local/go/src/pkg/runtime/panic.c:279 +0xf5
reflect.flag.mustBe(0x26, 0x18)
    /usr/local/go/src/pkg/reflect/value.go:307 +0x8c
reflect.Value.SetString(0x21f3c0, 0xc208000ad0, 0x0, 0x26, 0x7fff5fbff12c, 0x3)
    /usr/local/go/src/pkg/reflect/value.go:1691 +0x3e
github.com/github/go-opstocat.readEnvConfig(0x2a1640, 0xc208000ad0)
    /Users/scott/src/gocode/src/github.com/github/go-opstocat/config.go:95 +0x2d6
github.com/github/go-opstocat.ReadEnv(0x5127b0, 0xc208000ad0)
    /Users/scott/src/gocode/src/github.com/github/go-opstocat/config.go:58 +0x67
main.main()
    /Users/scott/src/gocode/src/github.com/github/octotest/octotest.go:31 +0x10f

goroutine 19 [finalizer wait]:
runtime.park(0x14550, 0x466fd0, 0x465ac9)
    /usr/local/go/src/pkg/runtime/proc.c:1369 +0x89
runtime.parkunlock(0x466fd0, 0x465ac9)
    /usr/local/go/src/pkg/runtime/proc.c:1385 +0x3b
runfinq()
    /usr/local/go/src/pkg/runtime/mgc0.c:2644 +0xcf
runtime.goexit()
    /usr/local/go/src/pkg/runtime/proc.c:1445

Recommend Projects