Code Monkey home page Code Monkey logo

first-pr's People

Contributors

0tofu avatar ackey avatar d-ikeda avatar enomoto avatar fujifuji3284 avatar grappa1972 avatar himoiku avatar hirocaster avatar ishizeki avatar jp938402 avatar k-enomoto avatar kuron99 avatar masaka avatar mtakemi avatar nametaketakewo avatar nanakira avatar onsh avatar q-taro avatar quno avatar rmswimkktt avatar sasasa avatar satoyos avatar sempu-mizuha avatar smile-0yen avatar ta7uw avatar tomute avatar uenotakahiro avatar wolfmasa avatar yamaoka-takeshi avatar yukihir0 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

first-pr's Issues

Coverallsの設定ファイル(.coveralls.yml)の記述に関する指摘

GitHub実践入門の第8章「Githubと連携するツールとサービス」の「8.3 Coveralls」に.coveralls.ymlの記述内容が書かれています。具体的には以下。

service_name: travis
repo_token: xxxxxyyyyyzzzz

しかしhttps://coveralls.io/docs/ruby などを見るとrepo_tokenに関して"This is only needed for repos not using a CI and should be kept secret..."等と書かれているので、Travis CIと連携する場合には不要では無いでしょうか。
また、service_nameに関しても"This can be any string, but using travis-ci or travis-pro will allow Coveralls to fetch branch data, comment on pull requests, and more."とあるので、travis-ciとかの方が例としては相応しいかと思います。

github-book/work は誤作成ブランチ?

2019/06/08現在、GitHub実践入門の P132 のリモートブランチの作成git push origin workするとエラーになります。

$ git push origin work
To https://github.com/hogehoge/first-pr.git
 ! [rejected]        work -> work (non-fast-forward)
error: failed to push some refs to 'https://github.com/hogehoge/first-pr.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

原因は、すでに origin/work が存在する為だと思います。多分・・・。

フォーク後に、以下の操作で回避できます。
①「4 branches」とあるリンクボタンからブランチの一覧を表示。
②「work」とあるブランチの欄の右端にある赤いゴミ箱ボタンを押す。

これで、自分のとこにある既存の origin/work を消すことができます。
この状態で、git push origin workすれば、書籍記載の通りに作業継続できます。

※消すのが怖い人へ
 ここで消すことが可能なのは、あくまで自分のとこにあるブランチなので、何か誤った操作をして他の人に影響がでることはないので、自信を持ってどうぞ。
 皆様が参照することになるフォーク元の github-book 上にある work ブランチは、権限がないので消せないから大丈夫です。
 心配な方は、github-book 上で「4 branches」をクリックしてみてください。
 一覧は表示されますが、赤いゴミ箱ボタンが表示されなくて消せないことが確認できます。

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.