Code Monkey home page Code Monkey logo

Comments (16)

owocki avatar owocki commented on August 20, 2024 1

hey @mbeacom i think this is a fallout of the fulfiller_address migration maybe? seems that the .status() field is not populating correctly

from skunkworks.

gitcoinbot avatar gitcoinbot commented on August 20, 2024

This issue now has a funding of 0.1 ETH (73.56 USD) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $10845.74 more Funded OSS Work Available at: https://gitcoin.co/explorer

from skunkworks.

gitcoinbot avatar gitcoinbot commented on August 20, 2024

The funding of 0.1 ETH (73.56 USD) attached has been claimed by @eswarasai.

@eswarasai, please leave a comment to let the funder (@owocki) and the other parties involved your implementation plan. If you don't leave a comment, the funder may expire your claim at their discretion.

from skunkworks.

owocki avatar owocki commented on August 20, 2024

@eswarasai let me know what youre thinking WRT to implementation. @stojce built most of the OG app... and may be around to help (but i dont want to speak on his behalf)

from skunkworks.

stojce avatar stojce commented on August 20, 2024

@owocki @eswarasai np, just mention me so I can get notification

from skunkworks.

eswarasai avatar eswarasai commented on August 20, 2024

@owocki: I'm yet to start on this issue. Will definitely update here as soon as I figure out a possible solution to implement this.

Definitely @stojce. I'll reach out to you in case I'm stuck or have any queries. Thanks.

from skunkworks.

eswarasai avatar eswarasai commented on August 20, 2024

@owocki @stojce -- I've been through the code and from my initial understanding below are my thoughts related to implementation along with few doubts that I have :

  1. Enable the upload mechanism to accept up to 10 images at once in batch
    -- Add ability to upload multiple images and display the preview thumbnails (should this be a slider or all the images displayed side by side?)
    -- Modify Wallpapers API to accept multiple file uploads and create them in a batch

  2. Size of ethereum logo field Title, author email, tags, will apply to all images in batch
    -- This will be handled in the batch creation of wallpapers

  3. Copy updates: Upload Wallpaper => Upload Wallpapers
    -- I'm guessing that this is a simple text change of the Header in the Upload Modal. Correct me if I'm wrong

  4. Rename Title to be 'Description', and have whatever the user inputs as description on the frontend populate into the 'title', 'author', and 'tags' field on the backend
    -- How can I auto-populate the 'title', 'author', and 'tags' fields based on the Description?

from skunkworks.

owocki avatar owocki commented on August 20, 2024

Enable the upload mechanism to accept up to 10 images at once in batch
-- Add ability to upload multiple images and display the preview thumbnails (should this be a slider or all the images displayed side by side?)
-- Modify Wallpapers API to accept multiple file uploads and create them in a batch

KO Comments: side by side is fine for the thumbnails. defer to @stojce on the API question. if we don't hear from him, perhaps you could assume you can just fire off the API requests in sequence after each other.

Size of ethereum logo field Title, author email, tags, will apply to all images in batch
-- This will be handled in the batch creation of wallpapers

KO Comments: what is the doubt here?

Copy updates: Upload Wallpaper => Upload Wallpapers
-- I'm guessing that this is a simple text change of the Header in the Upload Modal. Correct me if I'm wrong

KO Comments: seems right to me

Rename Title to be 'Description', and have whatever the user inputs as description on the frontend populate into the 'title', 'author', and 'tags' field on the backend
-- How can I auto-populate the 'title', 'author', and 'tags' fields based on the Description?

KO Comments: i believe youll need to modify the API request to use the one field for all of the API/DB backends

from skunkworks.

stojce avatar stojce commented on August 20, 2024

Upload API can be easily changed to accept 10 images. Currently is looking just for first one and that part of the API should be wrapped into loop to accept multiple images.

from skunkworks.

eswarasai avatar eswarasai commented on August 20, 2024

Thanks @owocki and @stojce for clarifying my queries and also for the suggestions.

@owocki -- I just have one question related to the Description field. I'll be creating the description field in the DB and will save whatever data is coming from the Frontend for this field. But where do we display this description and also how should I handle the migration of old data or should I leave it as it is?

from skunkworks.

owocki avatar owocki commented on August 20, 2024

please just migrate the 'title' field from the legacy images to the description field.

you can dispaly this field on the frontend where the 'title' is currently.

from skunkworks.

owocki avatar owocki commented on August 20, 2024

@eswarasai hows it going?

from skunkworks.

eswarasai avatar eswarasai commented on August 20, 2024

@owocki -- I'm currently working through the migration. I'm almost done with the changes. Will submit a PR soon.

from skunkworks.

gitcoinbot avatar gitcoinbot commented on August 20, 2024

The funding of 0.1 ETH (104.67 USD) attached to this issue has been approved & issued to @eswarasai.

from skunkworks.

vs77bb avatar vs77bb commented on August 20, 2024

@owocki Still shown in 'Work Submitted', should be 'Work Done'

from skunkworks.

mbeacom avatar mbeacom commented on August 20, 2024

I'm actively looking into this.

from skunkworks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.