The esp32_ad7190 from gism

esp32_ad7190's People

Contributors

Stargazers

Watchers

esp32_ad7190's Issues

Reading value even if timed out?

I think you are reading the value from the data register even if MOSI never goes low

src/AD7190.cpp

uint32_t AD7190::getDataRegisterAvg(uint8_t sampleNumber) {

  uint32_t samplesAverage = 0;
  for (uint8_t i = 0; i < sampleNumber; i++) {
    waitMisoGoLow();                                                  //  TODO: Check if this can be removed
    uint32_t v = getRegisterValue(AD7190_REG_DATA, 3);
    
    uint8_t channel = v & 0x7;   
    samplesAverage += (v >> 4);
  }
  
  samplesAverage = samplesAverage / sampleNumber;
  return samplesAverage ;

}

examples/AD7190_continuousReadMode/AD7190_ContinuousReadMode.ino

void loop() {

  timeOut = !ad7190->waitMisoGoLow();
  rawAd7190Data = ad7190->getDataRegisterAvg(3);

  if (timeOut)Serial.println("RDY time out");
  
  ...
  
}

Is this deliberate or a bug?

If you change the code to

while (p_ad7190->waitMisoGoLow()) {}
m_rawAd7190Data = p_ad7190->getDataRegisterAvg(3);

The the output rate goes from ~1-11kHz (depending on what is being logged to serial monitor, baud rate, rest of program etc.) to ~30Hz.

When just reading the data regardless of whether MISO has gone low, every few seconds the ADC reading is significantly wrong. I expect this is when the data is being read while the ADC is updating the register values

I expect to get the high frequency, the RDY pin needs to be configured as an interrupt which I will try next.

Recommend Projects