gillesgoetsch / acf-smart-button Goto Github PK

Currently returns same page as url attribute. Should return false to allow correct casing of button

Hi love the plugin.

I noticed you have added a composer.json file but I was just wondering if you have submitted it to packagist yet (https://packagist.org/) since I can't seem to install it through composer.

Getting an illegal offset warning coming from line 135-139 on acf-smart-button-v5.php

/* overwrite fields with empty values to avoid warning */
$field['value']['text'] = isset($field['value']['text']) ? $field['value']['text'] : null;
$field['value']['link'] = isset($field['value']['link']) ? $field['value']['link'] : null;
$field['value']['post_id'] = isset($field['value']['post_id']) ? $field['value']['post_id'] : null;
$field['value']['use_external'] = isset($field['value']['use_external']) ? $field['value']['use_external'] : null;

I'm able to publish the post/page even if the smart button field is set to be required and the field is left blank. Anyone else have this issue?

When I open a page or post in the editor with one or more smart buttons, I noticed that fields for internal links (post objects) are empty. This doesn't happen for external links. Text fields maintain values for both internal and external links. whenever I edit a page or post with smart buttons and save content, smart buttons on this page or post dissappear, because of the empty fields for internal links. Other act-smart-button is version 1.0.0, ACF is version 5.6.5, Wordpress 4.8.3 and PHP 7.0.

Edit: Empty fields for internal link only occur when a custom post type post is selected in the link field. It doesn't happen for posts or pages.

As the title says, would be great if the smart button plugin could choose between pages/posts and files for internal linking 👍

Hi,

Thanks for your plugin !
You do not update your version number during merges in master. Would it be possible to set up a versionning SEM system?

Best,

The internal field doesn't seem to render when it's set to conditional:

As we are changing the input checkbox via javascript on load, the browser always alerts before closing. This shouldn't be done client-side, rather server-side..

Any chance of a vanilla PHP example, rather than the abstracted Twig example of how to use it?

Please add a git tag for 1.0.0, so that we can pull that version down via composer. Thanks!

Hi Gilles,

I stumbled upon your plugin by chance and saw how you implemented a nice animated checkbox into your field. Is there any way that could be turned into a new ACF field that can be used instead of the True/False field in ACF? I'd love to see something like that, but haven't been able to make that work at all (probably of my lack of JS skills :-).

Currently there is no validation and a small layout glitch

hey!
When I've added plugin to theme $dir path is going to plugins directory :(

So, my solution is
$dir = str_replace(get_home_path() ,'/', dirname(__FILE__));

Can you check it?