giggsey / libphonenumber-for-php-lite Goto Github PK

I have a blocker for migrating to libphonenumber-for-php-lite, which is a requirement for ShortNumberInfo.

The metadata for these files in libphonenumber is ~500KB (in comparison, PhoneNumberMetadata is ~1.1MB), and I think I can reduce that by removing empty data from the metadata (as well as the normal short arrays).

My question to the community is: should I? It'll increase the download size of the 'lite' library (current zip is ~300KB, this will go up slightly).

The alternative is creating another library just for the ShortNumberInfo, and have it require the lite package. But that comes with management overhead for me.

Current behavior

• PhoneNumberUtil::getInstance() create a exception when it's use without PhoneNumberUtil::resetInstance(); before , the message exception is "exception": "[object] (Error(code: 0): Typed static property libphonenumber\\PhoneNumberUtil::$instance must not be accessed before initialization at /var/task/vendor/giggsey/libphonenumber-for-php-lite/src/PhoneNumberUtil.php:387)

• When I use PhoneNumberUtil::getInstance() function, I have a other message like that : PHP message: PHP Deprecated: Optional parameter $defaultRegionMetadata declared before required parameter $phoneNumber is implicitly treated as a required parameter in /var/task/vendor/giggsey/libphonenumber-for-php-lite/src/PhoneNumberUtil.php on line 1795

Excepted behavior

• PhoneNumberUtil::getInstance() must be use without PhoneNumberUtil::resetInstance() first time
• Parameter $defaultRegionMetadata should not be to have a default value

Would the metadata loading be quicker & smaller if we serialised or var_exported the object itself?

Test:

• speed
• max memory
• size of generated metadata