gideonkorir / jasiri Goto Github PK

Split current Jasiri nuget package into Jasiri and Jasiri.OpenTracing packages.

It would be useful to expose the following metrics from Jasiri:

1. Spans started
2. Spans finished
3. Spans sampled
4. Spans not sampled

Need to do more research/thinking on what other metrics would be useful

Really appreciate all of th work you've put into this driver - first one I've found that supported OpenTracing!

I did find one bug with it that makes it unusable for me in production, however

The code you use to automatically flow multiple spans together into parent / child relationships assumes that all of the asynchronous activity will flow from await / async relationships. I'm using Akka.NET actors which run on independent threads that are managed by the CLR threadpool, thus totally unrelated traces automatically get globbed together by your driver. AsyncLocal won't work in that scenario or any others where we're using things like sockets / independent thread management.

It'd be great if we had some way of preventing Jasiri from trying to guess that the currently "related" span is.

Add docs/wiki for the following:

1. How to change the default sampler (ConstSampler(true))
2. How to propagate context
3. Interop with OpenTracing