ghrik / sjpapi Goto Github PK

Słownik języka polskiego SJP (SJP.PL) - API do łatwego łapania słówek. ENG: API to easy get words from polish dictionary(SJP.PL)

Home Page: https://github.com/GHRik/SjpAPI

License: Apache License 2.0

Java 100.00%

dictionary slowniki jezyk-polski sjp

sjpapi's Introduction

Hi there 👋

I am glad to see you here! 😁

Name: Damian
Age: 27
City: Szczecin, Poland
Gender: Male
Contact: [email protected]

I am a Master of ICT and in near future i am going try my self with doing Ph.D 😉

Actually working as:

C++ Software Developer, Nokia(Localization: Remote)

Completed projects:

SjpAPI - My own API to get "words" from sjp.pl(Dictionary of polish:poland:)
Distributed face recognition using k8s - My Master diploma 🤓
Parking Sensor - My DIY project to improve my electric, raspberry pi knowledge

Currently working on:

ScrabbleHelper - My own android app:iphone: to menage your scrabble game. Check it out! 😍

Currently gaining knowledge in:

C++ - check my repository
OpenCV - in this repository i will commit some project using openCV
DeepLearning - in this repository i will start my journey of deep learning!

What am i looking for:

I am open for remote working
People to work with about ML, AI, vision etc. some fantasy people who like to go out for a beer 🍻
and play billard:8ball:
and wanna go siling:sailboat:

if you one of them write to me 🥳

sjpapi's People

Contributors

Stargazers

Watchers

Forkers

greenmarker banan314

sjpapi's Issues

Variant from JSON object havent polish letters

REPRODUCE:
Searching for:

równe

OUTPUT:

{"name":"równe","count":5,"canBeUsed[0]":true,"variant[0]":"r%C3%B3wne","meaning[0]":"gładka powierzchnia, równy teren" ...

EXPECT:

{"name":"równe","count":5,"canBeUsed[0]":true,"variant[0]":"równe","meaning[0]":"gładka powierzchnia, równy teren" ...

In this case : "r%C3%B3wne" -> "równe"

[CRITICAL]Change in HTML on "KOMENTARZE" section

SjpApi does not work cause of change in "KOMENTARZE" section:

    Process: com.example.PomocnaLiterka, PID: 27428
    java.lang.StringIndexOutOfBoundsException: String index out of range: -6390
        at java.lang.String.substring(String.java:2064)
        at com.sjp.StringUtils.substringBettwen(StringUtils.java:89)
        at com.sjp.CurlWrapper.getBettwenH1AndCommentSection(CurlWrapper.java:15)
        at com.sjp.CurlHelper.getOutputFromCurl(CurlHelper.java:21)
        at com.sjp.SjpAPI.getWord(SjpAPI.java:13)
        at com.example.PomocnaLiterka.ArbiterActivity.lambda$onCreate$1$com-example-PomocnaLiterka-ArbiterActivity(ArbiterActivity.java:69)
        at com.example.PomocnaLiterka.ArbiterActivity$$ExternalSyntheticLambda0.onClick(Unknown Source:8)
        at android.view.View.performClick(View.java:7450)
        at com.google.android.material.button.MaterialButton.performClick(MaterialButton.java:1194)
        at android.view.View.performClickInternal(View.java:7418)
        at android.view.View.access$3700(View.java:835)
        at android.view.View$PerformClick.run(View.java:28689)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7879)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1009)

Clean code

Comply with java folder convention (src/main/java, test/java), comply with Java Language Specification

fix clean code/sonarlint issues

fix code smells like unused exceptions etc.

Not enough searching words.

Will be better if word will be find exactly like on sjp.pl . It means with all varieties.

For example:

Now finding word works enough, but this issue should be resolve after next release

upgrade to JUnit 5

Output is not in json format

Any of getting word is not in json format

REPRODUCE:

sjpAPI.getWord("owoc");

OUTPUT:

{"name":"owoc"}{"canBeUsed":true}{"meaning":"1. występujący u roślin okrytozalążkowych wytwór zalążni słupka kwiatowego;\n2. rezultat działań, wynik, skutek;\n3. potocznie, zbiorowo: płody drzew oraz krzewów owocowych"}

Expected:

{"name":"owoc","canBeUsed":true,"meaning":"1. występujący u roślin okrytozalążkowych wytwór zalążni słupka kwiatowego;\n2. rezultat działań, wynik, skutek;\n3. potocznie, zbiorowo: płody drzew oraz krzewów owocowych"}

Fix README typos and formatting

Fix typos and make the formatting more readable in README.md

Typos like necesarry, viariant

And code formatting could be also more relevant like java, json etc.

Consider using Maven for quick project set up

Consider using Maven or Gradle for managing the dependencies and quick project set up.

Now we don't know what version of JUnit you used and the time to start using your code is unnecessarily prolonged.

Word without meaning

Sometimes on sjp.pl are there a words without meaning. It is problem , because regex used in SjpAPI is looking for meaning.

Reproduce:

Expect result:
Only print is "dopuszczalne" or "niedopuszczalne"

Fix CurlReaderTest

There are minor differences, it's better to use contains than equals

"meaning" field have unnecessary "special char"

Sometimes something like "&quot" existing in field "meaning"

Reproduce:

Log.i("Output",sjpApi.getWord("Twoja"));

Output:

{"name":"twoja"}{"canBeUsed":true}{"meaning":"potocznie: kobieta, która wraz z osobą, do której zwraca się mówiący, stanowi parę (np. małżeńską)"}{"canBeUsed":true}{"meaning":"zaimek dzierżawczy odpowiadający zaimkowi osobowemu &quot;ty&quot;"}

Expect result:

{"name":"twoja"}{"canBeUsed":true}{"meaning":"potocznie: kobieta, która wraz z osobą, do której zwraca się mówiący, stanowi parę (np. małżeńską)"}{"canBeUsed":true}{"meaning":"zaimek dzierżawczy odpowiadający zaimkowi osobowemu 'ty' "}

"special char" in meaning of word

Corelating to this issue: #1

Probably there is a lot of "special char" in sjp.pl.

The next i found is &nbsp , should be replace by "space".

Fix CurlValidatorTest#testIsHTTPNotFound test

Caused by 6fc686c#r129794322

Linking apache text library.

It is problem when i try to link SjpAPI.jar on other project.

REPRODUCED:

Make project and link only SjpApi.jar , try to run

String json = sjpApi.getWord("słowo");

RESULT:

2021-02-22 20:24:51.972 16857-16857/com.pomocnaliterka E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.pomocnaliterka, PID: 16857
    java.lang.NoClassDefFoundError: Failed resolution of: Lorg/apache/commons/lang3/StringUtils;
        at com.sjp.sjpapi.CurlWrapper.deleteHeadFromOutput(CurlWrapper.java:14)
        at com.sjp.sjpapi.CurlHelper.getOutputFromCurl(CurlHelper.java:19)
        at com.sjp.sjpapi.SjpAPI.getWord(SjpAPI.java:15)
        at com.pomocnaliterka.MainActivity.lambda$onCreate$0$MainActivity(MainActivity.java:31)
        at com.pomocnaliterka.-$$Lambda$MainActivity$VYDZTwWW-eBHh9aAkt_YK-rAlwc.onClick(Unknown Source:6)
        at android.view.View.performClick(View.java:7448)
        at com.google.android.material.button.MaterialButton.performClick(MaterialButton.java:1119)
        at android.view.View.performClickInternal(View.java:7425)
        at android.view.View.access$3600(View.java:810)
        at android.view.View$PerformClick.run(View.java:28305)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7656)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
     Caused by: java.lang.ClassNotFoundException: Didn't find class "org.apache.commons.lang3.StringUtils" on path: DexPathList[[zip file "/data/app/~~C1zb4zGlLCSyaZCa7KUhFQ==/com.pomocnaliterka-H0zEfadWfPSiVA5gEn69mg==/base.apk"],nativeLibraryDirectories=[/data/app/~~C1zb4zGlLCSyaZCa7KUhFQ==/com.pomocnaliterka-H0zEfadWfPSiVA5gEn69mg==/lib/x86, /system/lib, /system_ext/lib]]
        at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:207)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:379)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:312)
        at com.sjp.sjpapi.CurlWrapper.deleteHeadFromOutput(CurlWrapper.java:14) 
        at com.sjp.sjpapi.CurlHelper.getOutputFromCurl(CurlHelper.java:19) 
        at com.sjp.sjpapi.SjpAPI.getWord(SjpAPI.java:15) 
        at com.pomocnaliterka.MainActivity.lambda$onCreate$0$MainActivity(MainActivity.java:31) 
        at com.pomocnaliterka.-$$Lambda$MainActivity$VYDZTwWW-eBHh9aAkt_YK-rAlwc.onClick(Unknown Source:6) 
        at android.view.View.performClick(View.java:7448) 
        at com.google.android.material.button.MaterialButton.performClick(MaterialButton.java:1119) 
        at android.view.View.performClickInternal(View.java:7425) 
        at android.view.View.access$3600(View.java:810) 
        at android.view.View$PerformClick.run(View.java:28305) 
        at android.os.Handler.handleCallback(Handler.java:938) 
        at android.os.Handler.dispatchMessage(Handler.java:99) 
        at android.os.Looper.loop(Looper.java:223) 
        at android.app.ActivityThread.main(ActivityThread.java:7656) 
        at java.lang.reflect.Method.invoke(Native Method) 
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) 
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)