Random number generation about bitcoin HOT 2 CLOSED

Since we currently aren't identifying dandelion nodes correctly at the moment, in using the GetRand function, I set aside a function in net_processing.cpp called GetNextDandelionNode that all other code can call and until we have a better way of identifying nodes, I put a IsDandelion in CNode so that we don't have to modify every function as we add dandelion propagation to all the different ways in which transactions can be processed/relayed (through receiving them or the various forms of rpc calls). Just a thought to make it easier.

An issue with this is that some functions are already given a connman to call and others use a global g_connman. I don't know if there is really a different between the two or why some use one over the other but that might end up a potential problem if not addressed.

from bitcoin.

Fixed in 2098f3e

from bitcoin.