Dandelion relaying for RPC calls. about bitcoin HOT 5 OPEN

Correction, SendMessages should retain its sole purpose of sending out messages. The functions like sendrawtransaction that already handle checks should take care of ensuring the correct nodes are sent the new transaction. Additionally, rpc functionality needs to have access to Dandelion structures and locks.

from bitcoin.

Good point, let's merge srya-b/bitcoin-dandelion@621667e but with the new approach

from bitcoin.

Yes, I'm going to go through the rpc calls and do the new inplementation.

from bitcoin.

If we can include the namespace'd items and the new maps we've introduced like mapEmbargo in the net_processing header file, then we can copy the implementation in the rpc calls. However, there is a lot of stuff included in the anon namespace in net_processing.cpp and I don't know whether we want to expose all of those data structures to other parts of the code like rpc calls.

If that's the case maybe the best way would be just to create a new dandelion relaying function that can be called from rpc instead of doing the standard pnode->pushInventory(...).

from bitcoin.

Right, I wanted to hide as much as possible of those data structures since they need to be locked and maintained consistently. What I did was expose the RelayTransactionDandelion function (it's declared in net.h right now, although to be fair that's a little confusing since its implemented in net_processing.cpp

from bitcoin.