Account creation/confirm mnemonic flow issue about speckle-browser-extension HOT 22 CLOSED

@eswarasai you've been approved to start work.

from speckle-browser-extension.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 300.0 DAI (300.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $135,172.22 more funded OSS Work available on the Gitcoin Issue Explorer

from speckle-browser-extension.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 5 months, 3 weeks from now.
Please review their action plans below:

1) evgeniuz has applied to start work (Funders only: approve worker | reject worker).

Would like to try to work on this. Will implement both UI flows and tests for them.
2) eswarasai has been approved to start work.

Would love to tackle this and setup both the required flows as per description. Will test this for multiple browser support and ensure smooth user experience while on-boarding the user. Thanks!
3) mikegsus has applied to start work (Funders only: approve worker | reject worker).

Add a storage for save the password, for the time that users decides, also an auth guard for changes views to login immediately.

Just a question: user will select how many time password is saved or it will set by default?

Also add some conditions in the component for return the view and stop the regeneration of the mnemonic.
4) usulix has applied to start work (Funders only: approve worker | reject worker).

1. clone the project
2. run existing tests
3. create new tests to describe the desired feature changes
4. write typescript to implement desired feature changes
5. submit pull request
   The need to save a password temporarily seems interesting. I will come up with a secure way to do that.
   Please see my github, I am active in similar projects... just no work on Gitcoin as of yet.

Learn more on the Gitcoin Issue Details page.

from speckle-browser-extension.

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from speckle-browser-extension.

@ttaoS - Let me know if the below suggested flow sounds good to you before me diving into the dev:

1. I'll save the password in the LocalStore upon clicking next in the first step. Also, I'll add the current timestamp to the LocalStore and let the extension check for whether the password has expired or not which can be somewhere around between 24 - 48 hours. Let me know how long would you like the extension to keep the temporary password saved for until user successfully creates account.

Also once user proceeds to step 2 after entering the password, clicks next and moves to step 3 (confirming generated mnemonic) and closes the extension popup at this step, should we also keep track of generated mnemonic and display step 2 as user might wanna see the mnemonic before confirming it in the next step. Just want to avoid the re-generation of the mnemonic in this scenario. Let me know your thoughts.

2. I've tried this scenario and seems like the mnemonic isn't re-generated, it's always the same when I go and click the Create Account button and close the popup at step 2. But I've got the desired behaviour and might I suggest to add a button on the screen which says Skip Account Creation because it might confuse the user if he/she doesn't remember that the last action they were tying to do was creating a new account and stuck with having to create an account even though they might not want to.

Once I get a confirmation on the UI/UX, I'll open a WIP PR for the same. Thanks!

from speckle-browser-extension.

1. i would suggest store the temp pwd in extension background memory (the popup communicate with background via messages) rather than persisting it in browser local storage. We may also need to provide unmask password feature so that users can confirm their password before creating accounts.

2. Yes. Right now mnemonic won't be re-generated until it has been used to create an account successfully.

from speckle-browser-extension.

Also, we probably keep the timer to 5 mins (maybe with a visual timer or something) for the temp password. We should also apply timer on mnemonic re-generation which is more secure approach.

from speckle-browser-extension.

@ttaoS - Thanks for clarifying my queries. I'll implement the first task as described in the earlier comment with 5 mins timer. I have a quick question related to the timer for mnemonic re-generation as you've confirmed that we're not regenerating it until we've successfully created an account. So where and when should this be applied exactly? Thanks!

from speckle-browser-extension.

@eswarasai it will be re-generated after the timer elapses. So the user has to finish creating their account within the allotted time.

from speckle-browser-extension.

any help needed?

from speckle-browser-extension.

Cool, thanks for confirming the required user flows. Apologies for not being able to respond earlier. I'll pull up a WIP PR in the next couple of days :)

from speckle-browser-extension.

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from speckle-browser-extension.

@ttaoS @anjj123 - I've just opened up a WIP PR #108 for this issue. I've slightly modified the UI/UX of the 1st task to not take user directly to step 2 to generate mnemonic based on above discussion. Step 1 will be shown where the password field will be pre-emptively filled in case the user comes back to the extension before the said time interval of 5 minutes. I hope that's fine.

I'll update the PR to handle the 2nd task as well and keep you posted. Please do let me know if you have any feedback around the changes I've made so far. Thanks!

from speckle-browser-extension.

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from speckle-browser-extension.

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from speckle-browser-extension.

@eswarasai does that mean the user can also edit that pw field if they so wish? was there a functional reason you decided to return back to the pw screen?

from speckle-browser-extension.

@anjj123 -- Yep, users can edit the password if the initial account creation process hasn't been completed. The reason for doing is pointed out by @ttaoS in one of the comments above :

We may also need to provide unmask password feature so that users can confirm their password before creating accounts.

from speckle-browser-extension.

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from speckle-browser-extension.

@eswarasai Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

from speckle-browser-extension.

@anjj123 @ttaoS -- Have you guys had a chance to take a look at the PR #108?

from speckle-browser-extension.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 300.0 DAI (300.0 USD @ $1.0/DAI) has been submitted by:

1. @eswarasai

@Web3Foundation please take a look at the submitted work:

• PR by @eswarasai

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $133,222.00 more funded OSS Work available on the Gitcoin Issue Explorer

from speckle-browser-extension.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 300.0 SAI (300.0 USD @ $1.0/SAI) attached to this issue has been approved & issued to @eswarasai.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $72,678.09 more funded OSS Work available on the Gitcoin Issue Explorer

from speckle-browser-extension.