getporter / aws-mixin Goto Github PK

View Code? Open in Web Editor NEW

2.0 4.0 7.0 2.57 MB

Porter mixin for the AWS CLI

Home Page: https://getporter.org/mixins/aws

License: Apache License 2.0

Go 100.00%

porter aws amazon mixin

aws-mixin's People

Stargazers

Watchers

Forkers

vdice carolynvs mchorfa eudaimos clareliguori vinozzz schristoff

aws-mixin's Issues

Document suppress-output functionality

Ref #16 for functionality and getporter/porter#963 for docs

Repeated flags working as intended?

Describe the bug

When using the aws mixin multiple flags don't seem to work correctly. The action I am trying to perform is create an ec2 instance with multiple security groups. This could be related to #11 ?

To Reproduce

Steps to reproduce the behavior:

There are several scenarios here:

1. Multiple items added as a YAML sequence

install:
  - aws:
      description: "Provision VM"
      service: ec2
      operation: run-instances
      flags:
        image-id: ami-xxxxxxxxxxxxxxxxx
        instance-type: t2.micro
        region: eu-west-1
        subnet-id: subnet-xxxxxx
        security-group-ids: 
        - sg-xxxxxxxx
        - sg-xxxxxxxx

2. Multiple items added as a formatted string

Replace the SG sequence with:

security-group-ids: "\"sg-xxxxxxxx\" \"sg-xxxxxxxx\""

3. Multiple items added as a 'simple' string

Replace the SG sequence with:

security-group-ids: "sg-xxxxxxxx sg-xxxxxxxx"

Expected behavior

That you can add multiple items, for instance multiple SGs to a yaml config and have them all attach. Some of the above options produce the correct output in the debug console (running install with the --debug flag) but the commands don't seem to work.

Porter Command and Output

porter install --cred aws_nonprod_creds --debug

For the different scenarios:

1. Multiple items added as a YAML sequence:

This adds multiple --security-group-ids to the aws ec2 command:

aws ec2 run-instances --image-id ami-xxxxxxxxxxxxxxxxx --instance-type t2.micro --output json --region eu-west-1 --security-group-ids sg-xxxxxxxx --security-group-ids sg-xxxxxxxx --subnet-id subnet-xxxxxxxx

Only the last is chosen and applied - I think this is in the AWS docs somewhere, but can't remember where (sorry!)

2. Multiple items added as a formatted string

This would seem to produce a correctly formatted output (i.e. if you run something like this outside of porter then it will run and create you an instance as intended)

aws ec2 run-instances --image-id ami-xxxxxxxxxxxxxxxxx --instance-type t2.micro --output json --region eu-west-1 --security-group-ids "sg-xxxxxxxx" "sg-xxxxxxxx" --subnet-id subnet-xxxxxxxx

But the error that you get is: The parameter groupName cannot be used with the parameter subnet. To me this implies it is trying to do something with the default subnet or an SG that is not in the same subnet - however, I have checked on my example and it works outside of the bundle so this is not the case.

3. Multiple items added as a 'simple' string

This would also seem to produce a correctly formatted output - same as no.2 just without quotes around the SGs:

aws ec2 run-instances --image-id ami-xxxxxxxxxxxxxxxxx --instance-type t2.micro --output json --region eu-west-1 --security-group-ids sg-xxxxxxxx sg-xxxxxxxx --subnet-id subnet-xxxxxxxx

The error is the same as for no.2: The parameter groupName cannot be used with the parameter subnet

Version

porter v0.23.0-beta.1 (9c49056)
aws v0.2.1-beta.1 (can't seem to find version hash)

Add build badge

Add build badge to top of README.

Pipeline is: https://dev.azure.com/getporter/porter/_build?definitionId=5

Issue where multiple --parameter-overrides are not received by AWS CLI when called from porter

Hi, I believe this to be some interaction between porter and the porter-aws mixin.

Problem:
Porter calling the "aws cloudformation deploy" command with the flag --parameter-overrides Key1=Value1 Key2=Value2 --someOtherFlag, appears to only pass in the first Key1=Value1 .

However, if I launch a container of the porter image, I can manually run the cloudformation command copied and pasted and it will run fine.

Here is the output of the error from Porter's debug output of the step. If I swap the 2 parameters around, it will toggle the error of which key is missing and only take the first.

Upsert stack
DEBUG mixin:    aws
DEBUG mixinDir: /cnab/app/mixins/aws
DEBUG file:
DEBUG stdin:
install:
- aws:
    description: Upsert stack
    flags:
      no-fail-on-empty-changeset: null
      parameter-overrides: Key1=Value1 Key2=Value2
      region: eu-west-1
      stack-name: stack-x
      template-file: CFtemplates/Template.template
    operation: deploy
    service: cloudformation

/cnab/app/mixins/aws/aws-runtime install --debug
/usr/local/bin/aws aws cloudformation deploy --no-fail-on-empty-changeset --output json --parameter-overrides Key1=Value1 Key2=Value2 --region eu-west-1 --stack-x --template-file CFtemplates/Template.template
DEBUG Parsed Input:
&aws.Action{Steps:[]aws.Steps{aws.Steps{Step:aws.Step{Description:"Upsert stack", Service:"cloudformation", Operation:"deploy", Arguments:[]string(nil), Flags:builder.Flags{builder.Flag{Name:"no-fail-on-empty-changeset", Values:[]string(nil)}, builder.Flag{Name:"parameter-overrides", Values:[]string{"Key1=Value1 Key2=Value2"}}, builder.Flag{Name:"region", Values:[]string{"eu-west-1"}}, builder.Flag{Name:"stack-name", Values:[]string{"stack-x"}}, builder.Flag{Name:"template-file", Values:[]string{"CFtemplates/Template.template"}}}, Outputs:[]aws.Output(nil)}}}}

An error occurred (ValidationError) when calling the CreateChangeSet operation: Parameters: [Key2] must have values
err: error running command /usr/local/bin/aws aws cloudformation deploy --no-fail-on-empty-changeset --output json --parameter-overrides Key1=Value1 Key2=Value2 --region eu-west-1 --stack-name stack-x --template-file CFtemplates/Template.template: exit status 255
Error: error running command /usr/local/bin/aws aws cloudformation deploy --no-fail-on-empty-changeset --output json --parameter-overrides Key1=Value1 Key2=Value2 --region eu-west-1 --stack-name stack-x --template-file CFtemplates/Template.template: exit status 255
Error: mixin execution failed: exit status 1
Resolved instance-store plugin to instance-store.porter.filesystem
C:\Users\x\.porter\porter plugin run instance-store.porter.filesystem
Error: 1 error occurred:
        * failed to install the bundle: container exit code: 1, message: <nil>

getporter / aws-mixin Goto Github PK

aws-mixin's People

Stargazers

Watchers

Forkers

aws-mixin's Issues

Describe the bug

To Reproduce

1. Multiple items added as a YAML sequence

2. Multiple items added as a formatted string

3. Multiple items added as a 'simple' string

Expected behavior

Porter Command and Output

1. Multiple items added as a YAML sequence:

2. Multiple items added as a formatted string

3. Multiple items added as a 'simple' string

Version

Recommend Projects

Recommend Topics

Recommend Org