[v4] Panel breaks on large breakpoints when site is proxied and minified by Cloudflare about kirby HOT 16 CLOSED

In the meantime, you can bypass CF auto-minify for the Panel with a page rule.

from kirby.

Ok, I gave it a try and it doesn't take too much work to fix this on our end. @distantnative @afbora @lukasbestle you should really double-check my PR. Maybe you can spot any trapdoors that I might have missed.

I really don't want to start working on such custom work-arounds for hosting providers. But I think this could actually be seen as a more clear distinction between minified and unminified files for us as well. That's why I think we could argue that this is also an enhancement for us.

from kirby.

Final semicolon in a set of statements is optional, so that shouldn't be an issue.
What does the broken CSS look like? What rules actually break?

from kirby.

looks like a typo. That's in the proxied file so I guess there's something preceding that.

from kirby.

@hotdoy can you please check if the space between span and var(--span) is really missing in the compressed file? If so, I'd think this is a Cloudflare bug then.

from kirby.

Really seems to be this set of rules.

@container (min-width: 50rem) {
    .k-grid {
        grid-template-columns: repeat(var(--columns),1fr)
    }

    .k-grid>* {
        grid-column: span var(--span)
    }
}

I'll try it out on another site just by itself see how cloudflare deals with it and escalate to them is it really is a bug with CF.

from kirby.

https://k4bug.calotte.dev/
Looks like a CF minifier bug. I'll be damned.

By the time people ship K4 to production, there is a high chance this will come back one way or another.
I'll try and report to CF in the meantime.

from kirby.

https://community.cloudflare.com/t/cf-css-minifier-messes-up-one-specific-line/535654

from kirby.

Seems like Cloudflare isn't interested in addressing it at https://community.cloudflare.com/t/cf-css-minifier-messes-up-one-specific-line/535654 :(

from kirby.

Yep. Kinda sucks. I could maybe open up a ticket with their support. Or, if we knew what algo they are using to minify, there might be a way to go around the issue. For now I'll keep my CF Rule.

from kirby.

I'm afraid we can't really do anything in Kirby to prevent this, right? Should we maybe add it to https://getkirby.com/docs/guide/troubleshooting/panel with a workaround?

from kirby.

Per CloudFlare docs, any file with .min in its name will not be re-minified. I know it is wrong to make decisions like this based on a vendor but that's one way.

from kirby.

That could indeed be a solution. .min is at least not wrong, so it wouldn't be a hack. Not re-minifying the files at all would also reduce the processing and in theory increase performance a little bit.

We would need to test if we can update our Vite/Rollup config without breaking anything else.

from kirby.

I honestly wonder how far this can be considered a standard (.min in the filename) or how much this is just a rather ignorant assumption of Cloudflare. I find it highly disappointing that they don't even comment on the issue and just close it. It kind of kills the mood to now spend extra time on such a custom fix just for them. On the other hand, I really don't want to leave our users hanging with that. I assume that there will be quite a few who use Cloudflare.

from kirby.

The post was made on the community forum since I'm not a paying customer.
It might have been different if we had an Enterprise customer in our ranks.

from kirby.

@hotdoy that might be true.

from kirby.