Code Monkey home page Code Monkey logo

Comments (7)

benphelps avatar benphelps commented on May 22, 2024 1

Hey, thanks for checking out my project :)

I agree, this is something that really would be needed for any use case outside of an internal network. I have a few ideas on what could be done but you're right, it would take a bit of reworking.

It might be valid that all requests ultimately end up passing through the backend proxy.

from homepage.

benphelps avatar benphelps commented on May 22, 2024 1

Alright.... This was a big one.

I've fully refactored the entire widget system to pass all API calls through the backend, using mostly reusable API handlers, along with a few specific ones for the special cases. No secrets are ever sent to the frontend now, and everything is handled in the services widget proxy endpoint.

I've locally tested every widget, so I'm quite sure everything should still function in the exact same way with no changes on your side.

from homepage.

benphelps avatar benphelps commented on May 22, 2024 1

Nope, it should all be proxied now. Just waiting a bit for some other users to test it out to confirm everything is good.

from homepage.

benphelps avatar benphelps commented on May 22, 2024

I kept the API requests on the frontend purely for performance, and since I personally intended to run this privately, any proxy functionality that currently exists is to bypass CORS restrictions only.

from homepage.

jackblk avatar jackblk commented on May 22, 2024

Great work @benphelps, let me try it out on my setup :).

Is there anything else we need to implement to close the ticket?

from homepage.

jackblk avatar jackblk commented on May 22, 2024

Looking good! I have tested my services and they are working nicely so far (except for Openweathermap, it's still leaking).

I'll close this ticket as implemented!

from homepage.

github-actions avatar github-actions commented on May 22, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns.

from homepage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.