Code Monkey home page Code Monkey logo

Comments (10)

shamoon avatar shamoon commented on May 29, 2024

Im not exactly clear what youre reporting here. This does work.

               fields: ["uptime", "wan"]
Screenshot 2024-01-27 at 3 14 21 PM
fields: ["uptime", "wan", "lan_users"]
Screenshot 2024-01-27 at 3 15 12 PM

from homepage.

JeffRandall avatar JeffRandall commented on May 29, 2024

The concern is the method of limiting the displayed fields by limiting the <Block> </> returned and does not set a default widget.fields -- this prevents the use of widget.fields to reorder the fields that I have a Discussion at #2764 about.

from homepage.

shamoon avatar shamoon commented on May 29, 2024

We can cross that bridge if we get there...

from homepage.

JeffRandall avatar JeffRandall commented on May 29, 2024

At bare minimum, the documentation is incorrect and should be updated to properly list the supported fields.

from homepage.

JeffRandall avatar JeffRandall commented on May 29, 2024

Additionally, because I do not have a switch or gateway product in my installation, it is broken for my install and installs like mine. I cannot get the lan field to display under any circumstances without installing new hardware. This is counter-intuitive to users.

from homepage.

JeffRandall avatar JeffRandall commented on May 29, 2024

Nor does uptime display without a gateway installed (from looking at the code and JSON).

from homepage.

shamoon avatar shamoon commented on May 29, 2024

Thats a different issue. If you'd like to FR using something else for uptime that'd be fine. I dont think anyone has raised that issue (and it's been this way for a while).

And lan should depend on lan from the unifi API:

[wan, lan, wlan].forEach((s) => {
s.up = s.status === "ok"; // eslint-disable-line no-param-reassign
s.show = s.status !== "unknown"; // eslint-disable-line no-param-reassign
});

from homepage.

JeffRandall avatar JeffRandall commented on May 29, 2024

{"meta":{"rc":"ok"},"data":[{"anonymous_id":"74dcedf9-7bee-4aee-b443-87e28e0629bc","name":"default","_id":"60b6ba2e8aa73f5e8e661f5c","attr_no_delete":true,"attr_hidden_id":"default","desc":"Default","health":[{"subsystem":"wlan","status":"unknown","num_ap":0,"num_adopted":0,"num_disabled":0,"num_disconnected":0,"num_pending":0},{"subsystem":"wan","num_gw":0,"num_adopted":0,"num_disconnected":0,"num_pending":0,"status":"unknown"},{"subsystem":"www","status":"unknown"},{"subsystem":"lan","status":"unknown","num_sw":0,"num_adopted":0,"num_disconnected":0,"num_pending":0},{"subsystem":"vpn","status":"unknown"}],"num_new_alarms":0},{"anonymous_id":"83bec07f-1f28-49cc-a7fe-a40d3d661630","name":"ozey8xnz","_id":"60b6c98d8aa73f5e8e661f8a","desc":"Home","health":[{"subsystem":"wlan","num_user":15,"num_guest":0,"num_iot":0,"tx_bytes-r":95629,"rx_bytes-r":6321,"status":"ok","num_ap":2,"num_adopted":3,"num_disabled":1,"num_disconnected":0,"num_pending":0},{"subsystem":"wan","num_gw":0,"num_adopted":0,"num_disconnected":0,"num_pending":0,"status":"unknown"},{"subsystem":"www","status":"unknown"},{"subsystem":"lan","status":"unknown","num_sw":0,"num_adopted":0,"num_disconnected":0,"num_pending":0},{"subsystem":"vpn","status":"unknown"}],"num_new_alarms":0},{"anonymous_id":"4675a41d-5053-4e9d-bcbf-d6f8afdb38d3","name":"o7urfc85","_id":"641be96c8aa73f02f25f3e38","desc":"Disabled","health":[{"subsystem":"wlan","status":"unknown","num_ap":0,"num_adopted":0,"num_disabled":0,"num_disconnected":0,"num_pending":0},{"subsystem":"wan","num_gw":0,"num_adopted":1,"num_disconnected":1,"num_pending":0,"status":"error","gw_mac":"b4:fb:e4:d3:fe:d3","gw_name":null,"gw_system-stats":null,"gw_version":"4.4.56.5449062"},{"subsystem":"www","status":"error","gw_mac":"b4:fb:e4:d3:fe:d3"},{"subsystem":"lan","lan_ip":null,"status":"error","num_user":0,"num_guest":0,"num_iot":0,"tx_bytes-r":0,"rx_bytes-r":0,"num_sw":0,"num_adopted":0,"num_disconnected":0,"num_pending":0},{"subsystem":"vpn","status":"unknown"}],"num_new_alarms":0}]}

With my local setup, I have no lan devices -- but as a user, if I try and configure lan I would expect to see an empty field, not have it refuse to display at all.

from homepage.

shamoon avatar shamoon commented on May 29, 2024

Yea I can see how that’s not obvious but I already added a commit adding the fields you correctly noted are missing and a note about this. I added you as author of that commit so you get ‘credit’ eg from the PR that you opened

from homepage.

github-actions avatar github-actions commented on May 29, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

from homepage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.