gerich-home / kopilua Goto Github PK

Hi,

The problem is at the end of tools/Printf.c, where just after padding the field with '0', the code pads it again. My fix was to take out the final padding:

if ( IsPositive( Value, true ) )
    w = ( PositiveSign ? "+" : ( PositiveSpace ? " " : String.Empty))  + w;

and then we pass that lua-TestMore test.

The handling of lua_str2number() errors is a bit of a hack job at the moment. If the number being converted is outside the allowable range then the function is supposed to return either positive or negative infinity. The current code will return the correct value in most non-pathological cases but it needs additional work to make it more robust.

When error happens in Lua code Environment.Exit(EXIT_FAILURE); is called in ldo.cs.

Throwing exception is better, I think.

See trydecpoint in llex.cs

Many function returns int (0 or 1), when it can be bool. In some parts of code bool is returned.

Memory allocation and tracking has not been properly implemented with user data objects so the behaviour of the garbage collector won't be 100% identical to the C version when user data objects are in use. This is currently high on the list of things to be fixed.

The strftime() function has not yet been ported, so os_date() currently has an incomplete implementation.