Crash when used inside Directory Opus about rom-properties HOT 5 CLOSED

Works, no crashes. Weird behaviour with some Gameboy games that show no thumbnails although they are there, need to investigate later.

from rom-properties.

Managed to reproduce this just by using Directory Opus with rom-properties installed, without DirMaster or PowerToys. Will look into this.

EDIT: It's crashing when the properties page calls DefSubclassProc. Directory Opus is doing something weird with regards to subclassing...

EDIT 2: ...because the function in question, RP_ShellPropSheetExt_Private::SubtabDlgProc(), is a regular dialog procedure. It is not a subclass procedure. I have no idea what I was doing here. It should be calling DefDlgProc. Apparently, with regular Windows Explorer, this didn't cause a problem, but I'm guessing Directory Opus installs its own subclasses, so calling DefSubclassProc screws everything up.

Will post a test build later today.

EDIT 3: There seems to be a background color issue in Light Mode on Windows 7, and the ListViews aren't showing any text. Need to figure out what's going on there... This seems to have disappeared...

EDIT 4: The dialog procedure should simply return FALSE, without calling DefDlgProc. Was thinking of a standard window procedure, which does have to call DefWindowProc if a message isn't processed.

from rom-properties.

@Kugelblitz360 Please test these DLLs once they're built: (you'll need to manually unregister the current version, restart Explorer and/or Directory Opus, then register the new version)

https://ci.appveyor.com/project/GerbilSoft/rom-properties/builds/49328741/job/qtuaw37wc2alnwsi

from rom-properties.

Would love to test but can't see the binaries.

from rom-properties.

https://ci.appveyor.com/api/buildjobs/qtuaw37wc2alnwsi/artifacts/rom-properties_2.3%2B-win64.zip

Probably should switch to GitHub CI at some point for better integration.

from rom-properties.