Windows: Add UTF-16 filename functions to handle filenames with unpaired UTF-16 surrogate characters about rom-properties HOT 2 CLOSED

Commit a87c21e reworked RP_ExtractIcon and RP_ExtractImage to store the filename as an OLECHAR string, and RP_ShellPropSheetExt to store the filename as a TCHAR string. (LPOLESTR, LPTSTR)

Changing the underlying RpFile and/or RomDataFactory classes to provide UTF-16 overloads will require adding functions to romdata-3.dll, which may be considered a backwards-compatible change. On Linux, this would result in an SOVERSION 3.1 bump, but since this only affects the Windows version, there won't be any version bump. (Older versions of rom-properties that expect v3 will work with the newer v3 DLL, but newer versions won't work with the older v3 DLL.)

from rom-properties.

Instead of using WTF-8 conversions, I added UTF-16 overloads for the "important" functions. This allows UTF-16 filenames to be used directly with no conversion.

TODO: rpcli still uses UTF-8 filenames, so broken UTF-16 filenames can't be used there. However, the Windows command line will likely have issues with broken UTF-16 filenames anyway.

The following now support UTF-16:

• RpFile
• RomData (storing the UTF-16 filename for RomOps purposes)
• RomDataFactory
• various functions in FileSystem

The Windows COM classes now use RpFile's UTF-16 constructor.

NOTE: The UTF-16 functions are only available on Windows. Unix systems are still UTF-8 only. Qt/KDE doesn't have the unpaired surrogate issue because the native filesystem uses UTF-8, so Qt has to convert to/from UTF-16 anyway.

from rom-properties.