https://www.thoughtco.com/pythons-string-templates-2813675

When exiting a server transport in Python 3.7, the transport does not inform active clients of shutdown and cancel their active read/write handlers

freedm/transport/server/base.py:135: RuntimeWarning: coroutine 'wait' was never awaited

When the freedm package is used as library it would be good if we throw a freedm related exception class with its own basic error handling and more specific meaning instead of general Python exceptions

This context manager should write to a temporary file and only if this works without an error, then we can replace the target file by the temporary file. This way we can assure we do never leave corrupted files.

See examplese here:

https://gist.github.com/bbengfort/17de016d6a51ce487a0f
or
https://github.com/vaultit/qvarn-planb/blob/notifications/Makefile

One possibility is to use JSON-RPC (https://de.wikipedia.org/wiki/JSON-RPC) for for client-node and node-node communication. We can also use JSON-SCHEMA to validate RPC calls

If we need to iterate only once, it is better to use a generator expression instead of a normal list comprehension!

#Generator expression
(x*2 for x in range(256))

#List comprehension
[x*2 for x in range(256)]

By using list(generator_expr) we would get the same result when needed.

Check the code where we use comprehensions and replace these when possible (https://medium.freecodecamp.org/python-list-comprehensions-vs-generator-expressions-cef70ccb49db). Also look at Async comprehensions introduced with python 3.6
https://www.blog.pythonlibrary.org/2017/02/14/whats-new-in-python-asynchronous-comprehensions-generators/

Tasks

• See where we can use Data Classes (https://docs.python.org/3.7/whatsnew/3.7.html#whatsnew37-pep557)
• Typing now got additional support y PEP 560 (https://docs.python.org/3.7/whatsnew/3.7.html#whatsnew37-pep560)
• Introduction of "Postponed Evaluation of Annotations" should render the creation of TypeVars unnecessary (https://docs.python.org/3.7/whatsnew/3.7.html#whatsnew37-pep563). See for instance server/client base classes
  *Argparse has a new parse_intermixed_args() method (https://docs.python.org/3.7/library/argparse.html#argparse.ArgumentParser.parse_intermixed_args)
• Adopt to changes and recommendations in asyncio (https://docs.python.org/3.7/whatsnew/3.7.html#whatsnew37-asyncio)
• Change for instance: ensure_future -> create_task?
• The new StreamWriter.wait_closed() coroutine method allows waiting until the stream writer is closed.
• The asyncio.Task.current_task() and asyncio.Task.all_tasks() methods have been deprecated.
• ProcessPoolExecutor and ThreadPoolExecutor now support the new initializer and initargs constructor arguments.
• The ProcessPoolExecutor can now take the multiprocessing context via the new mp_context argument.
• Enum: The Enum learned the new ignore class property, which allows listing the names of properties which should not become enum members.
• os.scandir() gained support for file descriptors
• Sockets
  • The new socket.close() function closes the passed socket file descriptor. This function should be used instead of os.close() for better compatibility across platforms
  • Sockets now auto-detect family, type and protocol from file descriptor by default
• SSL: The ssl module now uses OpenSSL’s builtin API instead of match_hostname() to check a host name or an IP address. Values are validated during TLS handshake. Any certificate validation error including failing the host name check now raises SSLCertVerificationError and aborts the handshake with a proper TLS Alert message. The new exception contains additional information. Host name validation can be customized with SSLContext.host_flags

#Todo

• Try to implement first missing changes of #1
• Check if tests work afterwards

https://medium.freecodecamp.org/how-to-secure-your-websocket-connections-d0be0996c556

• Ratelimit
• Authentication
• Logging
• Blocking
• ...

Let the project be checked by the https://pyup.io/ service to discover vulnerabilities in Python packages

Tasks

• Change normal strings to formatted literals

• Annotate functions and variables with type hints

• Introduce pathlib instead of string pathes

• Check if we can make use of asynchronous generators/comprehensions

#Todo

• Correct the store error (path)
• Check if tests work afterwards

Should we turn certain base classes (for now only the transport util classes) into ABC?
See: https://docs.python.org/3/library/abc.html
With the @AbstractMethod decorator we can clearly outline required template functions and properties in sub classes

Should be named package defaults, and not globals. We don't want to use globals or even name it like this

To avoid exceeding memory, we should read large messages or file uploads in a tempfile.SpooledTemporaryFile, that can get written on disk after a certain threshold.
See https://docs.python.org/3/library/tempfile.html#tempfile.SpooledTemporaryFile

The best might be to use SSL or SSH to protect the clear text communication