Code Monkey home page Code Monkey logo

create-diesel-generators's People

Contributors

asseygithub avatar catchmons avatar dreamer-40 avatar george8188625 avatar jonasfranke avatar merloss avatar u7f8au7fbd avatar yarden-zamir avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

create-diesel-generators's Issues

[Bug?] Running engines without silencers spams concurrent sounds (and can lag with Sound Physics)

(MC Forge 1.18.2, Create 0.5.1c, C:DG 1.1d)

When an engine is active without a silencer, it rapidly plays a large amount of sounds at once (~40 per large engine, ~10 per small engine), stopping at around 200 concurrent sounds no matter how many are placed.

(Ignore ambient sounds)

deez-el_1
deez-el_2

On its own, this doesn't affect the framerate at all, though having this many sounds is still a problem. It may start preventing or cancelling out other sounds in a place that already has lots of audible concurrent sounds to begin with. This is the primary issue if you're not using Sound Physics or similar.

With a mod like Sound Physics Remastered, rapidly-spawned sounds like this (to this degree) can also severely impact the framerate. It gets worse the more unsilenced engines you power. The impact seems to kinda depend on how the sounds line up (build then power, build off powered engine, rejoin, etc).

In the above screenshots, I was using a modpack with ~250 mods, including Sound Physics Remastered and Dynamic Surroundings Resurrected (with the sound physics settings disabled). The above setup could drop the framerate anywhere between <30FPS and ~3FPS, depending on how the sounds line up.
I tested it in a more barebones modpack with only C:DG, Create, the sound mods, and a few essentials, and got basically the same issues. The framerate drops with sound physics weren't nearly as bad ("average" framerate was still in the hundreds), but it was still stuttering every few frames.

deez-el_3
deez-el_4

These issues could be solved by replacing the spammed steam engine sound with a new "engine audio loop" sound, particularly one that isn't so short. This would already be a nice QoL thing to have in the first place, but now it's also a significant optimization improvement.

[1.19.2] Pondering crashes client

I was looking at a ponder scene from item Diesel Engine and my client crashed.

Forge 1.19.2
createdieselgenerators-1.19.2-1.2f

java.lang.NullPointerException: Cannot invoke "com.jesz.createdieselgenerators.other.CDGFuelType.getGeneratedNormal()" because the return value of "com.jesz.createdieselgenerators.other.FuelTypeManager.getType(net.minecraft.world.level.material.Fluid)" is null

crash-2023-12-27_13.38.05-client.txt

mixin has no refmap

{ "required": true, "minVersion": "0.8", "priority": 1177, "package": "com.jesz.createdieselgenerators.mixins", "refmap": "mixins.createdieselgenerators.refmap.json", "compatibilityLevel": "JAVA_17", "mixins": [ "EntityMixin", "MountedFluidStorageMixin" ], "injectors": { "defaultRequire": 1 } }

`buildscript{
repositories {

    maven { url = 'https://maven.minecraftforge.net/' }
    maven {
        name = 'sponge'
        url = 'https://repo.spongepowered.org/maven'
    }

    mavenCentral()
}
dependencies {
    classpath 'org.spongepowered:mixingradle:0.7.+'
}

}

plugins {
id 'eclipse'
id 'maven-publish'
id 'net.minecraftforge.gradle' version '[6.0,6.2)'
//id 'org.spongepowered.mixin' version '0.7.+'

}

apply plugin: 'org.spongepowered.mixin'

version = '1.20.1-1.2f'
group = 'com.jesz.createdieselgenerators' // http://maven.apache.org/guides/mini/guide-naming-conventions.html
archivesBaseName = 'createdieselgenerators'

// Mojang ships Java 17 to end users in 1.18+, so your mod should target Java 17.
java.toolchain.languageVersion = JavaLanguageVersion.of(17)

println "Java: ${System.getProperty 'java.version'}, JVM: ${System.getProperty 'java.vm.version'} (${System.getProperty 'java.vendor'}), Arch: ${System.getProperty 'os.arch'}"
minecraft {
// The mappings can be changed at any time and must be in the following format.
// Channel: Version:
// official MCVersion Official field/method names from Mojang mapping files
// parchment YYYY.MM.DD-MCVersion Open community-sourced parameter names and javadocs layered on top of official
//
// You must be aware of the Mojang license when using the 'official' or 'parchment' mappings.
// See more information here: https://github.com/MinecraftForge/MCPConfig/blob/master/Mojang.md
//
// Parchment is an unofficial project maintained by ParchmentMC, separate from MinecraftForge
// Additional setup is needed to use their mappings: https://github.com/ParchmentMC/Parchment/wiki/Getting-Started
//
// Use non-default mappings at your own risk. They may not always work.
// Simply re-run your setup task after changing the mappings to update your workspace.
mappings channel: 'official', version: '1.20.1'

// accessTransformer = file('src/main/resources/META-INF/accesstransformer.cfg') // Currently, this location cannot be changed from the default.

// Default run configurations.
// These can be tweaked, removed, or duplicated as needed.
runs {
    client {
        workingDirectory project.file('run')

        // Recommended logging data for a userdev environment
        // The markers can be added/remove as needed separated by commas.
        // "SCAN": For mods scan.
        // "REGISTRIES": For firing of registry events.
        // "REGISTRYDUMP": For getting the contents of all registries.
        property 'forge.logging.markers', 'REGISTRIES'

        // Recommended logging level for the console
        // You can set various levels here.
        // Please read: https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels
        property 'forge.logging.console.level', 'debug'

        // Comma-separated list of namespaces to load gametests from. Empty = all namespaces.
        property 'forge.enabledGameTestNamespaces', 'createdieselgenerators'

        arg '-mixin.config=createdieselgenerators.mixins.json'

        mods {
            createdieselgenerators {
                source sourceSets.main
            }
        }
    }

    server {
        workingDirectory project.file('run')

        property 'forge.logging.markers', 'REGISTRIES'

        property 'forge.logging.console.level', 'debug'

        property 'forge.enabledGameTestNamespaces', 'createdieselgenerators'

        arg '-mixin.config=createdieselgenerators.mixins.json'

        mods {
            createdieselgenerators {
                source sourceSets.main
            }
        }
    }

    // This run config launches GameTestServer and runs all registered gametests, then exits.
    // By default, the server will crash when no gametests are provided.
    // The gametest system is also enabled by default for other run configs under the /test command.
    gameTestServer {
        workingDirectory project.file('run')

        property 'forge.logging.markers', 'REGISTRIES'

        property 'forge.logging.console.level', 'debug'

        property 'forge.enabledGameTestNamespaces', 'createdieselgenerators'

        arg '-mixin.config=createdieselgenerators.mixins.json'

        mods {
            createdieselgenerators {
                source sourceSets.main
            }
        }
    }

    data {
        workingDirectory project.file('run')

        arg '-mixin.config=createdieselgenerators.mixins.json'

        property 'forge.logging.markers', 'REGISTRIES'

        property 'forge.logging.console.level', 'debug'

        // Specify the modid for data generation, where to output the resulting resource, and where to look for existing resources.
        args '--mod', 'createdieselgenerators', '--all', '--output', file('src/generated/resources/'), '--existing', file('src/main/resources/')

        mods {
            createdieselgenerators {
                source sourceSets.main
            }
        }
    }
}

}

// Include resources generated by data generators.
sourceSets.main.resources { srcDir 'src/generated/resources' }

repositories {
// Put repositories for dependencies here
// ForgeGradle automatically adds the Forge maven and Maven Central for you

// If you have mod jar dependencies in ./libs, you can declare them as a repository like so:
// flatDir {
//     dir 'libs'
// }

// maven {
// url = "https://maven.blamejared.com/"
// }
maven {
name = 'tterrag maven'
url = 'https://maven.tterrag.com/'
}
maven {
url = "https://cursemaven.com"
}
maven {
name = "squiddev"
url = "https://squiddev.cc/maven/"
// content {
// includeGroup "org.squiddev"
// }
}
maven {
url = "https://maven.theillusivec4.top/"
}

}

dependencies {
// Specify the version of Minecraft to use. If this is any group other than 'net.minecraft', it is assumed
// that the dep is a ForgeGradle 'patcher' dependency, and its patches will be applied.
// The userdev artifact is a special name and will get all sorts of transformations applied to it.
minecraft 'net.minecraftforge:forge:1.20.1-47.2.4'

// Real mod deobf dependency examples - these get remapped to your current mappings
// compileOnly fg.deobf("mezz.jei:jei-${mc_version}:${jei_version}:api") // Adds JEI API as a compile dependency
// runtimeOnly fg.deobf("mezz.jei:jei-${mc_version}:${jei_version}") // Adds the full JEI mod as a runtime dependency
// implementation fg.deobf("com.tterrag.registrate:Registrate:MC${mc_version}-${registrate_version}") // Adds registrate as a dependency

implementation fg.deobf("com.simibubi.create:create-1.20.1:0.5.1.e-24:slim")
implementation fg.deobf("com.jozufozu.flywheel:flywheel-forge-1.20.1:0.6.9-5")
implementation fg.deobf("com.tterrag.registrate:Registrate:MC1.20-1.3.3")
implementation fg.deobf("curse.maven:jei-238222:4644453")
compileOnly("cc.tweaked:cc-tweaked-1.20.1-core-api:1.105.0")
compileOnly fg.deobf("cc.tweaked:cc-tweaked-1.20.1-forge-api:1.105.0")
runtimeOnly fg.deobf("cc.tweaked:cc-tweaked-1.20.1-forge:1.105.0")
runtimeOnly fg.deobf("curse.maven:every-compat-628539:4980517")
implementation fg.deobf("curse.maven:selene-499980:4980621")

annotationProcessor 'org.spongepowered:mixin:0.8.5:processor'
testAnnotationProcessor 'org.spongepowered:mixin:0.8.5:processor'
// For more info...
// http://www.gradle.org/docs/current/userguide/artifact_dependencies_tutorial.html
// http://www.gradle.org/docs/current/userguide/dependency_management.html

}
// Example for how to get properties into the manifest for reading at runtime.
jar {
manifest {
attributes([
"Specification-Title" : "createdieselgenerators",
"Specification-Vendor" : "createdieselgenerators",
"Specification-Version" : "1", // We are version 1 of ourselves
"Implementation-Title" : project.name,
"Implementation-Version" : project.jar.archiveVersion,
"Implementation-Vendor" : "createdieselgenerators",
"Implementation-Timestamp": new Date().format("yyyy-MM-dd'T'HH:mm:ssZ"),
'MixinConfigs': 'createdieselgenerators.mixins.json'
])
}
}

// Example configuration to allow publishing using the maven-publish plugin
// This is the preferred method to reobfuscate your jar file
jar.finalizedBy('reobfJar')
// However if you are in a multi-project build, dev time needs unobfed jar files, so you can delay the obfuscation until publishing by doing
// publish.dependsOn('reobfJar')

publishing {
publications {
mavenJava(MavenPublication) {
artifact jar
}
}
repositories {
maven {
url "file://${project.projectDir}/mcmodsrepo"
}
}
}

tasks.withType(JavaCompile).configureEach {
options.encoding = 'UTF-8' // Use the UTF-8 charset for Java compilation
}

mixin {
add sourceSets.main, "mixins.createdieselgenerators.refmap.json"
config "createdieselgenerators.mixins.json"
}
`

`package com.jesz.createdieselgenerators.mixins;

import com.jesz.createdieselgenerators.blocks.entity.OilBarrelBlockEntity;
import com.simibubi.create.foundation.fluid.SmartFluidTank;
import net.minecraft.world.level.block.entity.BlockEntity;
import net.minecraftforge.fluids.FluidStack;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Shadow;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;

@mixin(value = com.simibubi.create.content.contraptions.MountedFluidStorage.class,priority = 1100,remap = false)
public abstract class MountedFluidStorageMixin {
@shadow protected abstract void onFluidStackChanged(FluidStack fs);

@Inject(at = @At("HEAD"), method = "canUseAsStorage(Lnet/minecraft/world/level/block/entity/BlockEntity;)Z", cancellable = true, remap = false)
private static void canUseAsStorage(BlockEntity be, CallbackInfoReturnable<Boolean> cir){
    if(be instanceof OilBarrelBlockEntity)
        if(((OilBarrelBlockEntity) be).isController())
            cir.setReturnValue(true);
}
@Inject(at = @At("HEAD"), method = "createMountedTank(Lnet/minecraft/world/level/block/entity/BlockEntity;)Lcom/simibubi/create/foundation/fluid/SmartFluidTank;", cancellable = true, remap = false)
private void createMountedTank(BlockEntity be, CallbackInfoReturnable<SmartFluidTank> cir){
    if(be instanceof OilBarrelBlockEntity)
        cir.setReturnValue(new SmartFluidTank(
                ((OilBarrelBlockEntity) be).getTotalTankSize() * OilBarrelBlockEntity.getCapacityMultiplier(),
                this::onFluidStackChanged));
}

}
`

Create v0.5.1e (issue)

the create v0.5.1e update seems to have broken a few addon mods and this seems to be one is there a possibility of a version update to make it compatible with v0.5.1e

[1.18.2] Client crashes while pondering item

When pondering the Diesel engine item, the client crashes with the error code:

java.lang.NullPointerException: Cannot invoke "com.jesz.createdieselgenerators.other.CDGFuelType.getGeneratedNormal()" because the return value of "com.jesz.createdieselgenerators.other.FuelTypeManager.getType(net.minecraft.world.level.material.Fluid)" is null

[Bug/Crash] [1.20.1] [47.1.39] Crashing when pondering

I'm running a server and one of the people playing crashes when he ponders the "modular diesel engine", i'll copy paste his message here with his crash report.

I got this Crash Report while pondering the modular diesel engine, it crashed specifically at the step you can jump to where it says you can stack them. exactly upon reaching the marker in the timeline the game crashed. also this is the text of the popup the launcher gave me as well for the same crash.

The game crashed whilst ticking screen Error: java.lang.NullPointerException: Cannot read field "tank" because "this.FrontEngine" is null

https://pastebin.com/sKXkRpJ7 <-- crash log

Asphalt and C&B

Asphalt appears to be incompatible with the 1.20 version of Chisel and Bits. It also seems to be a ‘transparent’ block, allowing light to pass through, and for grass to grow under it.

Crashing on new world.

1.20.1
Crashing when generating new world.

[15:38:13] [main/ERROR]: Failed to start the minecraft server java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'createdieselgenerators'! at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.game.minecraft.Hooks.startServer(Hooks.java:62) ~[fabric-loader-0.14.22.jar:?] at net.minecraft.server.Main.main(Main.java:112) ~[server-intermediary.jar:?] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.installer.ServerLauncher.main(ServerLauncher.java:69) ~[fabric-server-mc.1.20.1-loader.0.14.22-launcher.0.11.2.jar:0.11.2] Caused by: java.lang.NoClassDefFoundError: org/apache/commons/compress/utils/Lists at com.jesz.createdieselgenerators.CreativeTab.register(CreativeTab.java:31) ~[creatediselgenerators-2.1.2.jar:?] at com.jesz.createdieselgenerators.CreateDieselGenerators.onInitialize(CreateDieselGenerators.java:36) ~[creatediselgenerators-2.1.2.jar:?] at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47) ~[fabric-loader-0.14.22.jar:?] ... 8 more Caused by: java.lang.ClassNotFoundException: org.apache.commons.compress.utils.Lists at jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641) ~[?:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226) ~[fabric-loader-0.14.22.jar:?] at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112) ~[fabric-loader-0.14.22.jar:?] at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?] at com.jesz.createdieselgenerators.CreativeTab.register(CreativeTab.java:31) ~[creatediselgenerators-2.1.2.jar:?] at com.jesz.createdieselgenerators.CreateDieselGenerators.onInitialize(CreateDieselGenerators.java:36) ~[creatediselgenerators-2.1.2.jar:?] at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47) ~[fabric-loader-0.14.22.jar:?] ... 8 more

Fermenting Timer doesn't Scale with Speed

I am aware this may not be a direct issue in the mod, and may never become an issue, but I'm adding custom recipes for a modpack, and turning up the processing time makes the hand on the timer starts further.
It should start at the same place, but move at a slower speed

2023-11-05_10 30 06
2023-11-05_10 30 11

Sound of Diesel engines is extremely obnoxious and way too loud

title has the core of it

yes i understand it should be loud, but this is way too much. i have to turn block sounds down to 5% to notice ANY difference.
please either add some other option to silence it other than this weird silencer item, or at least make the sound less obnoxious. this is hostile by design.

yes theres a silencer item, however it doesnt seem to work with huge diesel engines

i've had many users on our server complain about it, getting overstimulated. this sound is an autism killer.

any 1.18 port?

says it all in the title, are you planning to port to create 0.5.1b and c for 1.18.2 forge?

Crash upon playing version 1.20.1

Basic descryption:

Upon loading Minecraft forge automatically goes to the "ERROR DURING MODLOADING" page and shows the following screen:
image

NOTE
When launching with create revision d this doesn't happen.

Testcases:

Multiple mods
Only Dieselgenerators + Create

Useful infos

  • Forge Version: 47.2.1
  • Mod Version: createdieselgenerators-1.20.1-1.1d
  • Create version: create-1.20.1-0.5.1.e

Trace

[13:30:08] [modloading-worker-0/ERROR]: Failed to create mod instance. ModID: createdieselgenerators, class com.jesz.createdieselgenerators.CreateDieselGenerators
java.lang.NoSuchMethodError: 'com.simibubi.create.foundation.data.CreateRegistrate com.simibubi.create.foundation.data.CreateRegistrate.useCreativeTab(net.minecraftforge.registries.RegistryObject)'
	at com.jesz.createdieselgenerators.blocks.BlockRegistry.<clinit>(BlockRegistry.java:19) ~[createdieselgenerators-1.20.1-1.1d.jar%23275!/:1.20.1-1.1d]
	at com.jesz.createdieselgenerators.CreateDieselGenerators.<init>(CreateDieselGenerators.java:38) ~[createdieselgenerators-1.20.1-1.1d.jar%23275!/:1.20.1-1.1d]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
	at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?]
	at net.minecraftforge.fml.javafmlmod.FMLModContainer.constructMod(FMLModContainer.java:70) ~[javafmllanguage-1.20.1-47.2.1.jar%23348!/:?]
	at net.minecraftforge.fml.ModContainer.lambda$buildTransitionHandler$10(ModContainer.java:123) ~[fmlcore-1.20.1-47.2.1.jar%23347!/:?]
	at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?]
	at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?]
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?]
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?]
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?]
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?]
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]

Chemical Sprayer projectiles have weird starting position

ChemicalSprayerProjectileEntity originates on the west side of the player and does not rotate around, depending on player look direction. It's rotation is only influenced by Up/Down looking angle: when looking up - it moves to the south of the player, down - north.

Due to this, when moving in the direction, opposite of where it is spawned (projectile spawns behind the player) - there's very high chance of the player being set on fire by his own projectile.

Adding some kind of buffer time, where player cannot be set on fire by his own projectile at the start, can be helpful too, because now you'll be set on fire when moving quickly even if projectile starting point positioned in front of you. Or just spawing projectile further from the player.


Offtopic suggestion: limit duration of the ChemicalSprayerProjectileEntity so it would burn up when traveling for too long.

1.20.1 just fails

hi, i had wanted to add this mod to my server but got the same error on the server and client

Screenshot 2023-10-08 202926

Missing textures

Describe the bug

I got these warnings:

  • Missing textures in model createdieselgenerators:biodiesel#level=3:minecraft:textures/atlas/blocks.png:createdieselgenerators:fluid/biodiesel_still
  • Missing textures in model createdieselgenerators:plant_oil#level=15:minecraft:textures/atlas/blocks.png:createdieselgenerators:fluid/plant_oil_still
  • Missing textures in model createdieselgenerators:ethanol#level=0:minecraft:textures/atlas/blocks.png:createdieselgenerators:fluid/ethanol_still

To Reproduce

  • Install the mod.
  • Run the game with the output console.
  • Warning is printed to console.

Additional context

  • Mod version: 1.1d for 1.20.1
  • Forge version: 47.1.47
  • Create version: 0.5.1b for 1.20.1

Stress unit dupe???? (1.20.1 forge)

So i have this test contraption that automatically powers itself,the creative tank has infinite diesel.
2024-01-04_18 06 00
2024-01-04_18 06 05
2024-01-04_18 06 08
both goggles and the stressometer say it produces 20k stress units.
2024-01-04_18 06 27
but after rejoining the world,it suddenly becomes 40k? it does not show up on the modular diesel engine with goggles
2024-01-04_18 09 17
on the goggles,but i can connect a lot more to it without it getting overstressed
latest.log
debug.log

Please add config for fuels

By that I mean a way to configure the already existing fuels (gasoline, diesel, biodiesel etc.) to configure their speed, stress, burn rate.

Gasoline, diesel/biodiesel, have the same stats and it would be nice if they are changed or if you could modify them in the config. In real world they work a bit different, so you could make gasoline have a higher speed and burn rate, but lower stress, and the opposite for diesel/biodiesel.

Please Add config for generator

the generators really suck by default. please add some config so you can change their speed, stress capacity, and fuel use rate

Error for tag 'farmersdelight:tomato'

Describe the bug

When I create a world with the mod and without farmerdelight. I got this error:

Couldn't load tag [farmersdelight:tomato (from createdieselgenerators-1.20.1-1.1d.jar), farmersdelight:pumpkin_slice (from createdieselgenerators-1.20.1-1.1d.jar), farmersdelight:rice_panicle (from createdieselgenerators-1.20.1-1.1d.jar)] as it is missing following references: farmersdelight:tomato (from createdieselgenerators-1.20.1-1.1d.jar),
farmersdelight:pumpkin_slice (from createdieselgenerators-1.20.1-1.1d.jar),
farmersdelight:rice_panicle (from createdieselgenerators-1.20.1-1.1d.jar)

To Reproduce

  • Install the mod.
  • Run the game with the output console.
  • Create a world
  • Error is printed on console

Additional context

  • Mod version: 1.1d for 1.20.1
  • Forge version: 47.1.47
  • Create version: 0.5.1b for 1.20.1

mod does not work and gives exit error 1 error

When I install the mod, when I press the start game button, the game loading screen comes up and closes. After it closes, it gives Minecraft launcher exit error 1 error. There is no file in the crash-reports folder. Only the latest.log file gets this text:

[27Dec2023 16:56:32.344] [main/FATAL] [mixin/]: Mixin apply failed createdieselgenerators.mixins.json:EntityMixin -> net.minecraft.world.entity.Entity: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on tick could not find any targets matching 'tick()V' in net.minecraft.world.entity.Entity. Using refmap mixin.refmap.json [PREINJECT Applicator Phase -> createdieselgenerators.mixins.json:EntityMixin -> Prepare Injections ->  -> handler$bcd001$tick(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on tick could not find any targets matching 'tick()V' in net.minecraft.world.entity.Entity. Using refmap mixin.refmap.json [PREINJECT Applicator Phase -> createdieselgenerators.mixins.json:EntityMixin -> Prepare Injections ->  -> handler$bcd001$tick(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]

mod version: createdieselgenerators-1.20.1-1.2f
create version: create-1.20.1-0.5.1.f
forge version: 1.20.1 - 47.2.18

how can i fix this?

[1.19.2] Pondering about modular engines brings up the entry for engine silencers (and a couple other minor issues)

It's so minor it's almost not worth reporting, but it did make me question if a scene was missing until I went to the next page and saw that there was an entry for the modular engine.

I also noticed that Plant Oil gives 48 RPM and 1,024 Stress Units even though it's really easy to get. I think having it being 32 RPM and 256 Stress Units would be a bit more balanced (or letting us configure each fluid rather than the vague "weak" and "strong" the config currently uses).

CraftTweaker support for fermenting basins and engines would also be lovely. CF page says nothing about it, so it seems like it's not implemented.

Pumpjack ponder structure is invalid

I couldn't get the pumpjack to work even by copying the ponder menu exactly so I "looked under the surface" a bit with NBTExplorer to make sure I had it right and still couldn't understand why it wasn't working. Finally just moved the central bearing over one block to make it balanced on both sides and it started right up. Seems like the dimensions are just wrong in the ponder menu, which is a little confusing.
2023-10-30_02 37 07
Left is modified, Right is the ponder nbt structure pasted in using a schematic

I'm on 1.20.1, mod version 1.2b, create version 0.5.1.e

What is problem? Critical injection failure on client startup

[251월2024 11:39:25.454] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "BetterF3-7.0.2-Forge-1.20.1.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.454] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "BiomesOPlenty-1.20.1-18.0.0.598.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.455] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "cc-tweaked-1.20.1-forge-1.109.3.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.455] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "cloth-config-11.1.118-forge.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.455] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "create-1.20.1-0.5.1.f.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.455] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "createaddition-1.20.1-1.1.1.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.456] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "createdieselgenerators-1.20.1-1.2f.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.456] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "createutilities-0.1.4+1.20.1.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.456] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "jei-1.20.1-forge-15.2.0.27.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.456] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "Mekanism-1.20.1-10.4.5.19.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.456] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "MekanismAdditions-1.20.1-10.4.5.19.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.457] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "MekanismGenerators-1.20.1-10.4.5.19.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.457] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "MekanismTools-1.20.1-10.4.5.19.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.457] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "memoryleakfix-forge-1.17+-1.1.5.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.458] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "sound-physics-remastered-forge-1.20.1-1.3.1.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.458] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "TerraBlender-forge-1.20.1-3.0.1.2.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.458] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "Xaeros_Minimap_23.9.3_Forge_1.20.jar" of type MOD with provider {mods folder locator at C:\Users\Hanlim\AppData\Roaming.minecraft\mods}
[251월2024 11:39:25.687] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\Hanlim\AppData\Roaming.minecraft\libraries\net\neoforged\fancymodloader\core\47.1.47\core-47.1.47.jar is missing mods.toml file
[251월2024 11:39:25.693] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\Hanlim\AppData\Roaming.minecraft\libraries\net\neoforged\fancymodloader\language-java\47.1.47\language-java-47.1.47.jar is missing mods.toml file
[251월2024 11:39:25.699] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\Hanlim\AppData\Roaming.minecraft\libraries\net\neoforged\fancymodloader\language-lowcode\47.1.47\language-lowcode-47.1.47.jar is missing mods.toml file
[251월2024 11:39:25.704] [main/WARN] [net.minecraftforge.fml.loading.moddiscovery.ModFileParser/LOADING]: Mod file C:\Users\Hanlim\AppData\Roaming.minecraft\libraries\net\neoforged\fancymodloader\language-minecraft\47.1.47\language-minecraft-47.1.47.jar is missing mods.toml file
[251월2024 11:39:25.717] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "core-47.1.47.jar" of type LIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@37fdfb05
[251월2024 11:39:25.717] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "language-java-47.1.47.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@37fdfb05
[251월2024 11:39:25.717] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "language-lowcode-47.1.47.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@37fdfb05
[251월2024 11:39:25.719] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "language-minecraft-47.1.47.jar" of type LANGPROVIDER with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@37fdfb05
[251월2024 11:39:25.719] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "client-1.20.1-20230612.114412-srg.jar" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@37fdfb05
[251월2024 11:39:25.719] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "forge-1.20.1-47.1.88-universal.jar" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.MinecraftLocator@37fdfb05
[251월2024 11:39:25.728] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "events-47.1.47.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.BuiltinGameLibraryLocator@7c455e96
[251월2024 11:39:25.984] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator/]: Found 7 dependencies adding them to mods collection
[251월2024 11:39:25.985] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "cobalt-0.8.2.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator@522ba524
[251월2024 11:39:25.985] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "jzlib-1.1.3.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator@522ba524
[251월2024 11:39:25.985] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "flywheel-forge-1.20.1-0.6.10-7.jar" of type MOD with provider net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator@522ba524
[251월2024 11:39:25.986] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "netty-codec-socks-4.1.82.Final.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator@522ba524
[251월2024 11:39:25.986] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "netty-handler-proxy-4.1.82.Final.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator@522ba524
[251월2024 11:39:25.986] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "Registrate-MC1.20-1.3.3.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator@522ba524
[251월2024 11:39:25.986] [main/INFO] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Found mod file "netty-codec-http-4.1.82.Final.jar" of type GAMELIBRARY with provider net.minecraftforge.fml.loading.moddiscovery.JarInJarDependencyLocator@522ba524
[251월2024 11:39:28.374] [main/INFO] [mixin/]: Compatibility level set to JAVA_17
[251월2024 11:39:28.624] [main/INFO] [mixin/]: Successfully loaded Mixin Connector [com.sonicether.soundphysics.MixinConnector]
[251월2024 11:39:28.627] [main/INFO] [cpw.mods.modlauncher.LaunchServiceHandler/MODLAUNCHER]: Launching target 'forgeclient' with arguments [--version, 1.20.1-forge-47.1.88, --gameDir, C:\Users\Hanlim\AppData\Roaming.minecraft, --assetsDir, C:\Users\Hanlim\AppData\Roaming.minecraft\assets, --uuid, 43d423f9d0de4c80a8ab4354de978bb2, --username, Bineul_Dayo, --assetIndex, 5, --accessToken, ????????, --clientId, MzAyODllYzItZjMwOC00YmIyLWEwMjItYjg5YmI0OTQzYjE0, --xuid, 2535464370051867, --userType, msa, --versionType, release, --quickPlayPath, C:\Users\Hanlim\AppData\Roaming.minecraft\quickPlay\java\1706150360603.json]
[251월2024 11:39:30.407] [main/INFO] [memoryleakfix/]: [MemoryLeakFix] Will be applying 3 memory leak fixes!
[251월2024 11:39:30.407] [main/INFO] [memoryleakfix/]: [MemoryLeakFix] Currently enabled memory leak fixes: [targetEntityLeak, biomeTemperatureLeak, hugeScreenshotLeak]
[251월2024 11:39:30.657] [main/INFO] [MixinExtras|Service/]: Initializing MixinExtras via ca.fxco.memoryleakfix.mixinextras.service.MixinExtrasServiceImpl(version=0.3.2).
[251월2024 11:39:33.152] [pool-4-thread-1/FATAL] [mixin/]: Mixin apply failed createdieselgenerators.mixins.json:EntityMixin -> net.minecraft.world.entity.Entity: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Critical injection failure: @Inject annotation on tick could not find any targets matching 'tick()V' in net.minecraft.world.entity.Entity. Using refmap mixin.refmap.json [PREINJECT Applicator Phase -> createdieselgenerators.mixins.json:EntityMixin -> Prepare Injections -> -> handler$zdp000$tick(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on tick could not find any targets matching 'tick()V' in net.minecraft.world.entity.Entity. Using refmap mixin.refmap.json [PREINJECT Applicator Phase -> createdieselgenerators.mixins.json:EntityMixin -> Prepare Injections -> -> handler$zdp000$tick(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.validateTargets(InjectionInfo.java:656) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.findTargets(InjectionInfo.java:587) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.readAnnotation(InjectionInfo.java:330) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.(InjectionInfo.java:316) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.(InjectionInfo.java:308) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.injection.struct.CallbackInjectionInfo.(CallbackInjectionInfo.java:46) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77) ~[?:?]
at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499) ~[?:?]
at java.lang.reflect.Constructor.newInstance(Constructor.java:480) ~[?:?]
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo$InjectorEntry.create(InjectionInfo.java:149) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.parse(InjectionInfo.java:708) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.prepareInjections(MixinTargetContext.java:1311) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.prepareInjections(MixinApplicatorStandard.java:1042) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:393) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:383) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:365) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:250) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.service.modlauncher.MixinTransformationHandler.processClass(MixinTransformationHandler.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at org.spongepowered.asm.launch.MixinLaunchPluginLegacy.processClass(MixinLaunchPluginLegacy.java:131) ~[mixin-0.8.5.jar:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4]
at cpw.mods.modlauncher.serviceapi.ILaunchPluginService.processClassWithFlags(ILaunchPluginService.java:156) ~[modlauncher-10.0.9.jar:10.0.9+10.0.9+main.dcd20f30]
at cpw.mods.modlauncher.LaunchPluginHandler.offerClassNodeToPlugins(LaunchPluginHandler.java:88) ~[modlauncher-10.0.9.jar:?]
at cpw.mods.modlauncher.ClassTransformer.transform(ClassTransformer.java:120) ~[modlauncher-10.0.9.jar:?]
at cpw.mods.modlauncher.TransformingClassLoader.maybeTransformClassBytes(TransformingClassLoader.java:50) ~[modlauncher-10.0.9.jar:?]
at cpw.mods.cl.ModuleClassLoader.readerToClass(ModuleClassLoader.java:113) ~[securejarhandler-2.1.10.jar:?]
at cpw.mods.cl.ModuleClassLoader.lambda$findClass$15(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?]
at cpw.mods.cl.ModuleClassLoader.loadFromModule(ModuleClassLoader.java:229) ~[securejarhandler-2.1.10.jar:?]
at cpw.mods.cl.ModuleClassLoader.findClass(ModuleClassLoader.java:219) ~[securejarhandler-2.1.10.jar:?]
at cpw.mods.cl.ModuleClassLoader.loadClass(ModuleClassLoader.java:135) ~[securejarhandler-2.1.10.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:525) ~[?:?]
at net.minecraftforge.registries.GameData.init(GameData.java:103) ~[forge-1.20.1-47.1.88-universal.jar%23195!/:?]
at net.minecraftforge.registries.GameData.(GameData.java:88) ~[forge-1.20.1-47.1.88-universal.jar%23195!/:?]
at net.minecraft.core.registries.BuiltInRegistries.forge(BuiltInRegistries.java:429) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
at net.minecraft.core.registries.BuiltInRegistries.forge(BuiltInRegistries.java:409) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
at net.minecraft.core.registries.BuiltInRegistries.(BuiltInRegistries.java:121) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
at net.minecraft.server.Bootstrap.m_135870_(Bootstrap.java:43) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
at net.minecraft.client.main.Main.lambda$main$0(Main.java:151) ~[client-1.20.1-20230612.114412-srg.jar%23190!/:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

A few issues with silencers

Small Engines:
Small Diesel Engines do not silence. I have tried putting a silencer on one both before and after it's started running, and it visually equips but does not silence.
2024-01-20_11 54 49
(this also shows up in the subtitles)

Modular/Medium Engines:
When using Modular Engines, the silencers are a little weird. I don't know exactly how to explain it, but I have screenshots. If the side of the silencer that has the pipe is "forwards", all modular engines "behind" a silenced engine also become silent, regardless of whether or not they have a silencer equipped. When set up like this, none of the engines make noise:
2024-01-20_12 24 04
But, when set up like this, all four unsilenced engines are loud again:
2024-01-20_12 24 39

The direction the engine is rotating does not effect this, and neither does which direction you approach it from when placing the silencers.
Ideally each engine should individually check whether or not it is silenced. I like the idea of being able to silence a whole chain of modular engines all at once, but this should require enough silencers to do them all. The ability to silence all of them at once (or rather, up to the amount of engines as the number of silencers you're holding) by shift-clicking would be a great quality-of-life feature to add in later.
edit: it appears to only be one additional engine module, not all of them after a silenced engine. Still kinda weird though

When using a wrench on a silenced modular engine, it always removes the silencer first, no matter what part of the engine you're looking at. It's mildly annoying to have to remove the silencer, change whether or not that particular module has a pipe input, and then put the silencer back on every single time you want to adjust something. I was in a creative test world, just mucking around with a few and found it mildly annoying, but I would quickly lose my mind if I was in a large world and needed to re-configure the pipe work on a massive power plant with lots of generators.
A better solution would be to only remove the silencers when targeting them (or if that becomes weird and janky, only the sides of the generators), and not the top or bottom of them. Alternatively, you could make it so that silenced engines become their own block (this would make building in creative so much easier, too), and breaking a silenced engine drops a silenced engine instead of an engine and a silencer. Then there could be some sort of easy recipe to craft/uncraft silenced engines. Perhaps make it so that they drop an engine and silencer when mined normally, but a silenced engine when silk-touched or broken with a wrench?

Huge Engines:
Huge engines do not silence, nor is there a way to apply one currently. This makes sense, since they have no visual exhaust like the other two do, but it would still be good to have, both for the sake of consistency and also general sanity. Perhaps being able to craft them with a silencer, if you don't want to have to remodel/retexture to include an exhaust? I honestly like the way they look right now, but they're so loud I can't stand using them. This is more related to the actual sound they make, going pop-pop-pop (my brain processes it as a bunch of distinct sounds, not one continuous noise like from the other generators). Even when rotating at the max speed of 256 rpm they aren't quite going fast enough to be a constant noise. This could be helped by having two engines that are next to each other, rotating the same shaft be 90º (25%) out of phase instead of 180º (50%), or changing the phase depending on how many are next to each other.

A few other things relating to the silencer in general:
It gets a little confusing when looking at a silenced engine, because there's no easy way to tell at a glance whether or not it's running. Spawning a few smoke particles would help with that immensely, since you don't have the visual feedback of the pistons moving anymore.

Also, the initial movement direction of the engines is related to which way you're facing when you place them, but the silencers always face the same direction. "Forwards" is either South or East. It would be nice to have "forwards" on the silencer also indicate rotation direction.

[Suggestion] Fermentation Indication

Hi! Loving this mod so far, the basin fermenting is very cute and elegant, however there is something I would like to suggest.

Here is my suggestion

Similarly to noises the mixer or press make when they are working, perhaps the Fermenting Basin could have a sort of bubbling sound to tell the player that it is working.

I am planning on using the fermenting basin for some far longer recipes, and I want players to be able to tell if it's actually making them or not, since currently there is no indication.

Here's what I personally have in mind:

  • When the Basin Lid is open, no sounds play.
  • When the Basin Lid is closed, but the items or fluids inside cannot be processed, no sounds play.
  • When the Basin Lid is closed, and the items or fluids inside can be processed, then a periodic bubbling sound will play throughout the process, similarly to the crackling of a furnace.
  • When the processing is finished, an exaggerated bubbling sound plays, letting the player know that it has finished.

I can imagine this being a very positive ambient addition. Imagine a factory filled with fermenting basins, all lightly bubbling away as they process whatever is inside them.

- Sincerely, a fermentation aficionado

Distilleries stop working on a save/load if they are full of fluid.

The bug is here: https://github.com/george8188625/Create-Diesel-Generators/blob/1.19.2/src/main/java/com/jesz/createdieselgenerators/blocks/entity/DistillationTankBlockEntity.java#L129

Because currentRecipe isn't saved/loaded with NBT, when the block is loaded from disc currentRecipe is null. But, because the heat is saved, when it loads it never recalculates the recipe.

I think recalculating the recipe in either a markDirty override (not sure what your mappings call it) or at the end of the read method would fix this.

Compatibility issues with train mod KuaYue

Game version: 1.18.2
Forge version: 40.2.14
Problem mod version:0.1.1~0.3.5

Issue details:

Normally run Create, Create: Diesel Generators and KuaYue will cause the game to fail to start
In development mode, running only Create: Diesel Generators and KuaYue did not crash, but adding Create would cause the game to crash

Problem mod link:

KuaYue:https://modrinth.com/mod/kuayue/versions?g=1.18.2

Problem analysis:

Inject this annotation does not find a method to execute
6X7 }RAG(RR@60H9XMMPKL

debug.log:

https://mclo.gs/uj6L5Bi

latest.log:

https://mclo.gs/FVxS8iy

Compatibility issues with multiplayer game

Game version: 1.20.1
Forge version: 47.2.14
Problem mod version:1.2e

Issue details:
The pumpjack couldn't work correctly in multiplayer game.It has animation and sound effects, but it just doesn't work.

Fermenting Farmer's Delight Compat - 1.20.1

Hi,
Could you add compat with farmers delight for the fermenting, adding vegetables or fruits from that mod that could be considered fermented for ethanol

You could create a forge tag called
forge:fermentable

these are examples of things that could be fermentable:
image

Possible adding support for corn from Corn Delight mod too

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.