genxium / delaynomore Goto Github PK

On backend, as "Room.downsyncToAllPlayers -> downsyncToSinglePlayer" is always called when "Room.InputsBufferLock" is released (for good reason, i.e. allowing all-confirmed inputFrames to be marked/forced asap), it's possible that in certain cases "inputsBufferSnapshot with larger snapshotStFrameId" is sent BEFORE "inputsBufferSnapshot with smaller snapshotStFrameId" for a same player, e.g. "Room.OnBattleCmdReceived" called twice for different players resulting in two inputsBufferSnapshots with different snapshotStFrameIds but the later "Room.OnBattleCmdReceived" call invoked "downsyncToAllPlayers" earlier.

To prevent such pitfall, it's possible to put each "queueElement = (refRenderFrameId, unconfirmedMask, inputsBufferSnapshot)" into a FIFO queue "Room.downsyncBuffer" while "Room.InputsBufferLock" is still held but before any network I/O, then let "Room.downsyncToAllPlayers" consume it with network I/O.

On backend,

1. The backend dynamics can be calculated for 1 more renderFrame, i.e. nextDynamicsRenderFrame should be "ConvertToLastUsedRenderFrameId(lastAllConfirmedInputFrameId, inputDelayFrames) + 1" w.r.t. "lastAllConfirmedInputFrame"

2. When creating inputsBufferSnapshot, refRenderFrameId can just be "ConvertToLastUsedRenderFrameId(lastAllConfirmedInputFrameId, inputDelayFrames)" which is EXACTLY the last renderFrame our "lastAllConfirmedInputFrame" can apply on. There's no need to make an extra "-1".