genie-mc / reweight Goto Github PK

A MicroBooNE user reports a fatal error when running the MaCCQE weight calculator over a sample containing a CCQE-strange event. The error message was
1588038661 FATAL KineLimits : [s] <Jacobian (255)> : *** Can not compute Jacobian for transforming: <QELEvGen> --> <{Q2}|E>

Recent fixes on the Generator master branch allow RES events involving production of P33(1600) to be simulated correctly (see GENIE docDB #153 for a description of the issue discovered in R-3_00_06). When either of the two Reweight knobs varying resonance decay branching ratios (RDecBR1gamma and RDecBR1eta) are used with these events, however, a segfault occurs in GReWeightResonanceDecay::RewBR().

The segfault occurs because kPdgP33m1600_DeltaP (and the other Δ(1600) PDG codes) are missing from a hard-coded list of resonances in GReWeightResonanceDecay.cxx. As a result, a TH1D needed for the branching ratio calculations is not produced and leads to an attempt to dereference a nullptr.

At a minimum, the resonance PDG code list in Reweight/src/RwCalculators/GReWeightResonanceDecay.cxx should be brought up to date with the master branch of Generator. It would be better to remove the hard-coded list in favor of a solution that is easier to maintain.

@nusense noticed that we don't set the tune in this application and we think this is an error.

https://github.com/GENIE-MC/Reweight/blob/a5136da537e37f0bbbef762ec71a64c1c87727e8/src/Apps/gRwghtNCorrelatedParams.cxx

Shall we take actions?

An Issue has been reported by Kirk from NOvA during the forum (March 2020). They discovered that the z-expansion re-weight knobs which are supposed to take into account the correlations between the 4 parameters of the standard z-expansion are not taking into account the correlation at all.

Oh, this might be mistaken, haven't deleted it yet. My installation had not created an include directory (which is sometimes optional, but possibly not optional for using this package).

Simple fix:

The src/RwCalculators/GReWeightINuke.h
needs
#include "Framework/GHEP/GHepParticle.h"
because its part of the method CalcDeltaAZ specified in the .h file

Having it in the .cxx file is not enough, compiler gives unknown type name

Using AlmaLinux 9.1