gelio / devoter Goto Github PK

When a list of polls is displayed there is no accounting for expiry date, which results in already expired polls being shown. This is not what we intended and needs to be fixed.

Here polls are moved by one (1st row refers to 2nd poll, etc), thus real 1st poll is never shown, and 3rd row refers to empty poll.

When a new poll is created the ID of a new poll is done via counting rows, which is a bad solution.

The correct one is to first insert a row, then run a SQL query: SELECT LAST_INSERT_ID(); which returns simply the ID which is needed.

Before using that please first check in phpMyAdmin what's the name of the column with the last ID. Or use AS to name it, but I don't know if it works. Here's an example of what I have in my mind with the AS:

SELECT LAST_INSERT_ID() AS id;

And then you can probably refer to id as it was a normal query.

After creating a poll the script doesn't provide the ID of a newly created poll therefore resulting in redirecting to the main page instead of the poll's page.

When displaying polls it defaults to current date not taking account what is passed from API.

When an error is reported there should be an error object (array) in the array which contains code and message keys as indicated in the API-info.

Here's an example:

$output = array();
$output['error'] = array(
    'code' => 2,
    'message' => "There's something wrong with data sent"
);

Modify display scripts to convert DATETIME to UNIX TIMESTAMP in PHP and then take that into account in Angular.

While parsing numeric parameters double-check them to avoid SQL injection (especially in scripts showing polls)

Scripts need to check the IP of a user in the same way. No different methods can be used, because it causes malfunctioning.

I'd suggest you use this. It seems to be working.