geel9 / runelite-hunter-rumours Goto Github PK

As the title states. I like the addition of this new feature, but the caught value seems to carry over between each rumour.

• Restarting the game does not seem to reset this value.
• Getting assigned a new task from a different rumour master does not reset this value either.

The value was reset at one point for me, but I'm unsure what criteria was met.

The infobox should be disabled after 5 minutes (or the amount of minutes set in the config) of no rumour related activity, unless a force infobox config is set.

First of all, I love the information while hovering the infobox of current rumour, great job!

It is a very good feature to be able to set a timer to disable the infobox after a while. However, sometimes I am AFK'ing between hunter tasks and my infobox is gone. It would be amazing if it would be possible to retrigger this infobox by checking my current rumour on my quetzal whistle.

Thanks in advance for considering.

When a proper block list for hunter rumors is set, players aim to get certain hunter rumors as much as possible, and avoid getting unwanted rumors. After getting a good rumor, such as kebbits, players tend to toggle ON b2b rumors for a chance to get the task again. However, if the assigned task is bad, the b2b setting is then turned off.

Since you have to turn this setting on and off so many times during hunter rumors, it would be great to indicate what is the current state of Back to back rumor setting, so you won't have to run to the NPC and check it via dialogue. This could possibly be added as an icon, or extra entry in the overlay that opens when visiting Hunters guild basement.

This setting is toggled by speaking to Guild Scribe Verity at the Hunters guild basement.

I want to make a big test for all of the functionality we have going on in the plugin class.

We should either refactor a lot and test everything per class or (probably better because of runelite) we add tests (we can still split up the tests in a sensible way even if we don't pull the plugin class apart by refactoring) for the plugin class.

At the very least we should make tests for some of our core functionality, but I'd rather do it all in 1 go.

Things we already have tests for:

• All enums
• ChatParser

Core things I want to test:

• Enable/disable infobox
• Enable/disable locations
• Overlay
• Pity rate
• Infobox text
• Infobox text color
• Loading from config
• Highlighting of npcs
• Resetting rumour state
• onPlayerChanged

Things we might want to test:

• Quetzal message
• Handling of rumour finished message
• Enabling of hunters
• Setting b2b state
• Rumour state (get & set)
• Hunter (get & set)
• Rumour (get & set)
• Update latest interaction time

The number of animals caught does not seem to be reset when getting a task. I just got a grey chinchompa task for the first time since starting the client. It says I have caught 518/100 however I have not caught any since being assigned the rumour.

I got a kebbit rumour on the 1st catch and the % in that chat is still 0... shouldn't it be 5% (6% depending on rounding) The screenshot below shows it all.

I also hit the pity rate for sunlight moths and the chat said 99% instead of 100

It seems like the calculation for the % in the chat should have 1 added to it... for example it is doing 0/18 as a percent right now for dark kebbits instead of 1/18... and it did 141/142 instead of 142/142 for sunlight moths

The item name is currently showing the wrong item name in the infobox tooltip because of the changes made to the image shown for the infobox.

Currently it just has the word Rumour hovering over it. I think it would be better if it was a short form of what your current rumour is:

SM Sunlight Moth
MM Moonlight Moth
BW Black Warlock
SK Snowy Knight
SG Sapphire Glacialis

SA Sunlight Antelope
MA Moonlight Antelope

DK Dashing Kebbit
DK Dark Kebbit
SK Spotted Kebbit
WK Wild Kebbit
BK Barb-tailed Kebbit
SK Sabre-toothed Kebbit
RK Razor-backed Kebbit
PK Prickly Kebbit

RS Red Salamander
OS Orange Salamander
TS Tecu Salamander
SL Swamp Lizard

GC Grey Chinchompa
RC Red Chinchompa
PF Pyre Fox
EJ Embertailed Jerboa

H Herbiboar

TW Tropical Wagtail

SL Spined Larupia
HG Horned Graahk
SK Sabre-toothed Kyatt

Set the name for all the chat messages sent by the plugin to "Hunter Rumours".

For some reason with my current task of Razor-backed Kebbits all Tool Leprechauns are now highlighted. Turning off that option un-highlights them.

After quite a few hunts the catch rate seemed to quit showing correctly and just keeps adding on to the caught rate

Only show 1 icon per location on the world map in compact mode.

Let's change the rumour text to 'DONE' once you've completed the rumour, just to make it a bit more obvious that you've completed the rumour.

When a hunter rumour is completed, and the End-of-rumour Message option is selected, I find that the percantage is nearly completely unreadable. Would it be possible to change the midway percentage colour to orange instead so that there is a greater contrast.

Make it so you can make a blocklist in the plugin, then the plugin can tell you which masters you have to do to set up your blocklist.

I think this should come after: #32

Orange salamanders at Necropolis is far better than the standard version, assuming Beneath Cursed Sands is completed. People tend to naturally gravitate towards the 1st option in any list so it would make more sense if it were higher up if possible.

I would like to propose some changes to the Rumour enum, as in it's current state it has booleans for whether or not it's a novice, adept ...etc rumour.

However, these booleans are never actually used and don't make too much sense even if they were used.

Because even if some rumour is an adept rumour, it doesn't necessarily have to mean both adept hunters are able to assign these.

So what I'd propose us doing is change these booleans to be a list of possible hunters that can assign these rumours.
Which means that once we get our side panel up and running, we could add a tab that can list out these rumours per hunter (or vice versa).

I have the infobox disable time down to 1 minute and force show info box unchecked but the infobox never actually hides itself

Hi,

Would be great if there was some kind of indicator to show if back to back rumours is enabled or not.

Maybe above Guild Scribe Verity's npc and in the infobox?

Sometimes I forget to turn it off while doing kebbit swapping and get back to back red salamanders for example.

After installing the plugin when the option "Highlight Hunter NPCs" is checked tool leprechauns are also tagged. I assume this is caused by the NONE(0, "Unknown", HunterTier.NONE), line in hunter.java but I am unsure. (npcId 0 being the tool leprechaun).

Issue with the contract number indicator, everything works fine. But when you finish a contract and get a new one the icon doesn't reset to 0.

Sometimes (I don't have a reliable way to reproduce yet but if I find one I'll post it here), when turning in a rumor, the counter of how many creatures have been caught doesn't reset to 0. This means that the next rumor will have show the wrong number remaining, and sometimes even by negative. I looked at the code and it's probably something with the chat parser, but I'm not familiar enough with the RL API to know what. Are the chat messages case sensitive? That could be it.
In case it matters, I am using Gilman.

Alternatively, if tracking this down isn't something you want to do, could you either add a button in the config panel to reset it to 0, or add an option to make checking the whistle reset it to 0? That would at least allow for manual intervention, as-is there's no way to fix it without closing RL and editing the profile file.

I'll take a closer look later when I can.

My infobox doesn't seem to be disappearing after 5 minutes like the config says it should. I haven't done rumors in a while and I'm wondering if this may be the cause of the box not disappearing (may be triggered 5 minutes after the last rumor, but not after 5 minutes of no rumors).

Reported by JustBilly in the RL discord server.
The info box from the Hunter Rumours plugin shows 30kc needed for the pity mechanic @ herbi, but the wiki shows 14kc.
Just noticed it's also not tracking the kc, it stays at 0/30.

We can use this to calc:

Math.floor(pityThreshold * (1 - 0.0125 * pieces)

Since I opened/equipped my third piece of Guild Hunter gear (legs, already have top/head but not boots), this plugin shows my "pity threshold" catch count for Salamanders as 47 (and with "Show Catches Remaining" enabled, counts down from 47) however I don't get the rare part until my 48th catch (after 47 the counter shows 0 remaining, but not "complete" until I catch an extra one). I've had this happen on both reds (twice) and tecus (once). I suspect the same for oranges but haven't reached pity rate on those yet. I've never had to go for a 49th, so I assume the pity catch rate for net traps with 3 Guild Hunter pieces equipped is just 48.

We could add the fairy ring code to the name of the locations to make it easier for people to instantly tp to the right location.

It would be nice to see how many creatures have been caught each rumour so I know how close I am to the Pity Rate if I am going very dry.

I think there's a bug in the 'rumour state' where if you complete a rumour, then go deliver the item and DONT immediately get a new one, the plugin doesn't update to 'Rumour.NONE'.

I've been doing Hunter Rumors for a while and after comparing with the pity rates we have available on the wiki, I think there's still some rounding issues going on. Every time I get to the pity rate, it ends at 12 instead of 13. The formula from below is returning 13 after rounding down.

I'm not sure if this extends to other drop rates as well, but just my findings.

moonlight moths show 150/142 as being the pity number, it's also incorrect/bugged for others as well

Forwarding my request to an issue here as suggested by DapperMickie

While doing rumours the only thing I am currently missing is some sort of action counter till pity rate has been achieved.

For example, I am on an orange salamander task. I know the drop rate is 1/25, and that if I do not receive the drop at action 45, I will get the pity drop at 46 because I have the full outfit.

Maybe a small window that says something like: "Hunter NPC Icon" "Currently Caught Number"/"Pity Rate According to Hunter Outfit equipped" or "Orange Salamander 45/46".

runelite/runelite#17723

EG, for salamanders, the relevant information for a user is how many trees there are (and, for two locations with the same amount, which has the optimal arrangement).

Might require a more in-depth refactor of RumourLocation in general.

When doing rumours I sometimes have a full inventory whenever I receive the item.
I was thinking of adding a highlight on the drop when it's on the ground and whenever you get it in the inventory.

Just makes it a little bit more obvious that you received the item.

Since we already have the spawn locations of the NPCs (and show them on the world map).
We could add tile markers for the spawn locations of the NPCs pretty easily.

We can use this as a reference:
https://github.com/runelite/runelite/tree/master/runelite-client/src/main/java/net/runelite/client/plugins/groundmarkers