geekyshacklebolt / nickoscope Goto Github PK

Currently, if you run the project locally and search for a username availability, then Instagram search results will be fine. But if you use the deployed application on Heroku here: https://nickoscope.herokuapp.com/ then Instagram results will always be "AVAILABLE" that means every time it shows username is ready to take.

Steps to reproduce

1. Clone the repo and run the project locally.
2. Search Username: geekyshacklebolt, Notice Instagram result as "NOT_AVAILABLE"
3. Go to https://nickoscope.herokuapp.com/
4. Search Username: geekyshacklebolt, Notice Instagram result as "AVAILABLE"

I have verified that the master branch on Heroku is updated with GitHub master, and I don't know why this inconsistency occurring.

Currently, usernames availability check is done in broader functions like check_on_sites_with_syntax_domain_username. We can modularize this checking in separate functions for each website and calling them in function check_username_availability. This might also be necessary because there would be different cases and approaches to check username availability on different websites. Therefore, keeping their checks modularize in separate functions would be good in later stages.

Add python package black for formatting code.

Currently, if the username is already taken on a site say GitHub. It shows username for GitHub as "NOT_AVAILABLE". It will be better to use comments like "ALREADY_TAKEN" for better comprehension.

Similarly, you may improve other response messages.

Currently, no matter if the username is available or not, twitter search results are always showing username as "NOT_AVAILABLE" to take, because in both cases the response is coming with status code 200 OK.

Steps to reproduce

1. Go to nickoscope.herokuapp.com/
2. Search any username and it will be listed as "NOT_AVAILABLE" which means "ALREADY_TAKEN".

So, we need to find another way for searching usernames availability on twitter that might need to write an independent function for the same.