geekpete / py-coinspot-api Goto Github PK

Hi geekpete,

I tried converting the coinspot.py to python3 compatible:

• switching the httplib to requests
• signature:
  -- encoding utf-8 for the secret
  -- encoding utf-8 for json payload

but it always returns a {"status":"invalid"}. is there something else that needs to be done to make this python3 compatible?

Sample code:

import hashlib
import json
import hmac
import requests

def apiRequest(apiModel, method, apiKey, secret):
        postdata = {}
        nonce = int(time()*1000000)
        postdata['nonce'] = nonce
        sign = hmac.new(secret.encode('utf-8'), json.dumps(postdata).encode('utf-8'), hashlib.sha512).hexdigest()

        headers = {}
        headers['Content-type'] = 'application/json'
        headers['Accept'] = 'text/plain'
        headers['key'] = apiKey
        headers['sign'] = sign

        response = requests.post('https://www.coinbase.com.au/api/my/balances', headers=headers, data=json.dumps(postdata))
        return response.text

This is rough code, but it seems to work for getting prices. Something like this should be in the API if it isn't already.

-# import libraries
import urllib2
from bs4 import BeautifulSoup

-# specify the url
quote_page = "https://www.coinspot.com.au/buy/dgb"

-# query the website and return the html to the variable page
hdr = {'User-Agent': 'Mozilla/5.0'}
req = urllib2.Request(quote_page,headers=hdr)
page = urllib2.urlopen(req)

-# parse the html using beautiful soup and store in variable soup
soup = BeautifulSoup(page, "html.parser")

-# Take out the

Log responses using:

logger.debug('Response: %s' % response)

The Coinspot._request private function especailly needs some exception handling when communicating with the API endpoint.

Hi,

Thanks for making this package. Is anyone else getting a circular dependency issue when trying to import the CoinSpot package?

I am using Python3.5 and I get an import error:

from coinspot import CoinSpot

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-2-d10b2caa352c> in <module>()
----> 1 from coinspot import CoinSpot as CS

~/.local/lib/python3.5/site-packages/coinspot/__init__.py in <module>()
----> 1 from coinspot import CoinSpot
      2

ImportError: cannot import name 'CoinSpot'

Would have worked in dev when the config.yml was in the same dir using:
os.path.dirname(file)

but breaks if installed via PyPi and yml file is inside user's local homedir folder.

Needs to work wherever you want to put the config.yml file.

So test case is a user does the following:
-installs py-coinspot-api module with pip
-configures a config.yml file in their current dir
-takes example python file and saves in their current dir
-runs the script and hits this error:

./test.py
Attempting to load config.yml I/O error(2): No such file or directory

The required location of the config.yml file as it sits in the code now has to be in the library install path.

I'm leaning towards a low level library not needing to manage yaml files, and just have the user's script have a yaml file if the user want's to store their creds that way.
The library only needs to know what those creds are, when it gets initialised.

As discussed

• YAML file a capability but not a requirement.
  Allow users to just send creds directly at the library i they want. But strongly guide users away from this practice with warnings of them going broke if someone trawls their api keys out of github to pilfer their coinz.
• environment variables
• add dir of executing script to the PATH and try to find YAML file in the path

I suggest we also give the config file a fairly unique name to avoid collision such as:

  coinspot.yml

to avoid loading any old config.yml find we find.

http://docs.python-requests.org/en/latest/

CoinSpot have released the new API V2 in BETA format (https://www.coinspot.com.au/v2/api). According to CoinSpot the new API provides additional functionality as well as enhancements of existing processes.

This is a request to implement all of the API calls from v2

When running many calls in quick succession (ie, without a pause) the time nonce may not be granular enough to ensure uniqueness between calls.
Sending two api calls using the same nonce will result in the subsequent calls returning a status invalid.

Add some other extra salt or use a more granular time value.

In coinspot.py httplib has been deprecated in Python 3.

Recommend changing from:
import hmac
import hashlib
import httplib
import json
import yaml
import os
import sys
import logging
from time import time, strftime

to:
import hmac
import hashlib
try:
import httplib
except:
import http.client
import json
import yaml
import os
import sys
import logging
from time import time, strftime

Tested working in 3.6.2

As pointed out by http://www.reddit.com/user/helix09 there should be a way to request only specific coin detail for any API call that currently returns multiple coin result data.

balances()
myorders()
spot()