The class4js from gedbac

Fields has to be marked not enumerable if they are defined in constructor

var DieselEngine = function (hp) {
this.__hp = hp;
Object.defineProperty(this, '__hp', { enumerable: false });
Object.seal(this);
};

Implement '$package' keyword

$package - it will create new scope which will be integrated to given namespace:

class4js.Package.create(namespace: String, scope: Object): void

or

$package(namespace: String, scope: Object): void

Example

$package("class4js.utl", {
  MyClass: $class({
    // ...
  })
});

Property's 'get/set' notation has to be supported

Example:

var Component = $class({
  get name () {
    return this.__name;
  },
  set name (value) {
    this.__name = value;
  }
});

$init keyword description should be added to documentation

Method 'equals' should be added to created objects

Browser compatibility table should be added to class4js.com website

Such case doesn't work: $abstract_class({ ...}, IDisposable)

Method 'removeAllEventListeners' doesn't works

Proxies should be implemented

Proxies should be declared by using $proxy keyword.

Implement object initializer

var person = Activator.create(Person, { name = "petras", age = 30 });

Static property with null value can't be added

Method 'removeEventListener' crashes

Wrong line:
var index = this.__listeners.indexOf(listener);

Should be:
var index = this.__listeners[type].indexOf(listener);

Proxy documentation should be included

Type checking using $is keyword should be improved

var Shape = $class({ ... });
var Rectangle = $class({ ... }, Shape);

var rec = new Rectangle();

$is(rec, Shape); // This statement should return true

Method 'hash' should be added to created objects

Implement '$enum' keyword

var Priority = $enum({
Low: 0,
Normal: 1,
Hight: 2
});

Enum field's name should be in uppercasing

Only child's and parent's method constructor is invoked

Type checking method can not handle value types

Example: 'toString' in 22

Method 'fire' support only anonymous options object

  Doesn't work:

  var confirmedEvent = new loaddex.visual.common.Event({ cancelable: true });
  this.fire('confirmed', confirmedEvent);
  if (!confirmedEvent.isDefaultPrevented) {
    this._goBack();
  }

When instantiating derived class with options for properties, property setters are being called after each constructor

Event documentation should be included

Interface 'IConfigurationSection' should be included

'toString' method should be added to TypeException

Events should be implemented

Events implementation should be moved from util4js to class4js module. Events implementation also should be adapted to Node.js.

Implement '$import' keyword

$import - it will create new scope and will import members from other scopes to thew newly created scope:

class4js.Package.import(dependencies: Array, scope: Function): void

or

$import(dependencies: Array, scope: Function): void

Example

$import(["class4js", "util", "io"], function () {
  // ...
});

Functions $init and $create should form with anonymous types

Keyword reference table should be added to documentation

Implement '$package' keyword

$package - it will create new scope which will be integrated to given namespace:

class4js.Package.create(namespace: String, scope: Object): void

or

$package(namespace: String, scope: Object): void

Example

$package("class4js.utl", {
  MyClass: $class({
    // ...
  })
});

Arguments supprt to module creation should be added

Example:

var util = $module([window], function (exports, global) {

exports.Exception = ...

});

Method _super has different scope

Implement Interface class

Implement Interface class which will allow to use contract approach in JavaScript

Shortcut function '$extension' should be added for function class4js.Class.addExtension

Code formatting should be fixed

var TypeException = function (message) {
this.__name = "TypeException";
this.__message = message;
} <-- here

create: {
value: function (properties, parent, interfaces) {
var constructor = function () {
if (Class.__extensions && Class.__extensions.length > 0) {
for (var i = 0; i < Class.__extensions.length; i++) { <-- here

instanceOf: {
value: function (source, target) {
if (source && target) {
if (typeof target === "object") {
for (var propertyName in target) {
if (!(propertyName in source)) {
return false;
}
}
} else if (!(source instanceof target)) {
return false;
}
return true;
} else {
throw new TypeException("Source or target is not set");
}
return false; <-- here
},

exports.Interface = Interface <-- here

gedbac / class4js Goto Github PK

class4js's People

Contributors

Watchers

class4js's Issues

Recommend Projects

Recommend Topics

Recommend Org