Implementing Actions about godot-open-rpg HOT 5 CLOSED

Might be good to define commands as a resource type that you can attach to things. This could allow you to more easily define commands that can be shared across multiple types, such as items that can cast magic for characters who can't typically use magic, as well as define monster AI rules that allow them to select their move from a provided list of commands.

from godot-open-rpg.

Agreed with @nhydock ! Attack is already a CombatAction, and there's a base class to use for actions in general. I'm not sure how to best implement each specific action so suggestions welcome.

I would definitely have skills and items as Resources. I would also have the element hold a method that does the action. E.g. for a HealingPotion:

func use(target):
    # healing code and checks
    target.stats.health += HEALING_POWER

It makes sense for the potion itself to heal or the lightning strike to damage the opponent. Although there may be shortcomings to this approach I can't see now.

from godot-open-rpg.

FYI I'm working on this issue

from godot-open-rpg.

@MarianoGnu I was looking at this this morning as well to spruce up how skills are implemented and have some ideas. Will push up some code to my fork in a few hours if you want to have a look at what I was thinking.

from godot-open-rpg.

@nhydock already created the PR, take a look if it's mor or less what you was thinking of.

from godot-open-rpg.