gdpelican / babble Goto Github PK

Hi !

I don't know why, but I get a 422 when I try to add a message to chat.

POST http://xxx/babble/topics/117/post 422 (Unprocessable Entity)

I get the error message "Could not save that port. Try again later" in Babble. However, the post is created in the topic, and a page refreshing update correctly Babble.

Do you have an idea ?

Currently a user who logs in infrequently will see a count of all the chats since they last logged in. This can be in the hundreds... This is a meaningless and intimidating number to a user who hasn't discovered the feature yet.

Even when they finally view the chat window, they can only see the last 20 or so chat messages. The last post might be several days old. Telling them about hundreds of unviewable and/or stale messages is pointless.

I propose to clear all chat notifications older than 24 hours. This will prevent a buildup over time.

Alternatively, reset the counter to zero when the user logs in after a long time gone. Then when a "1" appears, it will make a visual impact.

It does not seem to work out of the box, anyways it should trigger notifications on its own. Make it configurable.

When someone posts in the chat thread, two things happen: Babble displays the notification badge, and Discourse notifies about new or unread posts. This is confusing… However, I think this should be handled in core Discourse: hidden topics should not push notifications, because clicking on the banner results in: nothing.

(sorry - I seem to click every button available around here. It's getting better now, I hope. ;) )

cf.: https://meta.discourse.org/t/non-staff-receive-notifications-of-unlisted-topics/24276/7 - I guess we should try to revive that discussion over there…

First: great work on the 0.4.0 release!

Minor nitpicking: the Ctrl+Enter functionality (which is great, btw - and my team has just yesterday started to complain that you cannot insert line breaks but for
s) does not work for Firefox. This is simply due to the fact that Firefox does not convert Ctrl+Enter or Alt+Enter into line breaks when handling input (unlike Safari or Chrome).

I will send a PR for a very basic fix: allow Ctrl, Alt and Shift as modifiers to let a keycode 13 pass through. The great thing about that would be: it allows users to stick to the habits of their favourite browsers.

I am getting babble posts showing up in my email digest, which is weird. I see 2 possible ways of fixing this: i) force exclusion of the babble post from digest. ii) provide a setting (checkbox) that filters out all posts from designated babble category from the digest.

Currently the id of the created Babble::User is hardcoded to -2, which is a little bit safe but not that safe. We should extract this to a hidden site setting, per the suggestion here

Would be posible add a "sound" to notification new messages? With mute option of course.

the menu icon is missing, so zero functionality.
https://meta.discourse.org/t/babble-a-chat-plugin/31753/127

When creating a new channel, the Channel Title must meet all the requirements of a topic title - min length, min entropy, prettify, no duplicate topics, etc.

It would make sense to bypass the usual restrictions for a chat title. "Live Chat" for example is too short to meet the default 15 char minimum.

If the title is not acceptable, the only error given is "Unable to save that chat channel. Please try again." This is too generic, it can indicate any number of problems with the plugin.

Either:

• bypass the usual title requirements
• show more descriptive errors
• have an error log somewhere

I think that large topic could low performance and database. I think that babble should delete the last messages, not "mark as deleted", delete from database.

Maybe keep the 200 last messages?

... and that's annoying as heck.

and UI Elements for Chat switching appear...

Some are bad, others not so much. Here's Firefox (worst, <1mi
n is just ugly), Safari and Chrome (Opera looks alike):

Is this required: https://github.com/gdpelican/babble/blob/master/assets/javascripts/discourse/templates/header.hbs

Should we add plugin outlet to Discourse?

https://dl.dropboxusercontent.com/u/60760072/ShareX/2015/08/2015-08-26_13-49-20.mp4

I'm not sure if the dropdown not being able to resize is intended or not, but if it is not then the text area should not be able to be resized either. Maybe only allow vertical resizing for the dropdown and text area?

Typing ':' in the composer should pop up an emoji picker, same as the regular Discourse composer

After a massive chat session yesterday, one of my team colleagues (who missed the session) mentioned that the notification stated a very high number of unread chat messages - but the number of messages visible in Babble was much lower. We should introduce a max() here…

We want to default this to the bullhorn icon, so that chat topics show up looking like chat topics to staff members

Something's up with the CSS on the chat channel title. Desktop is not affected, only mobile. It's positioned lower than it should be and overlaps with the text area. When scrolling this frequently means overlapped text.

I don't think its a text overflow problem. Even short channel names such as "chat" are affected.

See screenshot:

Unfortunately, I don't really have a clue on how to tackle this, but I thought I'd report it anyway: if you try to use the shoutbox from a mobile phone, you will most likely end up with the on-screen keyboard hiding the input box. Furthermore, you cannot scroll up, so you basically have to type your shout text blindly.

Tested this on an Android device, I don't know about iOS.

I just gave the fix-this-thing branch a spin on the latest Discourse - with very odd results. Before Babble is active, everything's fine. After installing, the system notification looks like this:

...because there's a .d-header .icons .unread-private-messages style definition with a ridiculous left:82px; - I don't have any clue where this might come from. Just wanted to post my findings… :(

Just got a report of a '-31' notification count appearing on the babble icon

A quick patch would be to ensure that we never display a negative number, but I'm more interested in why that number would ever be negative. The code for calculating it looks like this:

    var totalUnreadCount = topic.highest_post_number - topic.last_read_post_number
    var windowUnreadCount = _.min([totalUnreadCount, topic.postStream.posts.length])

which means that topic.highest_post_number < topic.last_read_post_number, which currently in my brain == wtf

After few hours with this plugin I see huge bottleneck: Discourse environment. There should also some communication layer that would be substituted with an adapter for offline testing.

Something example: https://github.com/gamedevpl/gamedev-chat/tree/master/tests

• simple nodejs server
• adapter code substitutes production code

This will be extremely useful for working on UI/UX. It will also help with running tests for UI.

The height in mobile is not correct.

The textarea is over the last mensaje.

Instead of hard coding string values (such as 'Send', and the placeholder message suggested in #9), we should be hooking into Discourse's client-side I18n so the strings can be translated.

Here's how Babble looks like in Firefox ESR 17 (I know… but Discourse has a minimum spec of FF 14):

(Happens only when the browser window is relatively small and spans the whole browser height…)

This is an issue I only came across in Safari:

These disappear after a reload, the generated HTML reads as follows:

<span class="relative-date" title="Invalid date" data-time="NaN" data-format="tiny">Invalid date</span>

…looks like this:

…will send a PR (one-liner).

Tried pasting an image for the first time yesterday. I like that the width is scaled, but it doesn't seem to scale the height accordingly? In short: the aspect ratio looks way off to me:

A horizontal slider/scroller also cropped up after pasting the image.

First of all, congratulations for this release - this is great stuff!

I have found one inconsistency: if a user has insufficient rights to read a chat topic, they should not get the topic switcher or the topic name in the list of chat topics. They cannot click into that chat, however, but they should not see that list in the first place.

Probably by floating the current user's messages to the right, and perhaps applying some different styling to those messages, a la FB messenger, tinder, whatsapp, etc.

I'd like to make this configurable, with a default of 'off' (although depending on how good it looks I might be convinced to default it to 'on')

This will require a touch of design; if you're thinking to pick this up, I'd love to see a rough sketch of what you're thinking before implementing 😄

Currently, submitting a message causes an unread '1' to briefly appear on the bullhorn, then disappear once the post is deemed 'read'

Ideally we'd know that a post coming back from MessageBus is written by the current author and treat it as automatically read.

Expected behavior: when someone posts a chat message, it should either instantly show in the chat message list (which is working) or it should display a badge on the bullhorn icon like so:

Actual behavior: the chat message list updates all right, but if it's closed, the notification badge only displays if you reload the site.

Currently, creating a topic starts the user out with just a composer, and no indication of what the heck this thing is.

I'd like to have some sort of placeholder message there to tell the user 'This chat channel is empty. Type in a message below to get started!'

I've just updated my site (via full rebuild) to v1.5.0.beta7 +3 and now the babble icon is no longer visible. The plugin is enabled and working in so far as settings are concerned, but there is no interface for it now.

Many chat clients support some window of self-editing functionality; I imagine it'd be nice to type something, hit the 'up' key, and be able to edit your last post for some short amount of time after it's posted.

Add a new admin setting to customize the tooltip string. It currently displays "Shoutbox!" which is not very useful for users.

Hi y'all... I'm back. And currently, I'm trying to catch up with all the great stuff you did while I was away. Currently, I'm running into this:

[Error] Error: Could not find module `discourse/mixins/presence` imported from `discourse/plugins/babble/discourse/components/babble-composer`
    end (vendor-2e72f89b7b393cd8eb92fe563e177473.js, line 11)
    (anonyme Funktion) (vendor-2e72f89b7b393cd8eb92fe563e177473.js, line 11)

…any ideas?

…yeah; I do! ;)…:

Addition 1: must have been this here on the mothership: discourse/discourse@02a968b
(I wonder when Discourse is really stable enough to really code plugins… sigh)
Addition 2: can be closed by applying this: #22

...although the button is disabled - enter works.