gdamore / encoding Goto Github PK

The NewDecoder and NewEncoder APIs changed in golang's x/text/encoding package. They now return pointers to new structures, *encoding.Decoder and *encoding.Encoder, each of which have only a named transform.Transformer member.

I have no idea why they made these changes, but the API breaks encoding and all consumers catastrophically.

Shame on the golang folks for breaking this API.

http://goreportcard.com/report/gdamore/encoding found a bunch of issues.

The names for the ISO88859_1 and ISO8859_5 variables cannot change, but the other issues can be resolved.

When Im trying to enc.EBCDIC.NewDecoder().String(string(rec2)) I get

The square boxes should be spaces. Here is the desired output.

Even when I copy the boxes into a text editor they get translated to spaces. I cant do string parsing on such characters. It would be amazing if you could guide me into the right direction.

Update: The byte array I'm receiving:
[0 0 0 198 195 240 240 240 240 240 241 195 228 214 214 0 0 0 0 0 0 0 0 241 243 249 246 240 249 242 247 241 240 244 246 245 242 240]

The boxes are these zeroes...

Thanks for the amazing package.