gbif-cli

The gbif-cli shared library provides:

Base classes based on JCommander used by GBIF command-line interface projects/modules

To build the project

mvn clean install

gbif-cli's People

Contributors

Watchers

gbif-cli's Issues

Updating jcommander from 1.60 to 1.72 causes tests to fail

While working on #1, I attempted to update jcommander from 1.60 to 1.72, but that caused tests to start failing with messages like the following (note the Java-9 module references "java.base/...", but 1.60 otherwise seems to work fine using Java-9):

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.871 s <<< FAILURE! - in org.gbif.cli.converter.ConverterFactoryTest
[ERROR] testUUID(org.gbif.cli.converter.ConverterFactoryTest)  Time elapsed: 0.761 s  <<< ERROR!
org.gbif.cli.CommandException: Error during command line parsing
	at org.gbif.cli.BaseCommand.processCommandLineParameters(BaseCommand.java:145)
	at org.gbif.cli.BaseCommand.run(BaseCommand.java:120)
	at org.gbif.cli.converter.ConverterFactoryTest.testUUID(ConverterFactoryTest.java:15)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:563)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143)
Caused by: com.beust.jcommander.ParameterException: Expected a value after parameter --conf
	at com.beust.jcommander.JCommander.processFixedArity(JCommander.java:886)
	at com.beust.jcommander.JCommander.processVariableArity(JCommander.java:859)
	at com.beust.jcommander.JCommander.parseValues(JCommander.java:705)
	at com.beust.jcommander.JCommander.parse(JCommander.java:340)
	at com.beust.jcommander.JCommander.parse(JCommander.java:319)
	at org.gbif.cli.BaseCommand.processCommandLineParameters(BaseCommand.java:141)
	... 26 more
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   BaseCommandTest.testIllegalFile »  Unexpected exception, expected<org.gbif.cli...
[ERROR]   BaseCommandTest.testIllegalFileName »  Unexpected exception, expected<org.gbif...
[ERROR]   BaseCommandTest.testJsonConfigFile:32 » Command Error during command line pars...
[ERROR]   BaseCommandTest.testTwoConfigFiles:40 » Command Error during command line pars...
[ERROR]   BaseCommandTest.testYamlConfigFile:24 » Command Error during command line pars...
[ERROR]   ConverterFactoryTest.testUUID:15 » Command Error during command line parsing
[INFO] 
[ERROR] Tests run: 20, Failures: 0, Errors: 6, Skipped: 1