Code Monkey home page Code Monkey logo

fish-exa's Issues

Preserve user settings in universal variables

  1. I think it's better to skip erasing user settings in universal variables, as it's a expected behaviour for the most software:
    function __fish_exa_uninstall --on-event fish-exa_uninstall

We should only erase private variables prefixed with _.
What do you think?

  1. Another thing, it's probably better to check if a user setting in universal variable exist before rewriting it: https://github.com/andreiborisov/sponge/blob/main/conf.d/sponge.fish Otherwise, you can possibly write on top of existing user configuration (for example, when the user transferred universal variables via dotfiles and setting up a new machine, variables will exist before the plugin installation in that case).

`lt` alias doesn't work

It appears lt alias doesn't work:

$ lt 2
"2": No such file or directory (os error 2)

While exa --long --all --group --header --tree --level 2 works fine.

Question on aliases

I'm new to the fish/fisher ecosystem, and have a newbie question:

If I install this, I should have access to the aliases without additional configuration; correct?

If I don't, why might that be?

fisher update removes aliases from current shell

After having installed fish-exa using fisher running a "fisher update" will remove the aliases (e.g. ll) for that shell. This only affects the shell that ran the update command - closing and reopening fixes the issue.

Might just need the aliases at the top of the conf/fish-exa.fish file to be pulled into the install function, but there may have been a reason for it being outside :)

Improve the default arguments values

I have noticed some mistakes in the default set of options, listed below.

We should update them if you agree. Documentation to exa.


EXA_LD_OPTIONS

Current: --list-dirs

Improvement: --only-dirs instead of --list-dirs

Justification

--list-dirs does not list all directories. I only see the . directory.
image


EXA_STANDARD_OPTIONS

Current: --long --all --group --header

Improvement: remove --all --long

Justification

Both --all should be part of la and --long of ll respectively. Otherwise they do not behave any differently.

With standard options we want it to behave like a standard ls/exa with minor or common shared UX improvements arguments.

EXA_LE_OPTIONS will need to updated to include --long if we update standard options.

Opinionated Options

It depends on peoples preferences so there is a reason to keep the default options shipped with this plugin to be as little as possible and generally accepted by majority.

Here are some of these options:

  1. --group-directories-first Useful as it adds another layer of sorting

EXA_LL_OPTIONS

Current: none

Improvement: add --long

Justification

Once we remove this from standard options we will require it here for long output. This seems more appropriate for the option.


EXA_LA_OPTIONS

Current: --binary --links --inode --blocks

Improvement: add --all

Justification

Once we remove --all we need to add it here to show all files for this command.

It include some options that can be removed as they're not commonly used:

  1. --inode: Barely anyone looks at the inode number for a file
  2. --blocks: Human readable file size is already shown, so it's arguable how much this adds.
  3. --links: Most people might not even what this is supposed to mean.

EXA_LG_OPTIONS

Current: --git

Improvement: add --git-ignore

Justification

When you want to list files in a git repo, you need --git-ignore; otherwise you can use any of the other options to list all files.

--git only works with --long option so if we remove it from standard options we need to add it here too. Though that can also be left for user to decide.


Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.