gatech-eic / nerfool Goto Github PK

Hi, thank you for your great work!
I am looking forward to trying out your excellent work, and I was wondering when the codes will be released.
Thank you!

First of all, thank you for open sourcing the interesting work!
While I was trying out some experiments, I had a question on line https://github.com/GATECH-EIC/NeRFool/blob/main/train.py#L158.

I think this line should be replaced with

featmaps = model.feature_net((ray_batch['src_rgbs']+delta).squeeze(0).permute(0, 3, 1, 2))

these two lines

ray_batch['src_rgbs'] = ray_batch['src_rgbs']+delta
featmaps = model.feature_net(ray_batch['src_rgbs'].squeeze(0).permute(0, 3, 1, 2))

the reason is since the rendering is an image-based rendering (at least for IBRNet) where queried xyz radiance value is a combination of the source image projected pixel values? Since the source images are perturbed, the rendering should be based on the perturbed image itself. Let me know if this makes sense and what do you think?