gastonrobledo / handlebars-async-helpers Goto Github PK

If we use each for an array of objects and wants to access values outside that array of object, then this will throw an error, stating that the property is undefined. E,g, in my case I have the following object, which is causing an issue

{ valueToAccess: "test", arrayOfObjects: [ {name: "Tom", ...}, {name: "Jerry", ...}, ...] }

Taking the above example, we use the following code in the handlebar, but it will not let us access the value.
{{#each arrayOfObjects}} {{name}} is trying to access the value {{valueToAccess}}, which will return undefined instead of test. {{/each}}

Using Handlebar for Vue application. Since we need some async call from the template itself. This repo is not compatible with Vue/javascript since the require is not defined . Is there any way to achieve it in Vue.

According to the readme, it is required to use the patched handlebars variable:

const handlebars = require('handlebars'),
      asyncHelpers = require('handlebars-async-helpers')

const asyncHandlebars = asyncHelpers(handlebars)
const template = asyncHandlebars.compile('123');
const rendered = await template({});

Anyway, to my testings it seems like this is not required, as even the original handlebars is now patched:

const handlebars = require('handlebars'),
      asyncHelpers = require('handlebars-async-helpers')

asyncHelpers(handlebars)

const template = handlebars.compile('123');
const rendered = await template({});

May you confirm? I wonder what method would be the best. By using handlebars at least we have type checking but compile() is not a Promise.

Hello, I really appreciate your work but I wonder what the purpose of this library is over LoicMahieu/handlebars-async. Is there anything missing or not working in the other library? Or does this library make anything better than the other?

Btw. there is a typo in your readme, it says npm install handlerbars-async-helpers instead of npm install handlebars-async-helpers

Handlebars contains TypeScript typings which totally get lost by using this module. Could you add typings that extend handlebars?

Hi there, first off thanks for throwing this together -- it has been quite handy for the project I am currently working on.

I noticed some unexpected behaviour / perhaps a bug -- it seems that while you can have helpers that return async values and the template will render correctly, async values in the context are hit and miss. For example, this works:

const ctx = { somePromisedValue: Promise.resolve('yup') };
const template = handlebarsWithAsync.compile('{{ somePromisedValue }}');
console.log(await template(ctx));
// output = yup

However, if I try and make use of nesting:

const ctx = { somePromisedValue: Promise.resolve({ v: 'yup' }) };
const template = handlebarsWithAsync.compile('{{ somePromisedValue.v }}');
console.log(await template(ctx));
// output = 

It looks like this is a simple fix; I was able to get it working by shimming container.lookupProperty similarly to how you have shimmed escapeExpression. I'll open a PR shortly with a fix and additional tests.

Thanks!

Using Handlebar for Jquery application. Since we need some async call from the template itself. This repo is not compatible with jquery/javascript since the require is not defined . Is there any way to achieve it in jquery.

This error appears to happen when empty sources are passed to the each helper that is overriden by this library.

It's this line that crashes :

The problem is that when the items count is 0, options.inverse() is called on the context and replaces the return value.
But by default, when each has no else condition, it's a noop that does not return an array but an empty string, making ret.join() crash.

Handlebars does not have this problem because they don't have to join : https://github.com/handlebars-lang/handlebars.js/blob/785a63e0a84bc5d6617fd1619baa975f1380ddbd/lib/handlebars/helpers/each.js#L80

This solution works, for example:

Using inline partial as shown here I get an error:

Error: The partial myPartial could not be found

It works if I use the regular handlebars object instead.

Code:

const handlebars = require('handlebars'),
    asyncHelpers = require('handlebars-async-helpers')
const hb = asyncHelpers(handlebars)

hb.registerHelper('sleep', async () => new Promise((resolve) => {
    setTimeout(() => resolve('Done!'), 1000)
}))

async function main() {
    const template = hb.compile(`
    {{#*inline "myPartial"}}
      {{firstname}}
    {{/inline}}
    {{#each people}}
      {{> myPartial this}}
    {{/each}}
    `);
    const result = await template({
            people: [
                {firstname: "Nils"},
                {firstname: "Yehuda"},
            ],
        }
    );
    console.log(result);
}

main();