Code Monkey home page Code Monkey logo

vpa-exporter's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

vpa-exporter's Issues

[BUG] Incorrect reporting of metrics for deleted VPA resources

Describe the bug:
For the deleted VPA resources, that last recorded metrics are continued to be reported unless the vpa-exporter is restarted.

Expected behaviour:
Metrics should not be reported for VPA resources after they are deleted.

How To Reproduce (as minimally and precisely as possible):

  1. Deploy vpa-exporter and a sample VPA resource.
  2. Verify the metrics reported by vpa-exporter for the deployed sample VPA resource.
  3. Delete the sample VPA resource.
  4. Verify the metrics reported by vpa-exporter for the deleted sample VPA resource.

Logs:

Screenshots (if applicable):

Anything else we need to know?:

Reduce log volume

Feature (What you would like to be added):
Currently the vpa-exporter is logging as info

I0101 01:02:03.123456       1 main.go:241] Successfully synced 'shoot--project--shoot/*-vpa'

The problem is that in relatively small seed cluster, there are too much such logs:

$ kubectl -n garden logs vpa-exporter-57478fc75d-g4jfd --since 10m | grep 'Successfully\ synced' -c
2898

Motivation (Why is this needed?):
To reduce the volume of debug logs

Approach/Hint to the implement solution (optional):
Switch the debug level for these log messages to Debug.

Add message about favoring kube-state-metrics

Feature (What you would like to be added):
Add message about favoring kube-state-metrics

Motivation (Why is this needed?):
I see that it is mentioned that this is being deprecated in favor of kube-state-metrics, however it's not clear currently whether this is the case by reading the documentation. My initial search for such exporter brings me to here and I couldn't find this collector in kube-state-metrics at first.

Approach/Hint to the implement solution (optional):
If it is indeed being deprecated, could we have some banner in the README suggesting others to enable the vpa collector in kube-state-metrics instead?

[Feature] Release a container image for vpa-exporter

Feature (What you would like to be added):
Release a container image for vpa-exporter as part of release assets.

Motivation (Why is this needed?):
Usually vpa-exporter will be deployed inside a kubernetes cluster. It would be easier for the deployment if there is a container image coming with a release.

Approach/Hint to the implement solution (optional):
This can be done through github Actions along with github container registry ghcr.io.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.