garbageplanet / frontend Goto Github PK

View Code? Open in Web Editor NEW

1.0 3.0 2.0 21.18 MB

Frontend for Garbagepla.net

Home Page: https://garbagepla.net

License: Other

JavaScript 58.85% CSS 10.49% HTML 30.67%

leaflet bootstrap3 frontend webapp jquery webmaps

frontend's Introduction

README

What is this repository for?

Repository for the garbagepla.net frontend.

How to get started?

Run npm i to install gulp and dependencies in the root directory and type gulp to compile templates and build the app. Note that if you do not have your own token for Mapbox and other external APIs you won't be able to build properly. Tokens are set in an .env file as follows:

IMGUR_TOKEN=<imgur api token>
MAPBOX_TOKEN=<Mapbox.com map tiles api token>
WINDOW_TOKEN=<laravel backend app token>
OC_TOKEN=<Opencage geocoder api token>
OG_TOKEN=<Opengraph scraper api token>
SERVER=<the url to the app backend, see the garbageplanet/api repo>
ROOT=<the root url of your app>
PRODUCTION=<boolean>
GA=<google analytics token (optional)>

Contributing

If you want to contribute to a specific todo/fixme below, the first thing you should do is open an issue. If you have another contribution PRs are also welcome.

Improvements

Also look at TODO.md

Licence

This code is available under the ISC licence but some parts have a different license information, see this file.

frontend's People

Contributors

Stargazers

Watchers

Forkers

feri villeglad

frontend's Issues

Reinitializaiton of multi selects fail on mobile

When creating one marker, the multiselect work fine. When creating another one, the multiselects aren't initialized in the forms anymore.

iOS

anything on iOS, don't work.

Current FIXME, Nov. 2016

fix search bar collapse on submit (map catches a click form the enter/submit event and collapses the control)
fix L.Control.Layers collapse on map click (map still catches clicks when control is expanded)
remove unsaved marker icons once maker is saved
fix marker creation when multiple unsaved marker are present on map
bootstrap form validation - disallow submit button until ok (currently only add class disabled to submit button)

Facebook image integration

Allow users to paste in Facebook image code.

Internet explorer on Lumia 620 search box bug

The text of the address search results aren't removed after selecting a location in the list.

Allow to drag point markers before saving

add L.Draggable() to generic-marker when side panel is open.

Chrome for Android: cannot use space to create tags in forms

Tags cannot be created by pressing space on soft keyboard, this is a feature on Chrome Android, currently solved in unstable version of Chrome (March 2016).

Edge on Windows Phone

There is a weird map panning behavior when creating markers.

img-responsive in #bottombar

Image size doesn't respect the size of the parent div (col-lg-3etc) in the bottom panel. Adding the bootstrap3 class img-responsive to the <img> tag in the bottom panel doesn't help either.

Change the behavior of .on('click') when panels are open

It's currently possible to create a new marker by clicking on the map when either of side or bottom panels are open. The default behavior should catch the clicks going to the map when a panel is open and do something smarter than creating another marker, like closing the panel.

panTo(marker) when side or bottom panels are open

Currently, the map pans correctly to the clicked latlng or to the clicked marker. However, if either of the panels are already open, the map will pan to the center of the viewport. It should pan to the center of the remaining space. The behavior needs to be corrected either in L.Control.Sidebar.js and L.control.bar.js or by using invalidateSize() when a click occurs and a panel is open.