gangstead / atom-incremental-search Goto Github PK

View Code? Open in Web Editor NEW

16.0 16.0 13.0 75 KB

Incremental search for the Atom editor

License: MIT License

CoffeeScript 94.52% CSS 5.48%

atom-incremental-search's People

Contributors

Stargazers

Watchers

Forkers

pariser drogar keathley mbriggs t9md afinne denispostu vjchem pkhpkh craiglyons greenasjade flashios09 pbgc

atom-incremental-search's Issues

Each search leaves a permanent bar at the bottom of the screen

Each of the bars at the bottom of the screen was caused by one use of incremental-search.

I haven't worked out a way to make them go away yet.

Cmd-I toggles between results but Enter doesn't work

When I search cmd-I toggles between the chosen text, but pressing enter doesn't do anything. The only option is to ESC. Atom 0.200

Uncaught Error: This TextEditor has been destroyed

[Enter steps to reproduce below:]

Press CTRL-I a couple of time with no selection

It does seem somewhat erratic on Atom using Xbuntu 14.10. Hope this helps :)

Atom Version: 0.187.0
System: linux 3.16.0-31-generic
Thrown From: incremental-search package, v4.2.0

Stack Trace

Uncaught Error: This TextEditor has been destroyed

At /usr/share/atom/resources/app/src/display-buffer.js:1005

Error: This TextEditor has been destroyed
  at DisplayBuffer.module.exports.DisplayBuffer.screenPositionForBufferPosition (/usr/share/atom/resources/app/src/display-buffer.js:1005:15)
  at DisplayBuffer.module.exports.DisplayBuffer.screenRangeForBufferRange (/usr/share/atom/resources/app/src/display-buffer.js:870:20)
  at Marker.module.exports.Marker.getScreenRange (/usr/share/atom/resources/app/src/marker.js:173:33)
  at SearchModel.module.exports.SearchModel.moveToClosestResult (/home/bonney/.atom/packages/incremental-search/lib/search-model.coffee:217:55)
  at SearchModel.module.exports.SearchModel.findNext (/home/bonney/.atom/packages/incremental-search/lib/search-model.coffee:205:6)
  at InputView.module.exports.InputView.trigger (/home/bonney/.atom/packages/incremental-search/lib/input-view.coffee:117:20)
  at Object.module.exports.findPressed (/home/bonney/.atom/packages/incremental-search/lib/isearch.coffee:35:16)
  at atom-workspace.<anonymous> (/home/bonney/.atom/packages/incremental-search/lib/isearch.coffee:14:90)
  at atom-workspace.handler (/usr/share/atom/resources/app/src/space-pen-extensions.js:115:32)
  at atom-workspace.jQuery.event.dispatch (/usr/share/atom/resources/app/node_modules/space-pen/vendor/jquery.js:4681:9)
  at atom-workspace.elemData.handle (/usr/share/atom/resources/app/node_modules/space-pen/vendor/jquery.js:4359:46)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/src/command-registry.js:246:29)
  at /usr/share/atom/resources/app/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/usr/share/atom/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:558:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:396:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/usr/share/atom/resources/app/src/window-event-handler.js:182:20)

Commands

     -3:41.1 find-and-replace:show (atom-text-editor.editor)
     -3:38.7 core:confirm (atom-text-editor.editor.mini)
     -3:29.7 incremental-search:forward (atom-text-editor.editor)
     -3:28.3 find-and-replace:show (atom-text-editor.editor.mini.is-focused)
     -1:48.3 editor:newline (atom-text-editor.editor)
     -1:44.9 core:backspace (atom-text-editor.editor)
     -1:22.8 core:copy (atom-text-editor.editor)
     -1:20.2 core:paste (atom-text-editor.editor)
  2x -0:29.8 find-and-replace:show (atom-text-editor.editor)
     -0:15.2 project-find:toggle (div.isearch.tool-panel.panel-bottom.padded)
  2x -0:01.3 incremental-search:forward (atom-text-editor.editor)

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ]
  }
}

Installed Packages

# User
incremental-search, v4.2.0

# Dev
No dev packages

Uncaught Error: destroyTooltip is no longer available. Please dispose the object returnedfrom `atom.tooltips.add` instead.See the docs at https://atom.io/docs/api/latest/TooltipManager#instance-add

[Enter steps to reproduce below:]

Hit Cmd-i
Type something
Hit enter

Atom Version: 0.204.0
System: Mac OS X 10.10.3
Thrown From: incremental-search package, v4.4.0

Stack Trace

Uncaught Error: destroyTooltip is no longer available. Please dispose the object returned
from atom.tooltips.add instead.
See the docs at https://atom.io/docs/api/latest/TooltipManager#instance-add

At /Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-space-pen-views/node_modules/space-pen/lib/space-pen.js:615

Error: destroyTooltip is no longer available. Please dispose the object returned
from  `atom.tooltips.add` instead.
See the docs at https://atom.io/docs/api/latest/TooltipManager#instance-add
  at [object Object].$.fn.destroyTooltip.$.fn.hideTooltip (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-space-pen-views/node_modules/space-pen/lib/space-pen.js:615:11)
  at InputView.module.exports.InputView.hideAllTooltips (/Users/exalted/.atom/packages/incremental-search/lib/input-view.coffee:61:24)
  at InputView.module.exports.InputView.detach (/Users/exalted/.atom/packages/incremental-search/lib/input-view.coffee:90:6)
  at InputView.module.exports.InputView.stopSearch (/Users/exalted/.atom/packages/incremental-search/lib/input-view.coffee:135:6)
  at space-pen-div.<anonymous> (/Users/exalted/.atom/packages/incremental-search/lib/input-view.coffee:31:50)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:238:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:520:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:355:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:178:20)

Commands

     -0:30.7.0 core:move-down (atom-text-editor.editor.cursor-block.cursor-line-fix.is-focused)
     -0:30.4.0 editor:newline (atom-text-editor.editor.cursor-block.cursor-line-fix.is-focused)
     -0:28.8.0 core:move-to-bottom (atom-text-editor.editor.cursor-block.cursor-line-fix.is-focused)
  2x -0:28.2.0 pane:show-next-item (atom-text-editor.editor.cursor-block.cursor-line-fix.is-focused)
     -0:12.5.0 core:move-to-top (atom-text-editor.editor.cursor-block.cursor-line-fix.is-focused)
     -0:12.2.0 incremental-search:forward (atom-text-editor.editor.cursor-block.cursor-line-fix.is-focused)
  2x -0:10.8.0 core:backspace (atom-text-editor.editor.mini.is-focused)
 16x -0:08.9.0 incremental-search:forward (atom-text-editor.editor.mini.is-focused)
     -0:05.4.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:05.4.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -0:04.9.0 editor:move-to-first-character-of-line (atom-text-editor.editor.mini.is-focused)
     -0:04.9.0 core:move-to-top (atom-text-editor.editor.mini.is-focused)
     -0:03.9.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:03.9.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -0:03.0 incremental-search:forward (atom-text-editor.editor.mini.is-focused)
     -0:02.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "ignoredNames": [
      ".git",
      ".svn",
      ".DS_Store"
    ],
    "disabledPackages": [
      "markdown-format",
      "syntax-settings",
      "autocomplete",
      "deprecation-cop",
      "autocomplete-paths",
      "archive-view",
      "background-tips",
      "bookmarks",
      "image-view"
    ],
    "projectHome": "/Users/exalted/Development",
    "followSymlinks": true,
    "themes": [
      "atom-light-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
autocomplete-emojis, v2.2.2
block-cursor, v0.12.5
highlight-selected, v0.9.3
incremental-search, v4.4.0
language-csharp, v0.5.0
linter, v0.12.6
linter-coffeelint, v0.2.4
linter-erb, v0.1.1
linter-jshint, v0.1.5
linter-rubocop, v0.2.7
linter-shellcheck, v0.0.8
linter-tidy, v1.0.1

# Dev
No dev packages

Search box loses focus while typing

Versions used:

Atom 0.120.0
Incremental Search 2.2.0

See the attached recording:

Press cmd-i to start incremental search
Type d
Wait a split second
Type o

Expected result: The cursor is still in the search box and the search now contains do

Actual result: The cursor has moved to the editor, overwriting some of the found text.

Am I using this the wrong way? Is there any way I could change this to keep the cursor in the search box?

Behaviour of Enter/Return

In the old version of the incremental search package, Enter would stop the search and leave the cursor at the currently selected instance. It still states so in the keybindings list for Os X:

    return - stop the search and leave the cursor where it is
    esc - cancel the search and return the cursor to where it was before searching

However, the behaviour now is that Enter selects the next instance (just like Cmd-I does). This is also stated in the readme, however, in order to leave the cursor on the currently selected instance, it says:

    "When you've found the text you are looking for, press esc 
    to stop the search and leave the cursor on the search result. 
    To cancel the search and return to where you started, press esc."

I think that the correct behaviour would be that Enter would stop searching and leave the cursor where it should be, while esc cancels searching and returns to where it started. Cmd-I selects the next instance.

Pressing Enter too fast won't find text

Due to the find editor's change event delay, Enter can be pressed before the change event is received.

When Enter is pressed, compare the value of the find editor to the model's pattern. If they differ, perform one more search and select the nearest match.

Uncaught TypeError: this.editSession.getSelection is not a function

[Enter steps to reproduce below:]

install the package
test search (works)
cancel/close search

Atom Version: 1.0.15
System: Mac OS X 10.10.5
Thrown From: incremental-search package, v5.0.1

Stack Trace

Uncaught TypeError: this.editSession.getSelection is not a function

At /Users/ccollier/.atom/packages/incremental-search/lib/search-model.coffee:226

TypeError: this.editSession.getSelection is not a function
  at SearchModel.module.exports.SearchModel.findMarkerForward (/Users/ccollier/.atom/packages/incremental-search/lib/search-model.coffee:226:77)
  at SearchModel.module.exports.SearchModel.moveToClosestResult (/Users/ccollier/.atom/packages/incremental-search/lib/search-model.coffee:211:52)
  at SearchModel.module.exports.SearchModel.updateMarkers (/Users/ccollier/.atom/packages/incremental-search/lib/search-model.coffee:200:6)
  at /Users/ccollier/.atom/packages/incremental-search/lib/search-model.coffee:84:10
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:82:11)
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1271:25

Commands

     -2:21.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)
 23x -2:06.6.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:31.3.0 editor:newline (atom-text-editor.editor.is-focused)
     -0:31 core:paste (atom-text-editor.editor.is-focused)
     -0:27.2.0 core:save (atom-text-editor.editor.is-focused)
  3x -0:26.2.0 incremental-search:backward (atom-text-editor.editor.is-focused)
  3x -0:16.4.0 incremental-search:forward (atom-text-editor.editor.mini.is-focused)
     -0:15.4.0 core:move-up (atom-text-editor.editor.mini.is-focused)
     -0:15.1.0 core:move-down (atom-text-editor.editor.mini.is-focused)
     -0:15 core:move-up (atom-text-editor.editor.mini.is-focused)
     -0:14.9.0 core:move-down (atom-text-editor.editor.mini.is-focused)
     -0:14.8.0 core:move-up (atom-text-editor.editor.mini.is-focused)
     -0:14.5.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -0:04.6.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:04.6.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:01.7.0 editor:newline (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "openEmptyEditorOnStart": false,
    "projectHome": "/projects",
    "themes": [
      "base-16-ocean-dark-ui-theme",
      "base16-ocean-dark-spacegray"
    ]
  }
}

Installed Packages

# User
advanced-open-file, v0.10.0
atom-yeoman, v0.3.13
atomic-emacs, v0.7.3
autocomplete-glsl, v0.2.3
autocomplete-python, v0.5.3
base-16-ocean-dark-ui-theme, v1.5.1
base16-ocean-dark-spacegray, v0.12.0
build, v0.46.0
build-cargo, v0.2.0
build-gradle, v0.2.0
build-make, v0.2.1
expand-region, v0.2.3
incremental-search, v5.0.1
ionide-fake, v1.0.3
ionide-fsharp, v1.1.1
ionide-fsi, v1.0.4
ionide-installer, v1.2.1
ionide-paket, v2.0.7
ionide-yeoman, v1.0.1
language-cmake, v0.1.4
language-rust, v0.4.5
linter, v1.6.0
racer, v0.17.2

# Dev
No dev packages

Key (cmd-e?) to set focus to code editor

Need a key like cmd-e to set focus to the code editor so changes can quickly be made while searching. The search keys cmd-i and shift-cmd-i already refocus the search control.

Add cmd-e to focus code editor
Make sure cmd-i focuses search control but does not move to next result
Ensure code changes destroy the marker - don't move cursor though

Nothing found if you press Enter too fast

There is a delay before the first change event is sent but the Enter (confirm) happens immediately.

So, if you press Enter before the search occurs, nothing will be found. It looks like the simplest solution is to trigger the search on Enter explicitly.

Search breaks when switching tabs

If I leave the panel open when switching tabs, entering new text doesn't search current tab. It is stuck at the old tab.

Add key to "slurp"

Should not return me to previous position on close

When I:

Enter incremental search
Find what I am looking for
Leave the search box via cmd-enter or the mouse
Reenter the search box and close it via escape

Then I:
Am returned to wherever in the document I was before searching

I don't want to leave the search box open at all times, nor do I want to be knocked halfway back up a file because I wanted to close it out.

Mouse click does not cancel search highlights or search engagement

Steps to repro:

Start an incremental search
type one or more letters that have at least one match in the document
mouse click somewhere in the document
note the search bar is closed, but the highlights remain, and incremental search is still engaged.

This isn't a bug per say, but it seems to me that search engagement should match the ui search bar.
If you're not able to address this soon, I'll take a look; just let me know if you think it should be an option rather than the default behavior.

Thanks!

Allow stop search and leave cursor at some place other than initial place or some matched line

Often times I start a search, hit cmd+i couple of times, scroll to a bit and find one line I want to start editing. So I click on that line (which is not the matched line, but probably 2 lines down), I expect a way for me to exit search and stay on that line. So far I haven't found out how. The two ways to exit search either jump back to cursor location before search, or current match location.

More generally, incremental search doesn't play well if I move cursor location, either by scroll and click-to-select, or using vim binding (say gg to go to beginning of file). When I go back to head of file and hit cmd+i again, I expect incremental search to start searching from beginning again. However, incremental search still keep search from the 'matched position', which is kind of confusing.

Uncaught TypeError: Cannot read property 'setBufferPosition' of undefined

Reproduce (on Linux):

Open two tabs
Hit ctrl-i to open toolbar
enter word found on current view
close current tab
Hit escape to close toolbar

Keep options and history between sessions

Need to serialize the model.

Decisions on functionality of this package

As I've looked through the source and documentation and discussions that have been made for this package, I have found that there are two different ways of using incremental search that are "competing" both in the source and in the documentation. I have tried to define the differences here:

Should the search field be initialized with the previous search, or with an empty search?

Currently, the previous search is shown, which interferes with the 'slurp' functionality
2) Should 'Enter' close the search and leave the cursor in the current position, or search for the next instance of the search term?
Currently, the search is closed
3) Should Cmd-I browse through search history, or find the next instance of the current search term?
Currently, it finds the next instance

As I noted these down, I realised that it is the history feature that messes things up. Do we want a search history? Me, personally, use incremental search as a throw-away quick search, so I don't feel the need for a search history.

Initialize search with selected text

If there is a selection, seed the search box with that.

2 deprecations in the last version (as of this moment)

Store package style sheets in the styles/ directory instead of stylesheets/ in the incremental-search package
Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows:

Uncaught TypeError: Cannot read property 'getActiveView' of undefined

[Enter steps to reproduce below:]

CTRL + I
Enter search term
CMD + Enter

Atom Version: 1.3.2
System: Mac OS X 10.11.2
Thrown From: incremental-search package, v5.0.1

Stack Trace

Uncaught TypeError: Cannot read property 'getActiveView' of undefined

At /Users/jasonds/.atom/packages/incremental-search/lib/input-view.coffee:174

TypeError: Cannot read property 'getActiveView' of undefined
    at InputView.module.exports.InputView.focusEditor (/Users/jasonds/.atom/packages/incremental-search/lib/input-view.coffee:174:25)
    at space-pen-div.subscriptions.add.atom.commands.add.incremental-search:focus-editor (/Users/jasonds/.atom/packages/incremental-search/lib/input-view.coffee:40:46)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:536:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:359:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:97:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands

     -0:38.2.0 grammar-selector:show (atom-text-editor.editor)
     -0:37 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:35.9.0 find-and-replace:show (a.inline-block)
     -0:34.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
  4x -0:32.3.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:30.1.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:30.1.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -0:26.9.0 find-and-replace:use-selection-as-find-pattern (atom-text-editor.editor.is-focused)
  3x -0:23.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:20.4.0 find-and-replace:confirm (atom-text-editor.editor.mini.is-focused)
     -0:18.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:13.7.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:13.7.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -0:12.7.0 incremental-search:forward (atom-text-editor.editor.is-focused)
  7x -0:06.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:00.8.0 incremental-search:focus-editor (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "base16-tomorrow-dark-theme"
    ],
    "useReactEditor": true
  }
}

Installed Packages

# User
autocomplete-plus, v2.25.0
color-picker, v2.0.14
csslint, v1.1.4
editor-stats, v0.17.0
emmet, v2.3.17
highlight-line, v0.11.0
incremental-search, v5.0.1
linter, v1.11.3
linter-scss-lint, v2.5.0
pigments, v0.19.5

# Dev
No dev packages

Failed to activate the incremental-search package

[Enter steps to reproduce below:]

Atom Version: 1.0.2
System: Mac OS X 10.10.4
Thrown From: incremental-search package, v5.0.1

Stack Trace

Failed to activate the incremental-search package

At Cannot find module 'atom-space-pen-views'

Error: Cannot find module 'atom-space-pen-views'
    at Module._resolveFilename (module.js:328:15)
    at Function.Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app.asar/src/module-cache.js:383:52)
    at Function.Module._load (module.js:270:25)
    at Module.require (module.js:357:17)
    at require (module.js:376:17)
    at Object.<anonymous> (/Users/rpietro/.atom/packages/atom-incremental-search/lib/isearch.coffee:4:7)
    at Object.<anonymous> (/Users/rpietro/.atom/packages/atom-incremental-search/lib/isearch.coffee:65:4)
    at Module._compile (module.js:452:26)
    at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
    at Module.load (module.js:347:32)

Commands

     -0:00.5.0 incremental-search:forward (atom-text-editor.editor.is-focused)

Config

{
  "core": {}
}

Installed Packages

# User
language-todotxt, v0.6.1

# Dev
No dev packages

Linux slurp keymap is already used

I just want to mention ctrl-e is used by atom find-and-replace and takes precedence over this packages slurp.

Uncaught TypeError: deprecationSite.getFileName is not a function

[Enter steps to reproduce:]

Atom: 1.19.0-beta2 x64
Electron: 1.6.9
OS: Mac OS X 10.12.5
Thrown From: incremental-search package 5.2.2

Stack Trace

Uncaught TypeError: deprecationSite.getFileName is not a function

At /Applications/Atom Beta.app/Contents/Resources/app/node_modules/grim/lib/grim.js:56

TypeError: deprecationSite.getFileName is not a function
  at Object.deprecate (<embedded>:16700:42)
  at Function.module.exports.Marker.extractParams (<embedded>:118459:20)
  at MarkerLayer.module.exports.MarkerLayer.markRange (<embedded>:72669:77)
  at DisplayMarkerLayer.module.exports.DisplayMarkerLayer.markBufferRange (<embedded>:119072:58)
  at TextEditor.module.exports.TextEditor.markBufferRange (<embedded>:4101:44)
  at SearchModel.module.exports.SearchModel.start (/packages/incremental-search/lib/search-model.coffee:99:35)
  at /packages/incremental-search/lib/search-model.coffee:59:6)
  at InputView.module.exports.InputView.initialize (/packages/incremental-search/lib/input-view.coffee:25:24)
  at /packages/merge-conflicts/node_modules/space-pen/lib/space-pen.js:184:25)
  at /packages/incremental-search/lib/input-view.coffee:8:3)
  at Object.createViews (/packages/incremental-search/lib/isearch.coffee:38:22)
  at Object.findPressed (/packages/incremental-search/lib/isearch.coffee:31:6)
  at /packages/incremental-search/lib/isearch.coffee:12:92)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (<embedded>:21775:35)
  at <embedded>:21513:65
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (<embedded>:66625:22)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (<embedded>:66416:28)
  at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (<embedded>:18116:42)
  at HTMLDocument.<anonymous> (<embedded>:18019:65)

Commands

  2x -4:11.3.0 editor:select-to-end-of-word (input.hidden-input)
     -4:10.8.0 editor:select-to-beginning-of-word (input.hidden-input)
     -4:10.4.0 nuclide-datatip:toggle (input.hidden-input)
     -4:07.6.0 incremental-search:backward (input.hidden-input)
 14x -2:37.2.0 core:move-up (input.hidden-input)
 14x -2:33.1.0 core:move-down (input.hidden-input)
     -0:32.4.0 find-and-replace:show (input.hidden-input)
     -0:26.5.0 find-and-replace:focus-next (input.hidden-input)
 22x -0:24.9.0 core:backspace (input.hidden-input)
     -0:23.7.0 editor:consolidate-selections (input.hidden-input)
     -0:23.7.0 core:cancel (input.hidden-input)
     -0:20.8.0 intentions:highlight (input.hidden-input)
     -0:20.4.0 editor:move-to-beginning-of-word (input.hidden-input)
     -0:20.1.0 editor:select-to-end-of-word (input.hidden-input)
     -0:19.8.0 nuclide-datatip:toggle (input.hidden-input)
     -0:10.7.0 incremental-search:backward (input.hidden-input)

Non-Core Packages

ask-stack 2.2.0 
atom-beautify 0.30.3 
atom-ctags 5.1.0 
atom-elixir 0.2.3 
atom-material-numix-syntax 0.2.1 
atom-material-syntax 1.0.6 
atom-material-syntax-dark 1.0.0 
atom-material-ui 2.0.4 
atom-terminal 0.8.0 
atom-wallaby 1.0.18 
autocomplete-meteor-packages 1.3.0 
blame 0.12.0 
busy-signal 1.4.3 
color-picker 2.2.5 
cucumber 0.6.0 
dash 1.7.1 
docker 0.7.0 
emmet 2.4.3 
erb-helper 1.1.0 
ever-notedown 0.2.27 
execute-as-ruby 0.2.1 
expand-region 0.3.0 
file-icons 2.1.8 
firacode 0.3.0 
fonts 3.0.2 
git-control 0.9.0 
git-history 3.3.0 
git-time-machine 1.5.9 
Hydrogen 1.18.0 
incremental-search 5.2.2 
intentions 1.1.2 
language-docker 1.1.8 
language-elixir 0.19.0 
language-rspec 0.6.2 
language-slim 0.5.0 
language-sql-mysql 0.3.1 
last-cursor-position 0.9.2 
linter 2.2.0 
linter-docker 0.2.0 
linter-elixirc 1.6.0 
linter-rubocop 2.1.1 
linter-ruby 1.2.5 
linter-ui-default 1.6.2 
local-history 4.3.0 
markdown-preview-plus 2.4.9 
material-monokai-syntax 1.0.1 
material-syntax 0.6.1 
material-ui 1.0.10 
merge-conflicts 1.4.5 
meteor-api 2.20.0 
meteor-helper 0.29.0 
meteor-snippets 0.5.0 
minimap 4.28.2 
mocha 0.0.7 
mocha-test-runner 1.0.0 
monokai 0.24.0 
native-ui 0.21.0 
nuclide 0.232.0 
pigments 0.39.1 
platformio-ide-terminal 2.5.1 
project-manager 3.3.5 
rails-rspec 0.3.2 
react 0.16.2 
remote-atom 1.3.10 
ruby-block-converter 4.0.1 
ruby-bundler 0.3.0 
ruby-test 1.0.2 
ruby-test-switcher 1.2.3 
script 3.15.0 
Sublime-Style-Column-Selection 1.7.4 
tree-view-git-modified 0.7.2

Toolbar buttons don't activate on mouse click

They only work if you press the keybinding.

Won't work?

Hi,

sorry for such a lazy title, but hopefully here's more insight to it:

Atom Version 0.184.0 (0.184.0)
incremental-search 4.2.0
Mac OS X 10.10.2

Although cmd-i will popup the incremental search box below the editor area, when I hit keys on my keyboard nothing will happen (meaning not that it won't actually find anything, but pressed keys won't even appear on the search/find field).

Any ideas?

Thank you.

Function.extractParams is deprecated.

Assigning custom properties to a marker when creating/copying it is
deprecated. Please, consider storing the custom properties you need in
some other object in your package, keyed by the marker's id property.

Function.extractParams (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker.js:43:14)
MarkerLayer.markRange (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:196:71)
DisplayMarkerLayer.markBufferRange (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/display-marker-layer.js:90:62)
TextEditor.markBufferRange (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:1753:38)
SearchModel.start (/Users/<user>/.atom/packages/incremental-search/lib/search-model.coffee:79:45)
new SearchModel (/Users/<user>/.atom/packages/incremental-search/lib/search-model.coffee:34:12)

Uncaught TypeError: undefined is not a function

[Enter steps to reproduce below:]

Atom Version: 1.0.11
System: Microsoft Windows 8.1 Pro
Thrown From: incremental-search package, v5.0.1

Stack Trace

Uncaught TypeError: undefined is not a function

At /C:/Users/lukas/.atom/packages/incremental-search/lib/search-model.coffee:230

TypeError: undefined is not a function
  at SearchModel.module.exports.SearchModel.findMarkerForward (C:\Users\lukas\.atom\packages\incremental-search\lib\search-model.coffee:226:77)
  at SearchModel.module.exports.SearchModel.moveToClosestResult (C:\Users\lukas\.atom\packages\incremental-search\lib\search-model.coffee:211:52)
  at SearchModel.module.exports.SearchModel.updateMarkers (C:\Users\lukas\.atom\packages\incremental-search\lib\search-model.coffee:200:6)
  at SearchModel.module.exports.SearchModel.update (C:\Users\lukas\.atom\packages\incremental-search\lib\search-model.coffee:273:8)
  at InputView.module.exports.InputView.updateSearchText (C:\Users\lukas\.atom\packages\incremental-search\lib\input-view.coffee:85:18)
  at C:\Users\lukas\.atom\packages\incremental-search\lib\input-view.coffee:30:50
  at Emitter.module.exports.Emitter.emit (C:\Users\lukas\AppData\Local\atom\app-1.0.11\resources\app.asar\node_modules\event-kit\lib\emitter.js:82:11)
  at C:\Users\lukas\AppData\Local\atom\app-1.0.11\resources\app.asar\node_modules\text-buffer\lib\text-buffer.js:1263:25

Commands

     -0:31.7.0 core:close (atom-text-editor.editor.is-focused)
 21x -0:30.1.0 incremental-search:forward (atom-text-editor.editor.is-focused)
     -0:23 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:23 core:cancel (atom-text-editor.editor.mini.is-focused)
     -0:21.8.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:21.8.0 core:cancel (atom-text-editor.editor.mini.is-focused)
     -0:21.7.0 command-palette:toggle (atom-text-editor.editor.mini.is-focused)
     -0:20.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:20.4.0 window:run-package-specs (atom-text-editor.editor.mini)
     -0:08.3.0 command-palette:toggle (atom-text-editor.editor.is-focused)
     -0:07.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:07.7.0 editor:toggle-soft-wrap (atom-text-editor.editor)
     -0:06.7.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:06.7.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:05.7.0 incremental-search:forward (atom-text-editor.editor.is-focused)
     -0:04.3.0 editor:select-to-first-character-of-line (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "twilight-textmate-syntax"
    ]
  }
}

Installed Packages

# User
angularjs, v0.3.0
atom-alignment, v0.12.1
atom-ternjs, v0.7.2
atomatigit, v1.5.4
change-case, v0.6.0
color-picker, v2.0.11
incremental-search, v5.0.1
language-diff, v0.3.1
language-mason, v2.0.4
twilight-textmate-syntax, v0.1.19

# Dev
No dev packages

Deprecated Atom APIs will be removed June 1st

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (4.3.0) of this package:

Store package style sheets in the styles/ directory instead of stylesheets/ in the <pack-name> package
Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows: json "activationCommands": { "atom-workspace": ["foo:bar", "foo:baz"], "atom-text-editor": ["foo:quux"] }
Use a config schema instead. See the configuration section of https://atom.io/docs/latest/hacking-atom-package-word-count and https://atom.io/docs/api/latest/Config for more details
atom.workspaceView is no longer available. In most cases you will not need the view. See the Workspace docs for alternatives: https://atom.io/docs/api/latest/Workspace. If you do need the view, please use atom.views.getView(atom.workspace), which returns an HTMLElement.
Requiring $ from atom is no longer supported. If you are using space-pen, please require $ from atom-space-pen-views. Otherwise require jquery instead: {$} = require 'atom-space-pen-views' or $ = require 'jquery' Add "atom-space-pen-views": "^2.0.3" to your package dependencies. Or add "jquery": "^2" to your package dependencies.
Requiring EditorView from atom is no longer supported. Please require TextEditorView from atom-space-pen-view instead: {TextEditorView} = require 'atom-space-pen-views' Add "atom-space-pen-views": "^2.0.3" to your package dependencies.
Requiring View from atom is no longer supported. Please require atom-space-pen-views instead: {View} = require 'atom-space-pen-views' Add "atom-space-pen-views": "^2.0.3" to your package dependencies.
TextBuffer::on is deprecated. Use event subscription methods instead.
Use TextEditor::onDidStopChanging instead
Use TextEditor::getLastCursor() instead

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.

If this package has been replaced by another package or functionality in core, please reply with this information.

See atom/atom#6867 for more info. Thanks!

Uncaught TypeError: undefined is not a function

[Enter steps to reproduce below:]

Cmd-I to enter incremental search
Type something
Press Esc to try and close the Incremental Search

Atom Version: 0.207.0
System: Mac OS X 10.10.3
Thrown From: incremental-search package, v5.0.1

Stack Trace

Uncaught TypeError: undefined is not a function

At /Users/afinne/.atom/packages/incremental-search/lib/search-model.coffee:168

TypeError: undefined is not a function
  at SearchModel.module.exports.SearchModel.cleanup (/Users/afinne/.atom/packages/incremental-search/lib/search-model.coffee:168:32)
  at SearchModel.module.exports.SearchModel.cancelSearch (/Users/afinne/.atom/packages/incremental-search/lib/search-model.coffee:151:6)
  at InputView.module.exports.InputView.cancelSearch (/Users/afinne/.atom/packages/incremental-search/lib/input-view.coffee:147:18)
  at space-pen-div.subscriptions.add.atom.commands.add.core:cancel (/Users/afinne/.atom/packages/incremental-search/lib/input-view.coffee:37:26)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:238:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:520:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:355:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:177:20)

Commands

  2x -1:21.7.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -1:20.7.0 core:select-down (atom-text-editor.editor.is-focused)
     -1:20.4.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:19.9.0 core:move-down (atom-text-editor.editor.is-focused)
     -1:19.8.0 core:move-left (atom-text-editor.editor.is-focused)
     -1:04.6.0 core:move-right (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:04.3.0 core:move-down (atom-text-editor.editor.is-focused)
  2x -1:04.2.0 core:move-left (atom-text-editor.editor.is-focused)
     -0:17.4.0 find-and-replace:show (atom-text-editor.editor.is-focused)
     -0:15.4.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:15.4.0 git-diff-details:close-git-diff-details (atom-text-editor.editor.mini.is-focused)
     -0:15.4.0 core:cancel (atom-text-editor.editor.mini.is-focused)
  2x -0:14.7.0 incremental-search:forward (atom-text-editor.editor.is-focused)
     -0:01.8.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:01.8.0 git-diff-details:close-git-diff-details (atom-text-editor.editor.mini.is-focused)
     -0:01.8.0 core:cancel (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "tree-view-open-files",
      "language-mustache",
      "atom-handlebars",
      "better-handlebars",
      "compare-files"
    ],
    "destroyEmptyPanes": false
  }
}

Installed Packages

# User
Termrk, v0.1.17
file-icons, v1.5.7
git-control, v0.3.0
git-diff-details, v0.18.0
incremental-search, v5.0.1
language-ember-htmlbars, v0.3.0
linter, v0.12.6
linter-coffeelint, v0.3.2
linter-handlebars, v0.1.1
linter-rubocop, v0.2.7
linter-ruby, v0.1.6
minimap, v4.9.4
pretty-json, v0.3.3
project-manager, v1.15.10
tag, v0.3.0

# Dev
No dev packages

Deprecated selector in `incremental-search/styles/isearch.less`

In incremental-search/styles/isearch.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor::shadow .isearch-result .region, atom-text-editor .isearch-result .region => atom-text-editor.editor .isearch-result .region, atom-text-editor .isearch-result .region
atom-text-editor::shadow .isearch-current .region, atom-text-editor .isearch-current .region => atom-text-editor.editor .isearch-current .region, atom-text-editor .isearch-current .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Uncaught TypeError: this.editSession.getBuffer(...).off is not a function

[Enter steps to reproduce below:]

Atom Version: 1.0.19
System: Mac OS X 10.11.1
Thrown From: incremental-search package, v5.0.1

Stack Trace

Uncaught TypeError: this.editSession.getBuffer(...).off is not a function

At /Users/rotemy/.atom/packages/incremental-search/lib/search-model.coffee:168

TypeError: this.editSession.getBuffer(...).off is not a function
  at SearchModel.module.exports.SearchModel.cleanup (/Users/rotemy/.atom/packages/incremental-search/lib/search-model.coffee:168:32)
  at SearchModel.module.exports.SearchModel.cancelSearch (/Users/rotemy/.atom/packages/incremental-search/lib/search-model.coffee:151:6)
  at InputView.module.exports.InputView.cancelSearch (/Users/rotemy/.atom/packages/incremental-search/lib/input-view.coffee:147:18)
  at space-pen-div.subscriptions.add.atom.commands.add.core:cancel (/Users/rotemy/.atom/packages/incremental-search/lib/input-view.coffee:37:26)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:245:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:184:20)

Commands

     -0:09.4.0 incremental-search:forward (atom-text-editor.editor.is-focused)
     -0:06.4.0 editor:delete-to-beginning-of-word (atom-text-editor.editor.mini.is-focused)
     -0:03.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:02.4.0 core:move-right (atom-text-editor.editor.mini.is-focused)
     -0:02.2.0 core:move-left (atom-text-editor.editor.mini.is-focused)
     -0:01.3.0 editor:consolidate-selections (atom-text-editor.editor.mini.is-focused)
     -0:01.3.0 core:cancel (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ],
    "openEmptyEditorOnStart": false
  }
}

Installed Packages

# User
color-picker, v2.0.13
emmet, v2.3.13
file-icons, v1.6.11
incremental-search, v5.0.1
linter, v1.9.0
linter-jshint, v1.2.1
linter-pylint, v1.0.3

# Dev
No dev packages

Deprecated selector in `incremental-search\styles\isearch.less`

In incremental-search\styles\isearch.less:

atom-text-editor::shadow .isearch-result .region, atom-text-editor .isearch-result .region => atom-text-editor.editor .isearch-result .region, atom-text-editor .isearch-result .region
atom-text-editor::shadow .isearch-current .region, atom-text-editor .isearch-current .region => atom-text-editor.editor .isearch-current .region, atom-text-editor .isearch-current .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Improve history by keeping options and storing more than last

Increase default history size to 20
Add an option to control history size
Add keys for cycling up and down in history
Keep options (regex and case) with history items

Package.getActivationCommands is deprecated.

Use activationCommands instead of activationEvents in your package.json
Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }

Package.getActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:808:9)
Package.hasActivationCommands (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:733:20)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:187:24)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:165:15)
Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:179:12)
PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:372:14)

Installed atom-incremental-search, atom is keep crushing or unresponsive

Installing it crush the editor. Open the editor with incremental search take ages and sometime crash

Atom 1.0.19

missing keybinding for non-osx users

The only keybindings included are for osx users.
I'm on linux and I quickly hacked it by adding to isearch.cson:

'.editor':
  'ctrl-i' : 'incremental-search:forward'
  'shift-cmd-i': 'incremental-search:backward'

no idea if that's the right way to do it, but it seems to be working for me.
Thanks for the very useful plugin.

Uncaught TypeError: this.editSession.getCursor is not a function

[Enter steps to reproduce below:]

cmd-i to start incremental search.
search anything existing in the current file
cmd-e

Atom Version: 1.0.19
System: Mac OS X 10.11
Thrown From: incremental-search package, v5.0.1

Stack Trace

Uncaught TypeError: this.editSession.getCursor is not a function

At /Users/perseghini/.atom/packages/incremental-search/lib/search-model.coffee:113

TypeError: this.editSession.getCursor is not a function
  at SearchModel.module.exports.SearchModel.slurp (/Users/perseghini/.atom/packages/incremental-search/lib/search-model.coffee:113:27)
  at InputView.module.exports.InputView.slurp (/Users/perseghini/.atom/packages/incremental-search/lib/input-view.coffee:70:18)
  at space-pen-div.subscriptions.add.atom.commands.add.incremental-search:slurp (/Users/perseghini/.atom/packages/incremental-search/lib/input-view.coffee:41:39)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:245:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:184:20)

Commands

     -0:31.3.0 find-and-replace:use-selection-as-find-pattern (atom-text-editor.editor.is-focused)
     -0:28.2.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:28.2.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:26.2.0 find-and-replace:use-selection-as-find-pattern (atom-text-editor.editor.is-focused)
     -0:23 core:move-right (atom-text-editor.editor.mini.is-focused)
  2x -0:22.6.0 core:backspace (atom-text-editor.editor.mini.is-focused)
  2x -0:19.4.0 find-and-replace:find-next (atom-text-editor.editor.mini.is-focused)
  4x -0:17.8.0 core:move-up (atom-text-editor.editor.is-focused)
  3x -0:16.6.0 core:move-left (atom-text-editor.editor.is-focused)
     -0:15.9.0 find-and-replace:use-selection-as-find-pattern (atom-text-editor.editor.is-focused)
 26x -0:13.7.0 core:move-up (atom-text-editor.editor.is-focused)
     -0:09.4.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:09.4.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:08.6.0 incremental-search:forward (atom-text-editor.editor.is-focused)
 10x -0:07.6.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:01.4.0 incremental-search:slurp (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ],
    "disabledPackages": [
      "linter-pep257",
      "vim-mode"
    ],
    "packagesWithKeymapsDisabled": []
  }
}

Installed Packages

# User
atom-beautify, v0.28.15
atom-material-syntax, v0.2.4
atom-material-ui, v0.6.2
autocomplete-python, v0.8.2
clipboard-history, v0.6.6
color-picker, v2.0.13
file-icons, v1.6.11
git-log, v0.4.1
highlight-selected, v0.10.1
incremental-search, v5.0.1
last-cursor-position, v0.9.0
linter, v1.9.1
linter-flake8, v1.9.1
pigments, v0.18.0
wakatime, v5.0.0
white-cursor, v0.6.0

# Dev
No dev packages

Found word is not getting highlighted with Shadow Dom enabled

Search for a word, and it finds one, word doesn't have a border around it. I haven't look into why, yet.

Package.getStylesheetsPath is deprecated.

Store package style sheets in the styles/ directory instead of stylesheets/ in the incremental-search package

Package.getStylesheetsPath (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:460:9)
Package.getStylesheetPaths (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:471:32)
Package.loadStylesheets (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:453:38)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:185:19)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:165:15)
Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:179:12)

Get slurping working again

When I took over the package from the original author and I got this package working on Atom 1.0 API with the exception of the slurping feature.

I hope someone wants to take a crack at it. If so I'll add you as a maintainer of this repo and package.

selecting all instances of a regex search

this is a feature request: when you do a regex search with cmd-f, rather than just being able to select one instance at a time, you can hit alt-g and select all of them with multiple cursors. same thing is available on sublime text

btw, excellent package

0.194: "Failed to load the incremental-search package"

Atom updated itself to .194, and threw up on three packages, including isearch. Atom's complaint seems to be:

Cannot read property 'prototype' of undefined

More (automated) info below.

Thanks!

Atom Version: 0.194.0 ⚠️ in 1.0 API Preview Mode ⚠️
System: Mac OS X 10.10.3
Thrown From: incremental-search package, v4.3.0

Stack Trace

Failed to load the incremental-search package

At Cannot read property 'prototype' of undefined

TypeError: Cannot read property 'prototype' of undefined
    at __extends (/Users/burleigh/.atom/packages/incremental-search/lib/input-view.coffee:5:199)
    at /Users/burleigh/.atom/packages/incremental-search/lib/input-view.coffee:12:5
    at Object.<anonymous> (/Users/burleigh/.atom/packages/incremental-search/lib/input-view.coffee:252:5)
    at Object.<anonymous> (/Users/burleigh/.atom/packages/incremental-search/lib/input-view.coffee:254:4)
    at Module._compile (module.js:452:26)
    at Object.requireCoffeeScript (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
    at Module.load (module.js:347:32)
    at Function.Module._load (module.js:302:12)
    at Module.require (module.js:357:17)
    at require (module.js:376:17)

Commands

Config

{
  "core": {
    "disabledPackages": [
      "autocomplete-plus",
      "linter-tidy",
      "wrap-guide"
    ],
    "themes": [
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
atom-xsltransform, v0.1.0
autoclose-html, v0.15.0
block-cursor, v0.12.4
emmet, v2.3.8
git-log, v0.3.0
git-tab-status, v1.7.0
incremental-search, v4.3.0
linter, v0.12.1
linter-jshint, v0.1.2
linter-php, v0.0.12
linter-scss-lint, v0.0.14
linter-xmllint, v0.0.5
open-recent, v2.2.2
pain-split, v1.3.1
project-manager, v1.15.5
regex-railroad-diagram, v0.7.4
remote-edit, v1.7.2
script, v2.19.0

# Dev
No dev packages

Invalid regex throws console error.

I know, I'm getting nitpicky now.

Scrolls to lastPosition if tool panel is open and entering text somewhere else

Steps to reproduce:

Open panel
enter text found on page
scroll window down/up
enter character

"Enter" only works on first incremental search

(This is on OSX, Atom 0.177.0, incremental-search 4.2.0.)

First time it works fine. ⌘i, type a word, hit enter, end up with that word selected and the incremental search stops. But now when I repeat; ⌘i, type a word (word gets selected), and hit enter, nothing happens -- the search box does not disappear (escape works and gets me back to where I started).

isearch doesn't keep track of the current text editor in the active pane

When I switch tabs, incremental search continues to point at the tabI switched from, rather than changing tabs with me. In addition to being generally frustrating (since cancelling the search with core:cancel / Esc doesn't fix the problem, just stopping it with core:confirm / Enter), this also causes #27 (which is still present after the API changes).

gangstead / atom-incremental-search Goto Github PK

atom-incremental-search's People

Contributors

Stargazers

Watchers

Forkers

atom-incremental-search's Issues

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Steps to repro:

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Non-Core Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Stack Trace

Commands

Config

Installed Packages

Recommend Projects

Recommend Topics

Recommend Org