Comments (5)
hah! Nice find.
FWIW, that implementation of the donation page is no longer used (at least by GDQ), and has been replaced by a React-based version that lives at the URL /tracker/ui/donate/<eventid or shortname>
for quite a while now. The code for that lives under bundles/tracker/donation
. I also got very confused when I first looked at this repo and didn't realize there were two versions around lol.
My understanding is that the old form is ready and meant to be removed entirely, but that it just hasn't been done yet. With that, I'm not sure if this will get fixed in this repo (old forks may still be using this form, but they'd be pretty old and it's not worth maintaining in this repo for them).
Still an interesting case though!
from donation-tracker.
Ahhh, so is it donate page that is causing the error on the donation viewing page?
from donation-tracker.
Oh! I completely misread! I thought this was on the form, not viewing existing donations.
No, that is all still handled by django's templates, so this is totally valid. Sorry for jumping to the wrong conclusion.
from donation-tracker.
No problem. That makes sense why I couldn't understand your reply.
I think the commentstate
variable may be undefined in the template because it needs to reference an object, but I'm not sure how the data is laid out.
from donation-tracker.
This looks like it was addressed in #191, so I'm going to close it as resolved. Loading the page, the commentstate is appropriately put as a class name on the td
, and there's no "invalid variable" anymore.
from donation-tracker.
Related Issues (16)
- Incentive amount allocated before changing donation amount invalidates settings HOT 2
- [Feature Request] Jump to current time in /schedule HOT 4
- Dependabot couldn't authenticate with https://pypi.python.org/simple/
- Dependabot couldn't authenticate with https://pypi.python.org/simple/
- Commentators missing from runs HOT 3
- v2 API mostly returns HTTP 500s HOT 2
- Anonymous donos from previous donors are using their previously listed alias HOT 5
- Allow event slugs to contain dashes HOT 4
- Allow custom bid names to include spaces. HOT 1
- [Crash] Deleting a Speed Run through the actions
- Document `PAYPAL_TEST` constant
- Router with basename is already registered HOT 9
- [FYI] This code is being included in a large code dataset without notice
- Missing "can edit locked events" pemission causes tracker crash HOT 1
- Broken links on Admin Home page HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from donation-tracker.