Comments (7)
It would, but we used to start with 20.04 as seen here:
1918fe8#diff-b093d34eec92adf6e0cc6e445edb7147ea45d25fb0c98f2f84a60f5aae6f34f7R1
And we had to downgrade since officially supported ubuntu version for Unity is is still 18.04 π€¦
ref: * 438d326 - Change to ubuntu 18.04 (#44) (3 months ago)
which solves a nuanced issue with libasound2 and makes our images go back to the officially supported OSes range.
So I'm not sure ubuntu upgrade is the way to go for this.
from docker.
I'm using the latest LTS (long term support) version of Unity which is currently 2019.4.19f1. If this version is only supported on Ubuntu 18.04 I think that should remain the base image.
Here's what I'm doing at the start of my job to update the Git versionΒ :
apt-get -qq update && apt-get -qq -o=Dpkg::Use-Pty=0 --no-install-recommends install gnupg1
echo 'deb http://ppa.launchpad.net/git-core/ppa/ubuntu bionic main' > /etc/apt/sources.list.d/git.list
apt-key adv --keyserver keyserver.ubuntu.com --recv-keys E1DD270288B4E6030699E45FA1715D88E1DF1F24
apt-get -qq update && apt-get -qq -o=Dpkg::Use-Pty=0 --no-install-recommends git
The more conventional way to add a PPA is to install software-properties-common
and use its add-apt-repository
script but I felt it added to much bloat so I just added the minimum necessary to install the additional Git PPA.
One more note: the warning about Git 2.17 only appears if you run the @actions/checkout
action in the unityci/editor
image. This happens for me because I added container: { image: unityci/editor:2019.4.19f1 }
at the job
level, for simplicity, so all of my job's steps run under the unityci/editor
image. I guess if you only use the Docker image through actions such as https://github.com/marketplace/actions/unity-builder , the @actions/checkout
action will run on the host and probably have a recent enough Git version.
from docker.
Would this be fixed by updating to Ubuntu 20.04 for our images?
from docker.
And we had to downgrade since officially supported ubuntu version for Unity is is still 18.04 π€¦
Just FYI Ubuntu 20 is now officially supported by Unity 2020.2. https://docs.unity3d.com/2020.2/Documentation/Manual/system-requirements.html
Not sure if it's worth maintaining differently built images for different Unity versions though.
from docker.
Yea it's officially support for the latest unity versions. We tried to go Ubuntu 20.04 but it was creating new bugs for older versions of Unity.
If we have reason to believe that this git error only occurs the latest versions of Unity we might consider creating a second base image for newer versions. Otherwise it will be far simpler to fix the problem across the board, at least for now.
from docker.
Thanks for adding the additional information. I was wondering where the whole GitHub Rest API magic came from :)
In light of this information I would argue that the change should be out of scope for now. As it is indeed not necessary for any of the workflows in the documentation. Adding the latest git above the OSes stability level could technically cause other problems on the way.
Let me know if this would be an acceptable outcome.
from docker.
That's fine by me, as mentioned I already know how to update Git in the container. π
from docker.
Related Issues (20)
- Missing WebGL/Android building docker containers for Windows HOT 2
- Build Failed on unityci/editor:2021.3.22f1-windows-mono-1.1 HOT 1
- Support for Windows Server 2022 HOT 1
- Build fails for editor-ubuntu-2023.1.0f1-webgl-1.1.2 with URP
- Update ubuntu version from 18.04 to 22.04 HOT 3
- Manifest unknown for certain images on unityci/editor but not for others. HOT 2
- Stop supporting EOL versions of Unity Editor
- manifest for unityci/editor:2022.3.8f1-linux-il2cpp-1 not found HOT 1
- manifest for unityci/editor:windows-2021.3.16f1-webgl-2 not found HOT 1
- "Build succeeded" but still getting "There was an error..." HOT 1
- Pass env vars set in workflow file to docker environment HOT 6
- Fail to build containers because of failing git lfs checkout HOT 2
- docker: invalid reference format: repository name must be lowercase. HOT 4
- Unable to Generate Logs and Hanging Execution with unityci/editor Docker Image on Mac with Apple Silicon HOT 1
- xvfb-run is not invoked as root user when using runAsHostUser
- GameCI WebGL builds have no audio. HOT 1
- Licensing issue with non root user
- Intermittent crashes when running unity builds on docker.
- Dedicated Server support for Linux is not installed after updating from 2022.3.16f1 to 6000.0.0f1 HOT 9
- Error when pulling ci editor image for version 2022.3.29.f1 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker.