gagamen / dominionizer Goto Github PK

Describe the bug
It is possible that 'Horse' can be generated into a set.

To Reproduce
Steps to reproduce the behavior:

1. Generate with expansion 'Menagerie' until 'Horse' is shown under 'Kingdom Cards'.

Expected behavior
'Horse' should never be defined as kingdom card.

Lint-stage doesn't work correctly with the latest release of markdownlint-cli, because markdownlint doesn't understand absolute paths passed by lint-staged.

There is a merged pull request, which fixes this error.

Update markdownlint-cli on next release.

Describe the bug
There are combo expansions like Cornucopia & Guilds.
Such expansions aren't detected by the wiki-bot and therefore the 2nd edition of Cornucopia & Guilds isn't reflected in the generated data.

To Reproduce
Steps to reproduce the behavior:

1. run wiki-bot

Expected behavior
wiki-bot should also detect combo expansions.

Is your feature request related to a problem? Please describe.
The second edition of the Prosperity expansion is missing from the generator.

Describe the solution you'd like
Add the new (reworked) expansion as an expansion select option.

Additional context
The cards of the second edition can be found here.

Describe the bug
The format of some icons is incorrect (e.g. Potion, Alchemy).

To Reproduce
Steps to reproduce the behavior:

1. Generate set with expansion Alchemy.

Expected behavior
All icons should have the correct aspect ratio.

In 60b16bb linting packages were updated, which introduced new rules that threw errors. To complete the update these rules were disabled.

For higher code quality these rules should be enabled again and the errors should be fixed.

Describe the bug
With fb12998 the implementation of the background color of CardComponent was refactored. In this event the contrast optimizations for night cards weren't migrated (text and buttons).

To Reproduce
Steps to reproduce the behavior:

1. Choose "Nocturne".
2. Generate until a night card is shown.

Expected behavior
Display text and button in white for better contrast.

Describe the bug
It seems that the first edition of Cornucopia & Guilds hasn't a specific icon. So there is no File:Cornucopia_&_Guilds_old_icon.png. For cards, that are only in the first edition, accordingly no expansion icon is displayed.

To Reproduce
Steps to reproduce the behavior:

1. Choose 'Cornucopia & Guilds (1. Edition)'
2. Generate (possibly multiple times)

Expected behavior
As fallback the icon File:Cornucopia_&_Guilds_icon.png should be displayed.

Is your feature request related to a problem? Please describe.
The wikibot doesn't log a validation error if a card has an image url but there is no corresponding image file in the output.
This can happen if the wiki authors forget to add the card art to the correct category.

Describe the solution you'd like
The wikibot should log a validation error in this case.
On an update run it must take image files from previous runs into account.

Describe the bug
Wrong redirect from configuration to start page if no expansions are selected.

To Reproduce
Steps to reproduce the behavior:

1. Generate without selecting an expansion

Expected behavior
It should not redirect and show a form error instead.