gaelmagnan / pygithook Goto Github PK

To improve the quality of the project it would be nice to have a good way of testing.

The problem comes from the hooks deep integration with GIT.

As of now the best solution to the problem I've found is to create a script that would clone a repo twice (once as server one as client) would create the right hooks and would then go through a series of steps (probably git tags) to test all of the Hooks/Tasks.

If anyone has a better idea or is motivated to try to have a go at it, I would greatly appreciate it.

It is a bad practice to use as default value a mutable type (list, dict, set...) like:

1. On src/Hooks/Hook.py:
   - In def init(self, tasks=[], conf_location=""), line: 18
   - In def main(_klass, tasks=[],conf_location="")

The fix is some things like this:
def init(self, tasks=None, conf_location=""):
if tasks is None:
tasks = []