gabygold67 / fourbitleddigitaltube Goto Github PK

Add the methods needed to validate the limits for the .setBlinkRate() method. For security reasons the minimum and maximum blinking rates might be kept as constants (or not), but a way of knowing those values must be provided to the developers.

The negative numbers fail to print to the display when they are left aligned.
The error doesn't affect the display when the negative numbers are right aligned, not standard (space) paded, nor zero padded

Add the correspondent header to the sample files to comply to the Arduino Style Guide for creating Libraries

The parameter that aligns to the right the display seems to not be implemented yet

The parameter that completes the trailing spaces of the display with 0s (zeroes) doesn't seem to be implemented yet, or it's not working

When using more than one display at the same time each one shows some of the digits, while the others show some other, seems that each one have the digits the others don't

To keep a coherent design pattern, if changes proposed in issue #6 are implemented, the .setBlinkRate() method must include a second optional parameter for the timeOff time of the assymmetrical blinking pattern.
The lack of the second parameter forces a design decision:

• The timeOff time is kept with no changes.
• The timeOff must be equaled to the timeOn, ensuring a symmetrical blink.

A possible decision could be based on the timeOn and timeOff values previous to the .setBlinkRate() call, if they where equal, the lack of second parameter would suggest keeping the symmetrical scheme, while the different timeOn and timeOff values would suggest the lack of the second parameter to be an indication of just changing the timeOn value.

In the current implementation the .blink() method accepts no arguments, the blinking starts to a prefixed speed and must be immeditely modified if it doesn't satisfy the required speed.
An optional parameter must be added giving the opportunity to start off with the right speed, without the need of the immediate speed change. As it will be optional, old implementations using the no parameters version won't be affected.

The parameter doesn't seem to be implemented in the print(float) method, it was supposed to let print the -1<Value<1 values without the leading 0 (zero digit)

When working with negative numbers, setting the right align option and padding, the result displayed is wrong formatted, the padding chars must be placed between the digits and the '-' sign