gabr42 / gpdelphiunits Goto Github PK

   TCommandLine = class
   public
      [CLPName('silent'), CLPDescription('Service installation silent', '<silent>')]
      property silent: Boolean read Fsilent write Fsilent;
      [CLPName('install'), CLPDescription('Service installation', '<install>')]
      property install: Boolean read Finstall write Finstall;
      [CLPName('uninstall'), CLPDescription('Service installation', '<uninstall>')]
      property uninstall: Boolean read FUninstall write FUninstall;
      [CLPName('gui'), CLPDescription('IW gui FrontieraMode', '<gui>')]
      property gui: Boolean read Fgui write Fgui;
      [CLPName('c'), CLPLongName('cfg'), CLPDescription('Set the run configuration', '<runconfiguration>'), CLPDefault('0')]
      property ConfigNumber: Integer read FConfigNumber write FConfigNumber;
      [CLPName('cn'), CLPLongName('cfgname'), CLPDescription('Set the run configuration by service name', '<runconfiguration>'),
         CLPDefault('')]
      property ConfigName: string read FConfigName write FConfigName;
   end;

In Unit GpHugeF.pas

the method OffsetPtr calculate a address in DWORD. This will fail in x64 and 
high pointers.

Suggestion is ...

function OffsetPtr(ptr: pointer; offset: DWORD): pointer;
begin
//BUG  Result := pointer(DWORD(ptr)+offset);
  Result := pointer(NativeUInt(ptr)+offset);
end; { OffsetPtr }

What steps will reproduce the problem?
1. Compile DSiWin32 with D2009

What is the expected output? What do you see instead?
C:\Dev\Delphi\Lib\OmniThreadLibrary\src\DSiWin32.pas(6396,53): error E2003: 
E2003 Undeclared identifier: 'SizeOf'

What version of the product are you using? On what operating system?
DSiWin32 1.72

Please provide any additional information below.

Construction "NonClientMetrics.SizeOf" supported since D2010, need change 
{$IFDEF Unicode}TNonClientMetrics.SizeOf{$ELSE}SizeOf(TNonClientMetrics){$ENDIF}
to
{$IF CompilerVersion < 
21.0}SizeOf(TNonClientMetrics){$ELSE}TNonClientMetrics.SizeOf{$IFEND}

In Unit GpHugeF.pas

the class (and some functions) use a Buffer-Offset. But this offset is defined 
as DWORD. 
Is there any possibility in X64 and very large files (I have >3GB-Files), that 
the BufOffset is too small?

  TGpHugeFile = class
  private
    hfAsynchronous     : boolean;
    hfBlockSize        : DWORD;
    (...)
    hfBufFilePos       : HugeInt; //cached FilePos (according the current hfBufOffs)
    hfBufOffs          : DWORD;   //current position inside the buffer


Suggestion:
   hfBufOffs          : HugeInt;

What steps will reproduce the problem?

Compile and run this code:

{$APPTYPE CONSOLE}
uses
  Windows, SysUtils, DSiWin32;
var
  S, S1: string;
  DSiReg: TDSiRegistry;

begin
  DSiReg := TDSiRegistry.Create;
  S := '0123456789';
  DSiReg.RootKey:=HKEY_CURRENT_USER;

  if DSiReg.OpenKey('Software\_Test', True) then
    DSiReg.WriteBinary('TESTKEY', S);

  S1 := DSiReg.ReadBinary('TESTKEY', '123');
  WriteLn(S1);
  FreeAndNil(DSiReg);
end.

What is the expected output? 
  0123456789
What do you see instead?
  01234

What version of the product are you using? On what operating system?
  Windows7 x32, Delphi 2009 or higher, DSiWin32 1.59b

Please provide any additional information below.

Fix:
Change line #1972 to
WriteBinaryData(name, pointer(data)^, Length(data)*SizeOf(data[1]));

What steps will reproduce the problem?
1. Copile GpStringHash with D7

What is the expected output? What do you see instead?

Will not compile

What version of the product are you using? On what operating system?

Latest from SVN

Please provide any additional information below.

See "patch" from attachments, get it to compile is pretty trivial) DSiWin32.pas 
I had to revert to the 1.55 version.

There should be some other enumerator implementation for Early Delphi versions, 
I could implement, if you just could give any info how you would implement it 
(so no need to send patch that you'll ever merge :) )

-Tommi Prami-